* [PATCH] usb: mtu3: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-11-16 8:34 Tian Tao
2020-11-25 2:33 ` Chunfeng Yun
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-11-16 8:34 UTC (permalink / raw)
To: chunfeng.yun, gregkh, matthias.bgg
Cc: linux-usb, linux-mediatek, linux-kernel, linux-arm-kernel
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/usb/mtu3/mtu3_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
index b3b4599..a6d7684 100644
--- a/drivers/usb/mtu3/mtu3_core.c
+++ b/drivers/usb/mtu3/mtu3_core.c
@@ -745,10 +745,9 @@ static irqreturn_t mtu3_u2_common_isr(struct mtu3 *mtu)
static irqreturn_t mtu3_irq(int irq, void *data)
{
struct mtu3 *mtu = (struct mtu3 *)data;
- unsigned long flags;
u32 level1;
- spin_lock_irqsave(&mtu->lock, flags);
+ spin_lock(&mtu->lock);
/* U3D_LV1ISR is RU */
level1 = mtu3_readl(mtu->mac_base, U3D_LV1ISR);
@@ -769,7 +768,7 @@ static irqreturn_t mtu3_irq(int irq, void *data)
if (level1 & QMU_INTR)
mtu3_qmu_isr(mtu);
- spin_unlock_irqrestore(&mtu->lock, flags);
+ spin_unlock(&mtu->lock);
return IRQ_HANDLED;
}
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: mtu3: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-11-16 8:34 [PATCH] usb: mtu3: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
@ 2020-11-25 2:33 ` Chunfeng Yun
0 siblings, 0 replies; 2+ messages in thread
From: Chunfeng Yun @ 2020-11-25 2:33 UTC (permalink / raw)
To: Tian Tao
Cc: gregkh, linux-usb, linux-kernel, linux-mediatek, matthias.bgg,
linux-arm-kernel
Hi Tao,
On Mon, 2020-11-16 at 16:34 +0800, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/usb/mtu3/mtu3_core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
> index b3b4599..a6d7684 100644
> --- a/drivers/usb/mtu3/mtu3_core.c
> +++ b/drivers/usb/mtu3/mtu3_core.c
> @@ -745,10 +745,9 @@ static irqreturn_t mtu3_u2_common_isr(struct mtu3 *mtu)
> static irqreturn_t mtu3_irq(int irq, void *data)
> {
> struct mtu3 *mtu = (struct mtu3 *)data;
> - unsigned long flags;
> u32 level1;
>
> - spin_lock_irqsave(&mtu->lock, flags);
> + spin_lock(&mtu->lock);
Sorry for late reply, I prefer to leave the code unchanged.
Thanks
>
> /* U3D_LV1ISR is RU */
> level1 = mtu3_readl(mtu->mac_base, U3D_LV1ISR);
> @@ -769,7 +768,7 @@ static irqreturn_t mtu3_irq(int irq, void *data)
> if (level1 & QMU_INTR)
> mtu3_qmu_isr(mtu);
>
> - spin_unlock_irqrestore(&mtu->lock, flags);
> + spin_unlock(&mtu->lock);
>
> return IRQ_HANDLED;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-25 2:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 8:34 [PATCH] usb: mtu3: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-11-25 2:33 ` Chunfeng Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).