* [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev
@ 2020-11-23 17:08 Robert Karszniewicz
2020-11-23 17:08 ` [PATCH 2/2] ARM: mach-imx: imx6q: Set system_rev to show soc revision Robert Karszniewicz
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2020-11-23 17:08 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, linux-arm-kernel
Cc: Peng Fan, Stefan Riedmueller, Anson Huang, Russell King,
NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam
From: Stefan Riedmueller <s.riedmueller@phytec.de>
Add the print of the CPU type and SOC revision during boot and also set
the system_rev variable to the SOC revision so the correct SOC revision
will be shown in /proc/cpuinfo.
Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
arch/arm/mach-imx/mach-imx6ul.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
index e018e716735f..9c92cc72b857 100644
--- a/arch/arm/mach-imx/mach-imx6ul.c
+++ b/arch/arm/mach-imx/mach-imx6ul.c
@@ -11,9 +11,11 @@
#include <linux/regmap.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
+#include <asm/system_info.h>
#include "common.h"
#include "cpuidle.h"
+#include "hardware.h"
static void __init imx6ul_enet_clk_init(void)
{
@@ -55,6 +57,10 @@ static inline void imx6ul_enet_init(void)
static void __init imx6ul_init_machine(void)
{
+ system_rev = imx_get_soc_revision();
+ imx_print_silicon_rev(cpu_is_imx6ull() ? "i.MX6ULL" : "i.MX6UL",
+ system_rev);
+
of_platform_default_populate(NULL, NULL, NULL);
imx6ul_enet_init();
imx_anatop_init();
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: mach-imx: imx6q: Set system_rev to show soc revision
2020-11-23 17:08 [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
@ 2020-11-23 17:08 ` Robert Karszniewicz
2020-12-04 14:15 ` [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
2021-01-05 1:31 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2020-11-23 17:08 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, linux-arm-kernel
Cc: Peng Fan, Stefan Riedmueller, Anson Huang, Russell King,
NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam
From: Stefan Riedmueller <s.riedmueller@phytec.de>
The system_rev value is shown in /proc/cpuinfo as Revision. Make use of
this by showing the SOC Revision there.
Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
arch/arm/mach-imx/mach-imx6q.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
index 703998ebb52e..4ec304de547a 100644
--- a/arch/arm/mach-imx/mach-imx6q.c
+++ b/arch/arm/mach-imx/mach-imx6q.c
@@ -15,6 +15,7 @@
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <asm/mach/arch.h>
#include <asm/mach/map.h>
+#include <asm/system_info.h>
#include "common.h"
#include "cpuidle.h"
@@ -245,16 +246,19 @@ static void __init imx6q_axi_init(void)
static void __init imx6q_init_machine(void)
{
- if (cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0)
+ if (cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0) {
/*
* SoCs that identify as i.MX6Q >= rev 2.0 are really i.MX6QP.
* Quirk: i.MX6QP revision = i.MX6Q revision - (1, 0),
* e.g. i.MX6QP rev 1.1 identifies as i.MX6Q rev 2.1.
*/
imx_print_silicon_rev("i.MX6QP", imx_get_soc_revision() - 0x10);
- else
+ system_rev = IMX_CHIP_REVISION_1_0;
+ } else {
imx_print_silicon_rev(cpu_is_imx6dl() ? "i.MX6DL" : "i.MX6Q",
imx_get_soc_revision());
+ system_rev = imx_get_soc_revision();
+ }
imx6q_enet_phy_init();
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev
2020-11-23 17:08 [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
2020-11-23 17:08 ` [PATCH 2/2] ARM: mach-imx: imx6q: Set system_rev to show soc revision Robert Karszniewicz
@ 2020-12-04 14:15 ` Robert Karszniewicz
2021-01-05 1:31 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2020-12-04 14:15 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, linux-arm-kernel
Cc: Peng Fan, Stefan Riedmueller, Anson Huang, Russell King,
NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam
Hello,
Any feedback on this series, please?
Regards,
Robert
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev
2020-11-23 17:08 [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
2020-11-23 17:08 ` [PATCH 2/2] ARM: mach-imx: imx6q: Set system_rev to show soc revision Robert Karszniewicz
2020-12-04 14:15 ` [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
@ 2021-01-05 1:31 ` Shawn Guo
2021-01-05 10:04 ` Robert Karszniewicz
2 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2021-01-05 1:31 UTC (permalink / raw)
To: Robert Karszniewicz
Cc: Peng Fan, Stefan Riedmueller, Anson Huang, Sascha Hauer,
Russell King, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
On Mon, Nov 23, 2020 at 06:08:10PM +0100, Robert Karszniewicz wrote:
> From: Stefan Riedmueller <s.riedmueller@phytec.de>
>
> Add the print of the CPU type and SOC revision during boot and also set
> the system_rev variable to the SOC revision so the correct SOC revision
> will be shown in /proc/cpuinfo.
>
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
Considering we already have /sys/devices/soc0 providing these
information, I do not this change is really necessary.
Shawn
> ---
> arch/arm/mach-imx/mach-imx6ul.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
> index e018e716735f..9c92cc72b857 100644
> --- a/arch/arm/mach-imx/mach-imx6ul.c
> +++ b/arch/arm/mach-imx/mach-imx6ul.c
> @@ -11,9 +11,11 @@
> #include <linux/regmap.h>
> #include <asm/mach/arch.h>
> #include <asm/mach/map.h>
> +#include <asm/system_info.h>
>
> #include "common.h"
> #include "cpuidle.h"
> +#include "hardware.h"
>
> static void __init imx6ul_enet_clk_init(void)
> {
> @@ -55,6 +57,10 @@ static inline void imx6ul_enet_init(void)
>
> static void __init imx6ul_init_machine(void)
> {
> + system_rev = imx_get_soc_revision();
> + imx_print_silicon_rev(cpu_is_imx6ull() ? "i.MX6ULL" : "i.MX6UL",
> + system_rev);
> +
> of_platform_default_populate(NULL, NULL, NULL);
> imx6ul_enet_init();
> imx_anatop_init();
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev
2021-01-05 1:31 ` Shawn Guo
@ 2021-01-05 10:04 ` Robert Karszniewicz
0 siblings, 0 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2021-01-05 10:04 UTC (permalink / raw)
To: Shawn Guo
Cc: Peng Fan, Stefan Riedmueller, Anson Huang, Sascha Hauer,
Russell King, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
On 1/5/21 2:31 AM, Shawn Guo wrote:
> On Mon, Nov 23, 2020 at 06:08:10PM +0100, Robert Karszniewicz wrote:
>> From: Stefan Riedmueller <s.riedmueller@phytec.de>
>>
>> Add the print of the CPU type and SOC revision during boot and also set
>> the system_rev variable to the SOC revision so the correct SOC revision
>> will be shown in /proc/cpuinfo.
>>
>> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
>> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
>
> Considering we already have /sys/devices/soc0 providing these
> information, I do not this change is really necessary.
Yes, I became aware of that, that's why I sent another patch which only
prints
the SOC revision:
[PATCH] ARM: mach-imx: imx6ul: Print SOC revision on boot
http://lists.infradead.org/pipermail/linux-arm-kernel/2020-December/624994.html
Thanks.
>
> Shawn
>
>> ---
>> arch/arm/mach-imx/mach-imx6ul.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
>> index e018e716735f..9c92cc72b857 100644
>> --- a/arch/arm/mach-imx/mach-imx6ul.c
>> +++ b/arch/arm/mach-imx/mach-imx6ul.c
>> @@ -11,9 +11,11 @@
>> #include <linux/regmap.h>
>> #include <asm/mach/arch.h>
>> #include <asm/mach/map.h>
>> +#include <asm/system_info.h>
>>
>> #include "common.h"
>> #include "cpuidle.h"
>> +#include "hardware.h"
>>
>> static void __init imx6ul_enet_clk_init(void)
>> {
>> @@ -55,6 +57,10 @@ static inline void imx6ul_enet_init(void)
>>
>> static void __init imx6ul_init_machine(void)
>> {
>> + system_rev = imx_get_soc_revision();
>> + imx_print_silicon_rev(cpu_is_imx6ull() ? "i.MX6ULL" : "i.MX6UL",
>> + system_rev);
>> +
>> of_platform_default_populate(NULL, NULL, NULL);
>> imx6ul_enet_init();
>> imx_anatop_init();
>> --
>> 2.7.4
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-05 10:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 17:08 [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
2020-11-23 17:08 ` [PATCH 2/2] ARM: mach-imx: imx6q: Set system_rev to show soc revision Robert Karszniewicz
2020-12-04 14:15 ` [PATCH 1/2] ARM: mach-imx: imx6ul: Print SOC revision on boot and set system_rev Robert Karszniewicz
2021-01-05 1:31 ` Shawn Guo
2021-01-05 10:04 ` Robert Karszniewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).