* [PATCH] drm/exynos/decon5433: Clean up GPIO includes
@ 2021-03-02 3:03 ` Tian Tao
2021-03-15 6:35 ` Inki Dae
0 siblings, 1 reply; 5+ messages in thread
From: Tian Tao @ 2021-03-02 3:03 UTC (permalink / raw)
To: airlied, daniel, krzk; +Cc: linux-samsung-soc, linux-arm-kernel, dri-devel
remove the legacy GPIO headers <linux/of_gpio.h> but what it really
uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
referenced.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 1f79bc2..9fc51a6 100644
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -11,9 +11,9 @@
#include <linux/component.h>
#include <linux/iopoll.h>
#include <linux/irq.h>
+#include <linux/gpio/consumer.h>
#include <linux/mfd/syscon.h>
#include <linux/of_device.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes
2021-03-02 3:03 ` [PATCH] drm/exynos/decon5433: Clean up GPIO includes Tian Tao
@ 2021-03-15 6:35 ` Inki Dae
2021-03-15 6:43 ` tiantao (H)
2021-03-15 6:45 ` tiantao (H)
0 siblings, 2 replies; 5+ messages in thread
From: Inki Dae @ 2021-03-15 6:35 UTC (permalink / raw)
To: Tian Tao, airlied, daniel, krzk
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc
Hi Tian Tao,
21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
> remove the legacy GPIO headers <linux/of_gpio.h> but what it really
> uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
> referenced.
This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion?
Thanks,
Inki Dae
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 1f79bc2..9fc51a6 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -11,9 +11,9 @@
> #include <linux/component.h>
> #include <linux/iopoll.h>
> #include <linux/irq.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/mfd/syscon.h>
> #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes
2021-03-15 6:35 ` Inki Dae
@ 2021-03-15 6:43 ` tiantao (H)
2021-03-15 6:45 ` tiantao (H)
1 sibling, 0 replies; 5+ messages in thread
From: tiantao (H) @ 2021-03-15 6:43 UTC (permalink / raw)
To: Inki Dae, Tian Tao, airlied, daniel, krzk
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc
在 2021/3/15 14:35, Inki Dae 写道:
> Hi Tian Tao,
>
> 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
>> remove the legacy GPIO headers <linux/of_gpio.h> but what it really
>> uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
>> referenced.
> This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion?
Thanks for helping to review patch, If you can give me review-by, I can
help push to drm-misc.
> Thanks,
> Inki Dae
>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>> ---
>> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>> index 1f79bc2..9fc51a6 100644
>> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>> @@ -11,9 +11,9 @@
>> #include <linux/component.h>
>> #include <linux/iopoll.h>
>> #include <linux/irq.h>
>> +#include <linux/gpio/consumer.h>
>> #include <linux/mfd/syscon.h>
>> #include <linux/of_device.h>
>> -#include <linux/of_gpio.h>
>> #include <linux/platform_device.h>
>> #include <linux/pm_runtime.h>
>> #include <linux/regmap.h>
>>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes
2021-03-15 6:35 ` Inki Dae
2021-03-15 6:43 ` tiantao (H)
@ 2021-03-15 6:45 ` tiantao (H)
2021-03-15 7:37 ` Inki Dae
1 sibling, 1 reply; 5+ messages in thread
From: tiantao (H) @ 2021-03-15 6:45 UTC (permalink / raw)
To: Inki Dae, Tian Tao, airlied, daniel, krzk
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc
在 2021/3/15 14:35, Inki Dae 写道:
> Hi Tian Tao,
>
> 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
>> remove the legacy GPIO headers <linux/of_gpio.h> but what it really
>> uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
>> referenced.
> This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion?
Thanks for helping to review patch,I've posted a new patch to fix this
problem If you can give me review-by, I can help push to drm-misc.
Subject: [PATCH] drm/exynos/decon5433: Remove the unused include statements
This driver doesn't reference of_gpio.h, so drop it.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 1f79bc2..1510e4e 100644
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -13,7 +13,6 @@
#include <linux/irq.h>
#include <linux/mfd/syscon.h>
#include <linux/of_device.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
>
> Thanks,
> Inki Dae
>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>> ---
>> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>> index 1f79bc2..9fc51a6 100644
>> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>> @@ -11,9 +11,9 @@
>> #include <linux/component.h>
>> #include <linux/iopoll.h>
>> #include <linux/irq.h>
>> +#include <linux/gpio/consumer.h>
>> #include <linux/mfd/syscon.h>
>> #include <linux/of_device.h>
>> -#include <linux/of_gpio.h>
>> #include <linux/platform_device.h>
>> #include <linux/pm_runtime.h>
>> #include <linux/regmap.h>
>>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes
2021-03-15 6:45 ` tiantao (H)
@ 2021-03-15 7:37 ` Inki Dae
0 siblings, 0 replies; 5+ messages in thread
From: Inki Dae @ 2021-03-15 7:37 UTC (permalink / raw)
To: Tian Tao, airlied, daniel, krzk
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc
21. 3. 15. 오후 3:45에 tiantao (H) 이(가) 쓴 글:
>
> 在 2021/3/15 14:35, Inki Dae 写道:
>> Hi Tian Tao,
>>
>> 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
>>> remove the legacy GPIO headers <linux/of_gpio.h> but what it really
>>> uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
>>> referenced.
>> This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion?
>
> Thanks for helping to review patch,I've posted a new patch to fix this problem If you can give me review-by, I can help push to drm-misc.
I can merge this patch and other one[1] to exynos drm tree after review, and will have a pull-request soon so no need to land to drm-misc tree.
Let's not bother Daniel. :)
[1] https://patchwork.kernel.org/project/dri-devel/patch/1615549385-33784-1-git-send-email-tiantao6@hisilicon.com/
Thanks,
Inki Dae
>
> Subject: [PATCH] drm/exynos/decon5433: Remove the unused include statements
>
> This driver doesn't reference of_gpio.h, so drop it.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 1f79bc2..1510e4e 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -13,7 +13,6 @@
> #include <linux/irq.h>
> #include <linux/mfd/syscon.h>
> #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
>
>>
>> Thanks,
>> Inki Dae
>>
>>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>>> ---
>>> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>>> index 1f79bc2..9fc51a6 100644
>>> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>>> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
>>> @@ -11,9 +11,9 @@
>>> #include <linux/component.h>
>>> #include <linux/iopoll.h>
>>> #include <linux/irq.h>
>>> +#include <linux/gpio/consumer.h>
>>> #include <linux/mfd/syscon.h>
>>> #include <linux/of_device.h>
>>> -#include <linux/of_gpio.h>
>>> #include <linux/platform_device.h>
>>> #include <linux/pm_runtime.h>
>>> #include <linux/regmap.h>
>>>
>> .
>>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-15 7:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210303014433epcas1p4fefd6787c74d86d6f11f93318c3833fd@epcas1p4.samsung.com>
2021-03-02 3:03 ` [PATCH] drm/exynos/decon5433: Clean up GPIO includes Tian Tao
2021-03-15 6:35 ` Inki Dae
2021-03-15 6:43 ` tiantao (H)
2021-03-15 6:45 ` tiantao (H)
2021-03-15 7:37 ` Inki Dae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).