* [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used
@ 2021-03-22 2:56 Liu Ying
2021-03-25 7:08 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Liu Ying @ 2021-03-22 2:56 UTC (permalink / raw)
To: linux-arm-kernel, dri-devel, linux-kernel
Cc: p.zabel, airlied, daniel, shawnguo, s.hauer, kernel, festevam, linux-imx
LDB channel1 should be registered if it is the only channel to be used.
Without this patch, imx_ldb_bind() would skip registering LDB channel1
if LDB channel0 is not used, no matter LDB channel1 needs to be used or
not.
Fixes: 8767f4711b2b (drm/imx: imx-ldb: move initialization into probe)
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
This patch fixes an issue introduced in v5.12-rc1.
It would be good to fix sooner than later.
drivers/gpu/drm/imx/imx-ldb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index dbfe39e..b794ed4 100644
--- a/drivers/gpu/drm/imx/imx-ldb.c
+++ b/drivers/gpu/drm/imx/imx-ldb.c
@@ -583,7 +583,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data)
struct imx_ldb_channel *channel = &imx_ldb->channel[i];
if (!channel->ldb)
- break;
+ continue;
ret = imx_ldb_register(drm, channel);
if (ret)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used
2021-03-22 2:56 [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used Liu Ying
@ 2021-03-25 7:08 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2021-03-25 7:08 UTC (permalink / raw)
To: Liu Ying
Cc: linux-arm-kernel, dri-devel, linux-kernel, airlied, daniel,
shawnguo, s.hauer, kernel, festevam, linux-imx
On Mon, Mar 22, 2021 at 10:56:40AM +0800, Liu Ying wrote:
> LDB channel1 should be registered if it is the only channel to be used.
> Without this patch, imx_ldb_bind() would skip registering LDB channel1
> if LDB channel0 is not used, no matter LDB channel1 needs to be used or
> not.
>
> Fixes: 8767f4711b2b (drm/imx: imx-ldb: move initialization into probe)
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Thank you, applied to imx-drm/fixes.
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 2:56 [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used Liu Ying
2021-03-25 7:08 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).