* [PATCH] firmware: arm_scmi: Remove repeated struct declaration
@ 2021-04-27 3:30 Wan Jiabing
2021-04-27 6:36 ` Cristian Marussi
2021-04-28 10:03 ` Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-04-27 3:30 UTC (permalink / raw)
To: Sudeep Holla, Cristian Marussi, linux-arm-kernel, linux-kernel
Cc: kael_w, Wan Jiabing
struct scmi_protocol_handle is declared at 34th line.
The declaration here is duplicate. Remove it.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/firmware/arm_scmi/notify.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/arm_scmi/notify.h b/drivers/firmware/arm_scmi/notify.h
index ce0324be6c71..4e9b627edfef 100644
--- a/drivers/firmware/arm_scmi/notify.h
+++ b/drivers/firmware/arm_scmi/notify.h
@@ -79,8 +79,6 @@ struct scmi_protocol_events {
int scmi_notification_init(struct scmi_handle *handle);
void scmi_notification_exit(struct scmi_handle *handle);
-
-struct scmi_protocol_handle;
int scmi_register_protocol_events(const struct scmi_handle *handle, u8 proto_id,
const struct scmi_protocol_handle *ph,
const struct scmi_protocol_events *ee);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Remove repeated struct declaration
2021-04-27 3:30 [PATCH] firmware: arm_scmi: Remove repeated struct declaration Wan Jiabing
@ 2021-04-27 6:36 ` Cristian Marussi
2021-04-28 10:03 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Cristian Marussi @ 2021-04-27 6:36 UTC (permalink / raw)
To: Wan Jiabing; +Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kael_w
Hi,
On Tue, Apr 27, 2021 at 11:30:31AM +0800, Wan Jiabing wrote:
> struct scmi_protocol_handle is declared at 34th line.
> The declaration here is duplicate. Remove it.
>
You're right.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/firmware/arm_scmi/notify.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/notify.h b/drivers/firmware/arm_scmi/notify.h
> index ce0324be6c71..4e9b627edfef 100644
> --- a/drivers/firmware/arm_scmi/notify.h
> +++ b/drivers/firmware/arm_scmi/notify.h
> @@ -79,8 +79,6 @@ struct scmi_protocol_events {
>
> int scmi_notification_init(struct scmi_handle *handle);
> void scmi_notification_exit(struct scmi_handle *handle);
> -
> -struct scmi_protocol_handle;
> int scmi_register_protocol_events(const struct scmi_handle *handle, u8 proto_id,
> const struct scmi_protocol_handle *ph,
> const struct scmi_protocol_events *ee);
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Remove repeated struct declaration
2021-04-27 3:30 [PATCH] firmware: arm_scmi: Remove repeated struct declaration Wan Jiabing
2021-04-27 6:36 ` Cristian Marussi
@ 2021-04-28 10:03 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2021-04-28 10:03 UTC (permalink / raw)
To: linux-kernel, Wan Jiabing, linux-arm-kernel, Cristian Marussi
Cc: Sudeep Holla, kael_w
On Tue, 27 Apr 2021 11:30:31 +0800, Wan Jiabing wrote:
> struct scmi_protocol_handle is declared at 34th line.
> The declaration here is duplicate. Remove it.
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[1/1] firmware: arm_scmi: Remove repeated struct declaration
https://git.kernel.org/sudeep.holla/c/03f840c492
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-28 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 3:30 [PATCH] firmware: arm_scmi: Remove repeated struct declaration Wan Jiabing
2021-04-27 6:36 ` Cristian Marussi
2021-04-28 10:03 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).