* [PATCH 1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup()
@ 2021-05-11 12:24 Zhen Lei
2021-05-14 12:50 ` Krzysztof Wilczyński
2021-06-03 16:46 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Zhen Lei @ 2021-05-11 12:24 UTC (permalink / raw)
To: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
Bjorn Helgaas, Matthias Brugger, linux-pci, linux-mediatek,
linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/pci/controller/pcie-mediatek.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
index 62a042e75d9a2f4..25bee693834f95e 100644
--- a/drivers/pci/controller/pcie-mediatek.c
+++ b/drivers/pci/controller/pcie-mediatek.c
@@ -991,10 +991,8 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie)
regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");
if (regs) {
pcie->base = devm_ioremap_resource(dev, regs);
- if (IS_ERR(pcie->base)) {
- dev_err(dev, "failed to map shared register\n");
+ if (IS_ERR(pcie->base))
return PTR_ERR(pcie->base);
- }
}
pcie->free_ck = devm_clk_get(dev, "free_ck");
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup()
2021-05-11 12:24 [PATCH 1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup() Zhen Lei
@ 2021-05-14 12:50 ` Krzysztof Wilczyński
2021-06-03 16:46 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Wilczyński @ 2021-05-14 12:50 UTC (permalink / raw)
To: Zhen Lei
Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
Bjorn Helgaas, Matthias Brugger, linux-pci, linux-mediatek,
linux-arm-kernel
Hi Zhen,
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
[...]
Thank you!
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup()
2021-05-11 12:24 [PATCH 1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup() Zhen Lei
2021-05-14 12:50 ` Krzysztof Wilczyński
@ 2021-06-03 16:46 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2021-06-03 16:46 UTC (permalink / raw)
To: linux-mediatek, Bjorn Helgaas, linux-arm-kernel, Zhen Lei,
Ryder Lee, Rob Herring, Matthias Brugger, linux-pci,
Jianjun Wang
Cc: Lorenzo Pieralisi
On Tue, 11 May 2021 20:24:53 +0800, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
Applied to pci/mediatek, thanks!
[1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup()
https://git.kernel.org/lpieralisi/pci/c/28bba1e220
Thanks,
Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-03 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 12:24 [PATCH 1/1] PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup() Zhen Lei
2021-05-14 12:50 ` Krzysztof Wilczyński
2021-06-03 16:46 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).