From: zhiyong tao <zhiyong.tao@mediatek.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>, <srv_heupstream@mediatek.com>,
<hui.liu@mediatek.com>, zhiyong.tao <zhiyong.tao@mediatek.com>,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v7] pinctrl: mediatek: add rsel setting on MT8195
Date: Thu, 22 Jul 2021 16:22:45 +0800 [thread overview]
Message-ID: <1626942165.29611.17.camel@mhfsdcap03> (raw)
In-Reply-To: <CACRpkdaLhR9HgYNPZ_SQ-wi7RfpeT7iapXUfqf=bAwo05MBZqA@mail.gmail.com>
On Wed, 2021-05-19 at 02:09 +0200, Linus Walleij wrote:
> On Mon, Apr 26, 2021 at 4:45 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> > This patch provides rsel setting on MT8195.
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
>
> I am suspicious about this patch, sorry for taking so long to answer.
>
> First explain what "rsel" means, because with no explanation I
> suspect it means "rail select" which is what we already have the
> existing generic property PIN_CONFIG_POWER_SOURCE
> and power-source = <> in DT for.
>
> Also add the custom properties to:
> Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> (separate patch)
> Yours,
> Linus Walleij
==>
Hi Linus walleij,
Thanks for your suggestion.
rsel: resistance selection, we can set rsel from 0 to 7 to set different
resistance. such as:
MTK_PULL_SET_RSEL_000:75K in PU, 75k in PD;
MTK_PULL_SET_RSEL_001:10k in PU, 5k in PD;
MTK_PULL_SET_RSEL_010:5k in PU, 75k in PD;
MTK_PULL_SET_RSEL_011:4k in PU, 5K in PD;
MTK_PULL_SET_RSEL_100:3k in PU, 75k in PD;
MTK_PULL_SET_RSEL_101:2k in PU, 5K in PD;
MTK_PULL_SET_RSEL_110:1.5k in PU, 75k in PD;
MTK_PULL_SET_RSEL_111:1k in PU, 5k in PD.
It seems can flow bias-pull-up/down property. we change it in v10.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-22 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 2:45 [PATCH v7 0/1] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-04-26 2:45 ` [PATCH v7] pinctrl: mediatek: add rsel setting on MT8195 Zhiyong Tao
2021-05-19 0:09 ` Linus Walleij
2021-07-22 8:22 ` zhiyong tao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1626942165.29611.17.camel@mhfsdcap03 \
--to=zhiyong.tao@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hongzhou.yang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).