* [PATCH] spi-at91-usart: replacing legacy gpio interface for gpiod
@ 2021-10-19 18:05 Maíra Canal
2021-10-20 10:40 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Maíra Canal @ 2021-10-19 18:05 UTC (permalink / raw)
To: broonie, radu_nicolae.pirea
Cc: alexandre.belloni, linux-kernel, ludovic.desroches, linux-spi,
linux-arm-kernel
Removing dependency of linux/of_gpio.h and replacing it for
linux/gpio/consumer.h
Signed-off-by: Maíra Canal <maira.canal@usp.br>
---
drivers/spi/spi-at91-usart.c | 27 +++++----------------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
index 8c8352625d23..9cd738682aab 100644
--- a/drivers/spi/spi-at91-usart.c
+++ b/drivers/spi/spi-at91-usart.c
@@ -14,7 +14,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of_platform.h>
-#include <linux/of_gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
@@ -482,29 +482,12 @@ static void at91_usart_spi_init(struct at91_usart_spi *aus)
static int at91_usart_gpio_setup(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.parent->of_node;
- int i;
- int ret;
- int nb;
-
- if (!np)
- return -EINVAL;
-
- nb = of_gpio_named_count(np, "cs-gpios");
- for (i = 0; i < nb; i++) {
- int cs_gpio = of_get_named_gpio(np, "cs-gpios", i);
+ struct gpio_descs *cs_gpios;
- if (cs_gpio < 0)
- return cs_gpio;
+ cs_gpios = devm_gpiod_get_array_optional(&pdev->dev, "cs", GPIOD_OUT_LOW);
- if (gpio_is_valid(cs_gpio)) {
- ret = devm_gpio_request_one(&pdev->dev, cs_gpio,
- GPIOF_DIR_OUT,
- dev_name(&pdev->dev));
- if (ret)
- return ret;
- }
- }
+ if (IS_ERR(cs_gpios))
+ return PTR_ERR(cs_gpios);
return 0;
}
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi-at91-usart: replacing legacy gpio interface for gpiod
2021-10-19 18:05 [PATCH] spi-at91-usart: replacing legacy gpio interface for gpiod Maíra Canal
@ 2021-10-20 10:40 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-10-20 10:40 UTC (permalink / raw)
To: Maíra Canal, radu_nicolae.pirea
Cc: alexandre.belloni, linux-kernel, ludovic.desroches, Mark Brown,
linux-spi, linux-arm-kernel
On Tue, 19 Oct 2021 15:05:24 -0300, Maíra Canal wrote:
> Removing dependency of linux/of_gpio.h and replacing it for
> linux/gpio/consumer.h
>
>
Applied, thanks!
[1/1] spi-at91-usart: replacing legacy gpio interface for gpiod
commit: 3340ec49ba2c294a163d05319054c8506a8f30d9
Best regards,
--
Mark Brown,,, <broonie@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 18:05 [PATCH] spi-at91-usart: replacing legacy gpio interface for gpiod Maíra Canal
2021-10-20 10:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).