linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: rockchip: Use memcpy_toio instead of memcpy on smp bring-up
@ 2021-11-16  8:46 Ivan T. Ivanov
  2021-11-21 18:52 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Ivan T. Ivanov @ 2021-11-16  8:46 UTC (permalink / raw)
  To: Heiko Stuebner; +Cc: Russell King, linux-arm-kernel, linux-rockchip

This fixes a potential kernel panic on memcpy when FORTIFY_SOURCE
is enabled. Because memory is iomem use appropriate function for
accessing it.

Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 arch/arm/mach-rockchip/platsmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index d60856898d97..5ec58d004b7d 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -189,7 +189,7 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node)
 	rockchip_boot_fn = __pa_symbol(secondary_startup);
 
 	/* copy the trampoline to sram, that runs during startup of the core */
-	memcpy(sram_base_addr, &rockchip_secondary_trampoline, trampoline_sz);
+	memcpy_toio(sram_base_addr, &rockchip_secondary_trampoline, trampoline_sz);
 	flush_cache_all();
 	outer_clean_range(0, trampoline_sz);
 
-- 
2.33.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: rockchip: Use memcpy_toio instead of memcpy on smp bring-up
  2021-11-16  8:46 [PATCH] ARM: rockchip: Use memcpy_toio instead of memcpy on smp bring-up Ivan T. Ivanov
@ 2021-11-21 18:52 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2021-11-21 18:52 UTC (permalink / raw)
  To: Ivan T. Ivanov
  Cc: Heiko Stuebner, Russell King, linux-rockchip, linux-arm-kernel

On Tue, 16 Nov 2021 10:46:16 +0200, Ivan T. Ivanov wrote:
> This fixes a potential kernel panic on memcpy when FORTIFY_SOURCE
> is enabled. Because memory is iomem use appropriate function for
> accessing it.

Applied, thanks!

[1/1] ARM: rockchip: Use memcpy_toio instead of memcpy on smp bring-up
      commit: 423e85e97aaf69e5198bbec6811e3825c8b5019a

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-21 18:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16  8:46 [PATCH] ARM: rockchip: Use memcpy_toio instead of memcpy on smp bring-up Ivan T. Ivanov
2021-11-21 18:52 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).