linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: k3-j721e: correct cache-sets info
@ 2021-11-12  6:31 Peng Fan (OSS)
  2021-11-13  2:26 ` Nishanth Menon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2021-11-12  6:31 UTC (permalink / raw)
  To: robh+dt, nm, vigneshr, kristo, s-anna
  Cc: linux-arm-kernel, devicetree, linux-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

A72 Cluster has 48KB Icache, 32KB Dcache and 1MB L2 Cache
 - ICache is 3-way set-associative
 - Dcache is 2-way set-associative
 - Line size are 64bytes

So correct the cache-sets info.

Fixes: 2d87061e70dea ("arm64: dts: ti: Add Support for J721E SoC")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e.dtsi b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
index 214359e7288b..a5967ba139d7 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
@@ -64,7 +64,7 @@ cpu0: cpu@0 {
 			i-cache-sets = <256>;
 			d-cache-size = <0x8000>;
 			d-cache-line-size = <64>;
-			d-cache-sets = <128>;
+			d-cache-sets = <256>;
 			next-level-cache = <&L2_0>;
 		};
 
@@ -78,7 +78,7 @@ cpu1: cpu@1 {
 			i-cache-sets = <256>;
 			d-cache-size = <0x8000>;
 			d-cache-line-size = <64>;
-			d-cache-sets = <128>;
+			d-cache-sets = <256>;
 			next-level-cache = <&L2_0>;
 		};
 	};
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: k3-j721e: correct cache-sets info
  2021-11-12  6:31 [PATCH] arm64: dts: k3-j721e: correct cache-sets info Peng Fan (OSS)
@ 2021-11-13  2:26 ` Nishanth Menon
  2021-11-13  4:56 ` Nishanth Menon
  2021-12-06 13:29 ` Vignesh Raghavendra
  2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2021-11-13  2:26 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: devicetree, Peng Fan, vigneshr, kristo, linux-kernel, robh+dt,
	linux-arm-kernel

On 14:31-20211112, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> A72 Cluster has 48KB Icache, 32KB Dcache and 1MB L2 Cache
>  - ICache is 3-way set-associative
>  - Dcache is 2-way set-associative
>  - Line size are 64bytes
> 
> So correct the cache-sets info.
> 
> Fixes: 2d87061e70dea ("arm64: dts: ti: Add Support for J721E SoC")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e.dtsi b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
> index 214359e7288b..a5967ba139d7 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
> @@ -64,7 +64,7 @@ cpu0: cpu@0 {
>  			i-cache-sets = <256>;
>  			d-cache-size = <0x8000>;
>  			d-cache-line-size = <64>;
> -			d-cache-sets = <128>;
> +			d-cache-sets = <256>;
>  			next-level-cache = <&L2_0>;
>  		};
>  
> @@ -78,7 +78,7 @@ cpu1: cpu@1 {
>  			i-cache-sets = <256>;
>  			d-cache-size = <0x8000>;
>  			d-cache-line-size = <64>;
> -			d-cache-sets = <128>;
> +			d-cache-sets = <256>;
>  			next-level-cache = <&L2_0>;
>  		};
>  	};
> -- 
> 2.25.1
> 
Arrgh.. Thank you for fixing this.

Reviewed-by: Nishanth Menon <nm@ti.com>

I think J7200 also needs fixups. Will cross check and post additional
patches depending on the ones that need it.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: k3-j721e: correct cache-sets info
  2021-11-12  6:31 [PATCH] arm64: dts: k3-j721e: correct cache-sets info Peng Fan (OSS)
  2021-11-13  2:26 ` Nishanth Menon
@ 2021-11-13  4:56 ` Nishanth Menon
  2021-12-06 13:29 ` Vignesh Raghavendra
  2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2021-11-13  4:56 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: devicetree, Peng Fan, vigneshr, kristo, linux-kernel, robh+dt,
	linux-arm-kernel

On 14:31-20211112, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>

Minor comment (should be easy to fix when picking up the patch), lest I
forget-> $subject: arm64: dts: ti: to maintain consistency

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: k3-j721e: correct cache-sets info
  2021-11-12  6:31 [PATCH] arm64: dts: k3-j721e: correct cache-sets info Peng Fan (OSS)
  2021-11-13  2:26 ` Nishanth Menon
  2021-11-13  4:56 ` Nishanth Menon
@ 2021-12-06 13:29 ` Vignesh Raghavendra
  2 siblings, 0 replies; 4+ messages in thread
From: Vignesh Raghavendra @ 2021-12-06 13:29 UTC (permalink / raw)
  To: robh+dt, s-anna, Peng Fan (OSS), kristo, nm
  Cc: Vignesh Raghavendra, linux-arm-kernel, devicetree, Peng Fan,
	linux-kernel

Hi Peng Fan (OSS),
 
On Fri, 12 Nov 2021 14:31:55 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> A72 Cluster has 48KB Icache, 32KB Dcache and 1MB L2 Cache
>  - ICache is 3-way set-associative
>  - Dcache is 2-way set-associative
>  - Line size are 64bytes
> 
> [...]
 
I have applied the following to branch ti-k3-dts-next on [1].

Fixed $subject as suggested by Nishanth.

Thank you!
 
[1/1] arm64: dts: k3-j721e: correct cache-sets info
      commit: 7a0df1f969c14939f60a7f9a6af72adcc314675f
 
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
 
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
 
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
 
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
 
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-06 13:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12  6:31 [PATCH] arm64: dts: k3-j721e: correct cache-sets info Peng Fan (OSS)
2021-11-13  2:26 ` Nishanth Menon
2021-11-13  4:56 ` Nishanth Menon
2021-12-06 13:29 ` Vignesh Raghavendra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).