* [PATCH] arm64/kvm: Fix bitrotted comment for SVE handling in handle_exit.c
@ 2021-10-25 16:32 Mark Brown
2021-12-06 17:28 ` Catalin Marinas
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2021-10-25 16:32 UTC (permalink / raw)
To: Marc Zyngier
Cc: James Morse, Alexandru Elisei, Suzuki K Poulose, Catalin Marinas,
Will Deacon, linux-arm-kernel, kvmarm, Mark Brown
The comment on the SVE trap handler in handle_exit.c says that it is a
placeholder until we support SVE in guests which we now do for both VHE
and nVHE cases so we really shouldn't get here in any sort of standard
case. Update the comment to be less immediately incorrect, the handling
of such a situation is correct.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm64/kvm/handle_exit.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
index 275a27368a04..5abe0617f2af 100644
--- a/arch/arm64/kvm/handle_exit.c
+++ b/arch/arm64/kvm/handle_exit.c
@@ -140,9 +140,12 @@ static int kvm_handle_unknown_ec(struct kvm_vcpu *vcpu)
return 1;
}
+/*
+ * Guest access to SVE registers should be routed to this handler only
+ * when the system doesn't support SVE.
+ */
static int handle_sve(struct kvm_vcpu *vcpu)
{
- /* Until SVE is supported for guests: */
kvm_inject_undefined(vcpu);
return 1;
}
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64/kvm: Fix bitrotted comment for SVE handling in handle_exit.c
2021-10-25 16:32 [PATCH] arm64/kvm: Fix bitrotted comment for SVE handling in handle_exit.c Mark Brown
@ 2021-12-06 17:28 ` Catalin Marinas
0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2021-12-06 17:28 UTC (permalink / raw)
To: Mark Brown, Marc Zyngier; +Cc: Will Deacon, linux-arm-kernel, kvmarm
On Mon, 25 Oct 2021 17:32:32 +0100, Mark Brown wrote:
> The comment on the SVE trap handler in handle_exit.c says that it is a
> placeholder until we support SVE in guests which we now do for both VHE
> and nVHE cases so we really shouldn't get here in any sort of standard
> case. Update the comment to be less immediately incorrect, the handling
> of such a situation is correct.
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64/kvm: Fix bitrotted comment for SVE handling in handle_exit.c
https://git.kernel.org/arm64/c/d658220a1c45
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-06 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 16:32 [PATCH] arm64/kvm: Fix bitrotted comment for SVE handling in handle_exit.c Mark Brown
2021-12-06 17:28 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).