* [PATCH v3,0/6] Convert pwm-mtk-disp.txt to
@ 2022-03-02 5:31 xinlei.lee
2022-03-02 5:31 ` [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format xinlei.lee
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Changes since v2:
1. Modify the PWM name to DISP_PWM.
2. Include pwm.yaml.
3. Separate conversion files and add/remove operations.
Changes since v1:
1. Fixed formatting issues mentioned in the v1.
2. Delete pwm-mtk-disp.txt.
3. Add mtk_pwm dt_maintainers.
4. Add "#pwm-cells" & power-domains properties.
5. Make dt_checking successful.
Xinlei Lee (6):
dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml
format
dt-bindings: pwm: Remove compatible for MediaTek MT8167
dt-bindings: pwm: Add compatible for MediaTek MT8183
dt-bindings: pwm: Add compatible for MediaTek MT8192
dt-bindings: pwm: Add compatible for MediaTek MT8195
dt-bindings: pwm: Add compatible for MediaTek MT8186
.../bindings/pwm/mediatek,pwm-disp.yaml | 72 +++++++++++++++++++
.../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
2 files changed, 72 insertions(+), 44 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
@ 2022-03-02 5:31 ` xinlei.lee
2022-03-02 17:57 ` Rob Herring
2022-03-02 5:31 ` [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167 xinlei.lee
` (4 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
.../bindings/pwm/mediatek,pwm-disp.yaml | 65 +++++++++++++++++++
.../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 -------------
2 files changed, 65 insertions(+), 44 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
new file mode 100644
index 000000000000..f844695d605a
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek DISP_PWM Controller Device Tree Bindings
+
+maintainers:
+ - Jitao Shi <jitao.shi@mediatek.com>
+ - Xinlei Lee <xinlei.lee@mediatek.com>
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - mediatek,mt2701-disp-pwm
+ - mediatek,mt6595-disp-pwm
+ - mediatek,mt8173-disp-pwm
+ - items:
+ - const: mediatek,mt8167-disp-pwm
+ - const: mediatek,mt8173-disp-pwm
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 2
+
+ clocks:
+ items:
+ - description: Main Clock
+ - description: Mm Clock
+
+ clock-names:
+ items:
+ - const: main
+ - const: mm
+
+required:
+ - compatible
+ - reg
+ - "#pwm-cells"
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/mt8173-clk.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ pwm0: pwm@1401e000 {
+ compatible = "mediatek,mt8173-disp-pwm";
+ reg = <0x1401e000 0x1000>;
+ #pwm-cells = <2>;
+ clocks = <&mmsys CLK_MM_DISP_PWM026M>,
+ <&mmsys CLK_MM_DISP_PWM0MM>;
+ clock-names = "main", "mm";
+ };
diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
deleted file mode 100644
index 902b271891ae..000000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-MediaTek display PWM controller
-
-Required properties:
- - compatible: should be "mediatek,<name>-disp-pwm":
- - "mediatek,mt2701-disp-pwm": found on mt2701 SoC.
- - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.
- - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found on mt8167 SoC.
- - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
- - reg: physical base address and length of the controller's registers.
- - #pwm-cells: must be 2. See pwm.yaml in this directory for a description of
- the cell format.
- - clocks: phandle and clock specifier of the PWM reference clock.
- - clock-names: must contain the following:
- - "main": clock used to generate PWM signals.
- - "mm": sync signals from the modules of mmsys.
- - pinctrl-names: Must contain a "default" entry.
- - pinctrl-0: One property must exist for each entry in pinctrl-names.
- See pinctrl/pinctrl-bindings.txt for details of the property values.
-
-Example:
- pwm0: pwm@1401e000 {
- compatible = "mediatek,mt8173-disp-pwm",
- "mediatek,mt6595-disp-pwm";
- reg = <0 0x1401e000 0 0x1000>;
- #pwm-cells = <2>;
- clocks = <&mmsys CLK_MM_DISP_PWM026M>,
- <&mmsys CLK_MM_DISP_PWM0MM>;
- clock-names = "main", "mm";
- pinctrl-names = "default";
- pinctrl-0 = <&disp_pwm0_pins>;
- };
-
- backlight_lcd: backlight_lcd {
- compatible = "pwm-backlight";
- pwms = <&pwm0 0 1000000>;
- brightness-levels = <
- 0 16 32 48 64 80 96 112
- 128 144 160 176 192 208 224 240
- 255
- >;
- default-brightness-level = <9>;
- power-supply = <&mt6397_vio18_reg>;
- enable-gpios = <&pio 95 GPIO_ACTIVE_HIGH>;
- };
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
2022-03-02 5:31 ` [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format xinlei.lee
@ 2022-03-02 5:31 ` xinlei.lee
2022-03-02 17:56 ` Rob Herring
2022-03-02 5:31 ` [PATCH v3,3/6] dt-bindings: pwm: Add compatible for MediaTek MT8183 xinlei.lee
` (3 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Remove dt-binding documentation of pwm for MediaTek MT8167 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index f844695d605a..f18e8bbd13d2 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -20,9 +20,6 @@ properties:
- mediatek,mt2701-disp-pwm
- mediatek,mt6595-disp-pwm
- mediatek,mt8173-disp-pwm
- - items:
- - const: mediatek,mt8167-disp-pwm
- - const: mediatek,mt8173-disp-pwm
reg:
maxItems: 1
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3,3/6] dt-bindings: pwm: Add compatible for MediaTek MT8183
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
2022-03-02 5:31 ` [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format xinlei.lee
2022-03-02 5:31 ` [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167 xinlei.lee
@ 2022-03-02 5:31 ` xinlei.lee
2022-03-02 17:56 ` Rob Herring
2022-03-02 5:31 ` [PATCH v3,4/6] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
` (2 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of pwm for MediaTek MT8183 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index f18e8bbd13d2..3a1ba329b7b3 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -20,6 +20,7 @@ properties:
- mediatek,mt2701-disp-pwm
- mediatek,mt6595-disp-pwm
- mediatek,mt8173-disp-pwm
+ - mediatek,mt8183-disp-pwm
reg:
maxItems: 1
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3,4/6] dt-bindings: pwm: Add compatible for MediaTek MT8192
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
` (2 preceding siblings ...)
2022-03-02 5:31 ` [PATCH v3,3/6] dt-bindings: pwm: Add compatible for MediaTek MT8183 xinlei.lee
@ 2022-03-02 5:31 ` xinlei.lee
2022-03-02 5:31 ` [PATCH v3,5/6] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
2022-03-02 5:31 ` [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
5 siblings, 0 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of pwm for MediaTek MT8192 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 3a1ba329b7b3..fa1c0b96bb29 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -21,7 +21,9 @@ properties:
- mediatek,mt6595-disp-pwm
- mediatek,mt8173-disp-pwm
- mediatek,mt8183-disp-pwm
-
+ - items:
+ - const: mediatek,mt8192-disp-pwm
+ - const: mediatek,mt8183-disp-pwm
reg:
maxItems: 1
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3,5/6] dt-bindings: pwm: Add compatible for MediaTek MT8195
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
` (3 preceding siblings ...)
2022-03-02 5:31 ` [PATCH v3,4/6] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
@ 2022-03-02 5:31 ` xinlei.lee
2022-03-02 5:31 ` [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
5 siblings, 0 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of pwm for MediaTek MT8195 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index fa1c0b96bb29..3a5d1cfed94d 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -24,6 +24,10 @@ properties:
- items:
- const: mediatek,mt8192-disp-pwm
- const: mediatek,mt8183-disp-pwm
+ - items:
+ - const: mediatek,mt8195-disp-pwm
+ - const: mediatek,mt8183-disp-pwm
+
reg:
maxItems: 1
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
` (4 preceding siblings ...)
2022-03-02 5:31 ` [PATCH v3,5/6] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
@ 2022-03-02 5:31 ` xinlei.lee
2022-03-02 14:14 ` AngeloGioacchino Del Regno
2022-03-02 17:55 ` Rob Herring
5 siblings, 2 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-02 5:31 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 3a5d1cfed94d..053805846cfe 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -21,6 +21,9 @@ properties:
- mediatek,mt6595-disp-pwm
- mediatek,mt8173-disp-pwm
- mediatek,mt8183-disp-pwm
+ - items:
+ - const: mediatek,mt8186-disp-pwm
+ - const: mediatek,mt8183-disp-pwm
- items:
- const: mediatek,mt8192-disp-pwm
- const: mediatek,mt8183-disp-pwm
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-03-02 5:31 ` [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
@ 2022-03-02 14:14 ` AngeloGioacchino Del Regno
2022-03-03 2:13 ` xinlei.lee
2022-03-02 17:55 ` Rob Herring
1 sibling, 1 reply; 15+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-03-02 14:14 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
Il 02/03/22 06:31, xinlei.lee@mediatek.com ha scritto:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> index 3a5d1cfed94d..053805846cfe 100644
> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -21,6 +21,9 @@ properties:
> - mediatek,mt6595-disp-pwm
> - mediatek,mt8173-disp-pwm
> - mediatek,mt8183-disp-pwm
> + - items:
> + - const: mediatek,mt8186-disp-pwm
> + - const: mediatek,mt8183-disp-pwm
> - items:
> - const: mediatek,mt8192-disp-pwm
> - const: mediatek,mt8183-disp-pwm
>
Hello Xinlei,
even though repeating these items may not give you errors, this is not really
the best way to do this.
I've done something similar here:
https://lore.kernel.org/linux-arm-kernel/20220217095242.13761-1-angelogioacchino.delregno@collabora.com/
So, for the compatibles needing mediatek,mt8183-disp-pwm it should be looking
similar to this:
- items:
- enum:
- mediatek,mt8186-disp-pwm
- mediatek,mt8192-disp-pwm
- mediatek,mt8195-disp-pwm
- const: mediatek,mt8183-disp-pwm
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-03-02 5:31 ` [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
2022-03-02 14:14 ` AngeloGioacchino Del Regno
@ 2022-03-02 17:55 ` Rob Herring
2022-03-03 2:05 ` xinlei.lee
1 sibling, 1 reply; 15+ messages in thread
From: Rob Herring @ 2022-03-02 17:55 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, Mar 02, 2022 at 01:31:46PM +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> index 3a5d1cfed94d..053805846cfe 100644
> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -21,6 +21,9 @@ properties:
> - mediatek,mt6595-disp-pwm
> - mediatek,mt8173-disp-pwm
> - mediatek,mt8183-disp-pwm
> + - items:
> + - const: mediatek,mt8186-disp-pwm
> + - const: mediatek,mt8183-disp-pwm
Combine to 1 entry:
> - items:
> - const: mediatek,mt8192-disp-pwm
enum:
- mediatek,mt8186-disp-pwm
- mediatek,mt8192-disp-pwm
> - const: mediatek,mt8183-disp-pwm
> --
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3,3/6] dt-bindings: pwm: Add compatible for MediaTek MT8183
2022-03-02 5:31 ` [PATCH v3,3/6] dt-bindings: pwm: Add compatible for MediaTek MT8183 xinlei.lee
@ 2022-03-02 17:56 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2022-03-02 17:56 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, Mar 02, 2022 at 01:31:43PM +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8183 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167
2022-03-02 5:31 ` [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167 xinlei.lee
@ 2022-03-02 17:56 ` Rob Herring
2022-03-03 1:59 ` xinlei.lee
0 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2022-03-02 17:56 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, Mar 02, 2022 at 01:31:42PM +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Remove dt-binding documentation of pwm for MediaTek MT8167 SoC.
Why?
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> index f844695d605a..f18e8bbd13d2 100644
> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -20,9 +20,6 @@ properties:
> - mediatek,mt2701-disp-pwm
> - mediatek,mt6595-disp-pwm
> - mediatek,mt8173-disp-pwm
> - - items:
> - - const: mediatek,mt8167-disp-pwm
> - - const: mediatek,mt8173-disp-pwm
>
> reg:
> maxItems: 1
> --
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format
2022-03-02 5:31 ` [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format xinlei.lee
@ 2022-03-02 17:57 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2022-03-02 17:57 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, Mar 02, 2022 at 01:31:41PM +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../bindings/pwm/mediatek,pwm-disp.yaml | 65 +++++++++++++++++++
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 -------------
> 2 files changed, 65 insertions(+), 44 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167
2022-03-02 17:56 ` Rob Herring
@ 2022-03-03 1:59 ` xinlei.lee
0 siblings, 0 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-03 1:59 UTC (permalink / raw)
To: Rob Herring
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, 2022-03-02 at 11:56 -0600, Rob Herring wrote:
> On Wed, Mar 02, 2022 at 01:31:42PM +0800, xinlei.lee@mediatek.com
> wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Remove dt-binding documentation of pwm for MediaTek MT8167 SoC.
>
> Why?
>
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3
> > ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml
> > index f844695d605a..f18e8bbd13d2 100644
> > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > @@ -20,9 +20,6 @@ properties:
> > - mediatek,mt2701-disp-pwm
> > - mediatek,mt6595-disp-pwm
> > - mediatek,mt8173-disp-pwm
> > - - items:
> > - - const: mediatek,mt8167-disp-pwm
> > - - const: mediatek,mt8173-disp-pwm
> >
> > reg:
> > maxItems: 1
> > --
> > 2.18.0
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Rob:
Thanks for your review. Because I did not find the compatiable
corresponding to mt8167 in the latest version of the pwm-mtk-disp.c
driver file.
My understanding is that it may be disabled but not updated to the
dt_binding file. If I have misunderstood, please let me know if this
modification is still required.
Looking forward to your feedback.
Best Regards!
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-03-02 17:55 ` Rob Herring
@ 2022-03-03 2:05 ` xinlei.lee
0 siblings, 0 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-03 2:05 UTC (permalink / raw)
To: Rob Herring
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, 2022-03-02 at 11:55 -0600, Rob Herring wrote:
> On Wed, Mar 02, 2022 at 01:31:46PM +0800, xinlei.lee@mediatek.com
> wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3
> > +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml
> > index 3a5d1cfed94d..053805846cfe 100644
> > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > @@ -21,6 +21,9 @@ properties:
> > - mediatek,mt6595-disp-pwm
> > - mediatek,mt8173-disp-pwm
> > - mediatek,mt8183-disp-pwm
> > + - items:
> > + - const: mediatek,mt8186-disp-pwm
> > + - const: mediatek,mt8183-disp-pwm
>
> Combine to 1 entry:
>
> > - items:
> > - const: mediatek,mt8192-disp-pwm
>
> enum:
> - mediatek,mt8186-disp-pwm
> - mediatek,mt8192-disp-pwm
>
> > - const: mediatek,mt8183-disp-pwm
> > --
> > 2.18.0
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Rob:
Thanks for your review!
I will combine the reuse of the same driver into one entry in the next
version.
Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-03-02 14:14 ` AngeloGioacchino Del Regno
@ 2022-03-03 2:13 ` xinlei.lee
0 siblings, 0 replies; 15+ messages in thread
From: xinlei.lee @ 2022-03-03 2:13 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, thierry.reding, u.kleine-koenig,
lee.jones, robh+dt, matthias.bgg
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, jitao.shi,
allen-kh.cheng, rex-bc.chen
On Wed, 2022-03-02 at 15:14 +0100, AngeloGioacchino Del Regno wrote:
> Il 02/03/22 06:31, xinlei.lee@mediatek.com ha scritto:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3
> > +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-
> > disp.yaml
> > index 3a5d1cfed94d..053805846cfe 100644
> > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> > @@ -21,6 +21,9 @@ properties:
> > - mediatek,mt6595-disp-pwm
> > - mediatek,mt8173-disp-pwm
> > - mediatek,mt8183-disp-pwm
> > + - items:
> > + - const: mediatek,mt8186-disp-pwm
> > + - const: mediatek,mt8183-disp-pwm
> > - items:
> > - const: mediatek,mt8192-disp-pwm
> > - const: mediatek,mt8183-disp-pwm
> >
>
>
> Hello Xinlei,
>
> even though repeating these items may not give you errors, this is
> not really
> the best way to do this.
> I've done something similar here:
>
https://lore.kernel.org/linux-arm-kernel/20220217095242.13761-1-angelogioacchino.delregno@collabora.com/
>
> So, for the compatibles needing mediatek,mt8183-disp-pwm it should be
> looking
> similar to this:
>
> - items:
> - enum:
> - mediatek,mt8186-disp-pwm
> - mediatek,mt8192-disp-pwm
> - mediatek,mt8195-disp-pwm
> - const: mediatek,mt8183-disp-pwm
>
> Regards,
> Angelo
Hi Angelo:
Thanks for your review, it's a great suggestion.
I will revise it as you suggested in the next commit.
Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-03-03 2:14 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 5:31 [PATCH v3,0/6] Convert pwm-mtk-disp.txt to xinlei.lee
2022-03-02 5:31 ` [PATCH v3, 1/6] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format xinlei.lee
2022-03-02 17:57 ` Rob Herring
2022-03-02 5:31 ` [PATCH v3, 2/6] dt-bindings: pwm: Remove compatible for MediaTek MT8167 xinlei.lee
2022-03-02 17:56 ` Rob Herring
2022-03-03 1:59 ` xinlei.lee
2022-03-02 5:31 ` [PATCH v3,3/6] dt-bindings: pwm: Add compatible for MediaTek MT8183 xinlei.lee
2022-03-02 17:56 ` Rob Herring
2022-03-02 5:31 ` [PATCH v3,4/6] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
2022-03-02 5:31 ` [PATCH v3,5/6] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
2022-03-02 5:31 ` [PATCH v3,6/6] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
2022-03-02 14:14 ` AngeloGioacchino Del Regno
2022-03-03 2:13 ` xinlei.lee
2022-03-02 17:55 ` Rob Herring
2022-03-03 2:05 ` xinlei.lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).