* [PATCH v2] dt-bindings: mfd: mt6370: fix the indentation in the example
@ 2022-09-14 12:18 cy_huang
2022-09-15 13:43 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: cy_huang @ 2022-09-14 12:18 UTC (permalink / raw)
To: lee, robh+dt, krzysztof.kozlowski+dt, matthias.bgg
Cc: cy_huang, chiaen_wu, alice_chen, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
From: ChiYuan Huang <cy_huang@richtek.com>
Fix the indentation in the binding example. There're two redudant space
charactors need to be removed.
Fixes: 76f52f815f1a ("dt-bindings: mfd: Add MediaTek MT6370")
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
Since v2:
- Add Fixes tag in commit message
---
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
index 410e2d4..250484d 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
@@ -119,7 +119,7 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
- pmic@34 {
+ pmic@34 {
compatible = "mediatek,mt6370";
reg = <0x34>;
wakeup-source;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mfd: mt6370: fix the indentation in the example
2022-09-14 12:18 [PATCH v2] dt-bindings: mfd: mt6370: fix the indentation in the example cy_huang
@ 2022-09-15 13:43 ` Rob Herring
2022-09-15 13:56 ` ChiYuan Huang
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2022-09-15 13:43 UTC (permalink / raw)
To: cy_huang
Cc: matthias.bgg, devicetree, cy_huang, linux-mediatek, alice_chen,
robh+dt, lee, linux-arm-kernel, linux-kernel,
krzysztof.kozlowski+dt, chiaen_wu
On Wed, 14 Sep 2022 20:18:56 +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Fix the indentation in the binding example. There're two redudant space
> charactors need to be removed.
>
> Fixes: 76f52f815f1a ("dt-bindings: mfd: Add MediaTek MT6370")
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Since v2:
> - Add Fixes tag in commit message
>
> ---
> Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mfd: mt6370: fix the indentation in the example
2022-09-15 13:43 ` Rob Herring
@ 2022-09-15 13:56 ` ChiYuan Huang
2022-09-15 15:25 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: ChiYuan Huang @ 2022-09-15 13:56 UTC (permalink / raw)
To: Rob Herring
Cc: matthias.bgg, devicetree, cy_huang, linux-mediatek, alice_chen,
robh+dt, lee, linux-arm-kernel, linux-kernel,
krzysztof.kozlowski+dt, chiaen_wu
Rob Herring <robh@kernel.org> 於 2022年9月15日 週四 晚上9:43寫道:
>
> On Wed, 14 Sep 2022 20:18:56 +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Fix the indentation in the binding example. There're two redudant space
> > charactors need to be removed.
> >
> > Fixes: 76f52f815f1a ("dt-bindings: mfd: Add MediaTek MT6370")
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > Since v2:
> > - Add Fixes tag in commit message
> >
> > ---
> > Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
>
I'm not sure about the rule.
AngeloGioacchino said I need to add the 'Fixes' tag.
I think it might be important.
And I immediately submit the v2 patch and add the 'fixes' tag.
So patch v3 and add 'Acked-by' tag?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mfd: mt6370: fix the indentation in the example
2022-09-15 13:56 ` ChiYuan Huang
@ 2022-09-15 15:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-15 15:25 UTC (permalink / raw)
To: ChiYuan Huang, Rob Herring
Cc: matthias.bgg, devicetree, cy_huang, linux-mediatek, alice_chen,
robh+dt, lee, linux-arm-kernel, linux-kernel,
krzysztof.kozlowski+dt, chiaen_wu
On 15/09/2022 14:56, ChiYuan Huang wrote:
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
>>
> I'm not sure about the rule.
> AngeloGioacchino said I need to add the 'Fixes' tag.
> I think it might be important.
> And I immediately submit the v2 patch and add the 'fixes' tag.
> So patch v3 and add 'Acked-by' tag?
https://lore.kernel.org/all/20220914150620.GA2221443-robh@kernel.org/
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-15 15:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 12:18 [PATCH v2] dt-bindings: mfd: mt6370: fix the indentation in the example cy_huang
2022-09-15 13:43 ` Rob Herring
2022-09-15 13:56 ` ChiYuan Huang
2022-09-15 15:25 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).