[PATCH -next] sound: sunxi: fix declaration compile error

[PATCH -next] sound: sunxi: fix declaration compile error

[Zeng Heng]

Just fix compile error without any logic changes.

sound/soc/sunxi/sun50i-dmic.c:62:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration]
   62 | const static struct dmic_rate dmic_rate_s[] = {
      | ^~~~~

Signed-off-by: Zeng Heng <zengheng4@huawei.com>
---
 sound/soc/sunxi/sun50i-dmic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c
index cd3c07f2070f..86cff5a5b1bd 100644
--- a/sound/soc/sunxi/sun50i-dmic.c
+++ b/sound/soc/sunxi/sun50i-dmic.c
@@ -59,7 +59,7 @@ struct dmic_rate {
 	unsigned int rate_bit;
 };
 
-const static struct dmic_rate dmic_rate_s[] = {
+static const struct dmic_rate dmic_rate_s[] = {
 	{48000, 0x0},
 	{44100, 0x0},
 	{32000, 0x1},
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH -next] sound: sunxi: fix declaration compile error

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]

On Wed, Sep 21, 2022 at 11:38:19AM +0800, Zeng Heng wrote:
> Just fix compile error without any logic changes.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH -next] sound: sunxi: fix declaration compile error

[Mark Brown]

On Wed, 21 Sep 2022 11:38:19 +0800, Zeng Heng wrote:
> Just fix compile error without any logic changes.
> 
> sound/soc/sunxi/sun50i-dmic.c:62:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration]
>    62 | const static struct dmic_rate dmic_rate_s[] = {
>       | ^~~~~
> 
> 
> [...]

Applied to

   broonie/sound.git for-next

Thanks!

[1/1] sound: sunxi: fix declaration compile error
      commit: ee81cfb58286c1aed3263d2fc94b321e7d963f08

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH -next] sound: sunxi: fix declaration compile error

[Zeng Heng]

Thanks for your recommend.

I would pay more attention to proper subject line (like 'ASoC: sunxi: 
...') in the following patch.


在 2022/9/21 17:28, Mark Brown 写道:
> On Wed, Sep 21, 2022 at 11:38:19AM +0800, Zeng Heng wrote:
>> Just fix compile error without any logic changes.
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel