* [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema
@ 2022-10-01 3:07 Irui Wang
2022-10-01 9:36 ` Krzysztof Kozlowski
2022-10-03 13:24 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Irui Wang @ 2022-10-01 3:07 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Krzysztof Kozlowski
Cc: Yunfei Dong, Project_Global_Chrome_Upstream_Group, linux-media,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Maoguang Meng, Irui Wang
There are venc node warnings when running dtbs_check, the clock-names
was unexpected, missing properties '#address-cells' and '#size-cells'.
Add the corresponding platform compatible to schema.
Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
.../bindings/media/mediatek,vcodec-encoder.yaml | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index 32aee09aea33..0f2ea8d9a10c 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -67,6 +67,12 @@ properties:
power-domains:
maxItems: 1
+ "#address-cells":
+ const: 2
+
+ "#size-cells":
+ const: 2
+
required:
- compatible
- reg
@@ -84,7 +90,9 @@ allOf:
contains:
enum:
- mediatek,mt8183-vcodec-enc
+ - mediatek,mt8188-vcodec-enc
- mediatek,mt8192-vcodec-enc
+ - mediatek,mt8195-vcodec-enc
then:
required:
@@ -107,7 +115,9 @@ allOf:
compatible:
enum:
- mediatek,mt8173-vcodec-enc
+ - mediatek,mt8188-vcodec-enc
- mediatek,mt8192-vcodec-enc
+ - mediatek,mt8195-vcodec-enc
then:
properties:
@@ -118,7 +128,7 @@ allOf:
clock-names:
items:
- const: venc_sel
- else: # for vp8 hw decoder
+ else: # for vp8 hw encoder
properties:
clock:
items:
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema
2022-10-01 3:07 [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema Irui Wang
@ 2022-10-01 9:36 ` Krzysztof Kozlowski
2022-10-03 13:24 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-01 9:36 UTC (permalink / raw)
To: Irui Wang, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Krzysztof Kozlowski
Cc: Yunfei Dong, Project_Global_Chrome_Upstream_Group, linux-media,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Maoguang Meng
On 01/10/2022 05:07, Irui Wang wrote:
> There are venc node warnings when running dtbs_check, the clock-names
> was unexpected, missing properties '#address-cells' and '#size-cells'.
> Add the corresponding platform compatible to schema.
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> .../bindings/media/mediatek,vcodec-encoder.yaml | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema
2022-10-01 3:07 [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema Irui Wang
2022-10-01 9:36 ` Krzysztof Kozlowski
@ 2022-10-03 13:24 ` Rob Herring
2022-10-06 1:13 ` Irui Wang
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2022-10-03 13:24 UTC (permalink / raw)
To: Irui Wang
Cc: linux-kernel, linux-media, linux-mediatek, Krzysztof Kozlowski,
Maoguang Meng, Hans Verkuil, Yunfei Dong,
Project_Global_Chrome_Upstream_Group, Matthias Brugger,
Rob Herring, Mauro Carvalho Chehab, linux-arm-kernel, devicetree
On Sat, 01 Oct 2022 11:07:52 +0800, Irui Wang wrote:
> There are venc node warnings when running dtbs_check, the clock-names
> was unexpected, missing properties '#address-cells' and '#size-cells'.
> Add the corresponding platform compatible to schema.
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> .../bindings/media/mediatek,vcodec-encoder.yaml | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
vcodec@17020000: clock-names:0: 'venc_sel' was expected
arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb
arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb
arch/arm64/boot/dts/mediatek/mt8192-evb.dtb
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema
2022-10-03 13:24 ` Rob Herring
@ 2022-10-06 1:13 ` Irui Wang
0 siblings, 0 replies; 4+ messages in thread
From: Irui Wang @ 2022-10-06 1:13 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, linux-media, linux-mediatek, Krzysztof Kozlowski,
Maoguang Meng, Hans Verkuil, Yunfei Dong,
Project_Global_Chrome_Upstream_Group, Matthias Brugger,
Rob Herring, Mauro Carvalho Chehab, linux-arm-kernel, devicetree
Dear Rob,
Thanks for your reviewing.
On Mon, 2022-10-03 at 08:24 -0500, Rob Herring wrote:
> On Sat, 01 Oct 2022 11:07:52 +0800, Irui Wang wrote:
> > There are venc node warnings when running dtbs_check, the clock-
> > names
> > was unexpected, missing properties '#address-cells' and '#size-
> > cells'.
> > Add the corresponding platform compatible to schema.
> >
> > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > ---
> > .../bindings/media/mediatek,vcodec-encoder.yaml | 12
> > +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for
> dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
Yes, it's not a new warning, the 'clock-names' in mt8192.dtsi was
already unexpected without the patch's schema, we will fix it in the
future patch.
Thanks
Best Regards
>
>
> vcodec@17020000: clock-names:0: 'venc_sel' was expected
> arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb
> arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb
> arch/arm64/boot/dts/mediatek/mt8192-evb.dtb
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-06 1:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-01 3:07 [PATCH] dt-bindings: mediatek: vcodec: Add the platform compatible to schema Irui Wang
2022-10-01 9:36 ` Krzysztof Kozlowski
2022-10-03 13:24 ` Rob Herring
2022-10-06 1:13 ` Irui Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).