From: Jianjun Wang <jianjun.wang@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: <linux-pci@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Ryder Lee <ryder.lee@mediatek.com>, <Rex-BC.Chen@mediatek.com>,
<TingHan.Shen@mediatek.com>, <Liju-clr.Chen@mediatek.com>,
<Jian.Yang@mediatek.com>
Subject: Re: [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
Date: Tue, 2 Aug 2022 17:43:10 +0800 [thread overview]
Message-ID: <1688f1aad1f7239e5b0eb3d45a854ca6b0e61e1a.camel@mediatek.com> (raw)
In-Reply-To: <cd9518e3-9cb4-5165-af03-00e5300ab927@linaro.org>
Hi Krzysztof,
Thanks for your comment.
On Tue, 2022-08-02 at 10:59 +0200, Krzysztof Kozlowski wrote:
> On 01/08/2022 13:37, Jianjun Wang wrote:
> > MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as
> > MT8192.
> >
> > Also add new clock name "peri_mem" since the MT8188 and MT8195 use
> > clock
> > "peri_mem" instead of "top_133m".
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> > Changes in v3:
> > Use enum property to add the new clock name.
> >
> > Changes in v2:
> > Merge two patches into one.
> > ---
> > .../bindings/pci/mediatek-pcie-gen3.yaml | 14
> > ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 0499b94627ae..a0ca9c7f5dfa 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,14 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: mediatek,mt8192-pcie
> > + oneOf:
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-pcie
> > + - mediatek,mt8195-pcie
> > + - const: mediatek,mt8192-pcie
> > + - items:
>
> You have one item, so this is just const. Or enum if you expect it
> to
> grow soon.
It makes sense, I'll remove this "items" and just keep the const item
in the next version.
Thanks.
>
> > + - const: mediatek,mt8192-pcie
> >
> > reg:
> > maxItems: 1
> > @@ -84,7 +91,9 @@ properties:
> > - const: tl_96m
> > - const: tl_32k
> > - const: peri_26m
> > - - const: top_133m
> > + - enum:
> > + - top_133m # for MT8192
> > + - peri_mem # for MT8188/MT8195
>
> This requires allOf:if:then restricting it further per variant.
>
>
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-08-02 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 11:37 [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 Jianjun Wang
2022-08-02 8:59 ` Krzysztof Kozlowski
2022-08-02 9:04 ` Krzysztof Kozlowski
2022-08-02 9:43 ` Jianjun Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688f1aad1f7239e5b0eb3d45a854ca6b0e61e1a.camel@mediatek.com \
--to=jianjun.wang@mediatek.com \
--cc=Jian.Yang@mediatek.com \
--cc=Liju-clr.Chen@mediatek.com \
--cc=Rex-BC.Chen@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).