From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: mt8192: Add vcodec lat and core nodes
Date: Wed, 28 Sep 2022 09:04:15 +0200 [thread overview]
Message-ID: <172e10ee-22fd-ccec-1a5a-7bd0a29dbfc4@linaro.org> (raw)
In-Reply-To: <05ed341b-2db3-620f-7a70-dcebfaa66f1a@collabora.com>
On 27/09/2022 12:17, AngeloGioacchino Del Regno wrote:
>>>
>>
>> Sorry, my bad. I alsways run `make dtbs_check` to confirm dtb with
>> bindings. I just think we didn't limit node names in mtk-vodec
>> bindings. I will pay attention next time.
>>
>>
>> Since currently the vcodec lat and core nodes are absent from the mtk
>> dts, do you think the child node name should be changed to something
>> more general (ex: video-codec) in mediatek,vcodec-subdev-decoder
>> bindings?
>
> The video codec is mt8192-vcodec-dec, while the other nodes are describing
> the VPU instances (and/or vpu cores)... I'm not sure.
>
> Krzysztof, please, can you give your opinion on that?
>
What's the difference between them? I understand parent device is entire
block of consisting of multiple processing units? If so, video-codec
actually could fit in both places. But feel free to call it a bit
different (video-codec-core, video-codec-lat, processing-unit, even
something less generic). Sometimes it's tricky to find nice name, so I
wouldn't worry too much in that case. Just not "mt8192-vcodec" :)
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-28 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 10:50 [PATCH v2] arm64: dts: mt8192: Add vcodec lat and core nodes Allen-KH Cheng
2022-09-26 15:29 ` AngeloGioacchino Del Regno
2022-09-27 2:19 ` Allen-KH Cheng (程冠勳)
2022-09-27 10:17 ` AngeloGioacchino Del Regno
2022-09-28 7:04 ` Krzysztof Kozlowski [this message]
2022-09-28 7:58 ` AngeloGioacchino Del Regno
2022-09-28 17:26 ` Krzysztof Kozlowski
2022-09-29 8:30 ` AngeloGioacchino Del Regno
2022-09-29 11:25 ` Allen-KH Cheng (程冠勳)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172e10ee-22fd-ccec-1a5a-7bd0a29dbfc4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Allen-KH.Cheng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).