From: "Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: mt8192: Add vcodec lat and core nodes
Date: Thu, 29 Sep 2022 11:25:49 +0000 [thread overview]
Message-ID: <6b8a0f42ae7f868bc09039af07f165bf2e640e05.camel@mediatek.com> (raw)
In-Reply-To: <514f8de1-1a23-1947-80cd-6136e17af490@collabora.com>
On Thu, 2022-09-29 at 10:30 +0200, AngeloGioacchino Del Regno wrote:
> Il 28/09/22 19:26, Krzysztof Kozlowski ha scritto:
> > On 28/09/2022 09:58, AngeloGioacchino Del Regno wrote:
> > > Il 28/09/22 09:04, Krzysztof Kozlowski ha scritto:
> > > > On 27/09/2022 12:17, AngeloGioacchino Del Regno wrote:
> > > > > > >
> > > > > >
> > > > > > Sorry, my bad. I alsways run `make dtbs_check` to confirm
> > > > > > dtb with
> > > > > > bindings. I just think we didn't limit node names in mtk-
> > > > > > vodec
> > > > > > bindings. I will pay attention next time.
> > > > > >
> > > > > >
> > > > > > Since currently the vcodec lat and core nodes are absent
> > > > > > from the mtk
> > > > > > dts, do you think the child node name should be changed to
> > > > > > something
> > > > > > more general (ex: video-codec) in mediatek,vcodec-subdev-
> > > > > > decoder
> > > > > > bindings?
> > > > >
> > > > > The video codec is mt8192-vcodec-dec, while the other nodes
> > > > > are describing
> > > > > the VPU instances (and/or vpu cores)... I'm not sure.
> > > > >
> > > > > Krzysztof, please, can you give your opinion on that?
> > > > >
> > > >
> > > > What's the difference between them? I understand parent device
> > > > is entire
> > > > block of consisting of multiple processing units? If so, video-
> > > > codec
> > > > actually could fit in both places. But feel free to call it a
> > > > bit
> > > > different (video-codec-core, video-codec-lat, processing-unit,
> > > > even
> > > > something less generic). Sometimes it's tricky to find nice
> > > > name, so I
> > > > wouldn't worry too much in that case. Just not "mt8192-vcodec"
> > > > :)
> > > >
> > >
> > > The parent device is the entire block consisting of multiple
> > > processing units
> > > and has "global" control registers; children are LAT(s) and
> > > processing cores.
> > >
> > > From my understanding, the processing cores are physical cores
> > > of one big VPU
> > > and, depending on the actual (current gen) SoC, the VPU may have
> > > one or two
> > > cores.
> > >
> > > Right now, the bindings want vcodec-latX@addr, vcodec-coreX@addr
> > > (where X is
> > > a number, like vcodec-core0, vcodec-core1) but, in my opinion,
> > > changing that
> > > to video-codec-lat@addr and video-codec-core@addr would be more
> > > descriptive.
> > >
> > > ...Or should we simply leave the bindings as they are and just go
> > > with the
> > > abbreviated "vcodec-(hwtype)" names?
> >
> > video-codec-lat sounds better, but I am not sure if it is worth the
> > churn, so I am fine with both.
> >
>
> Thank you Krzysztof!
>
> Allen, can you please change the binding to use "video-codec-lat" and
> "video-codec-core" (so change "vcodec" to "video-codec") and then use
> these names for this commit?
>
> Doing the change right now won't break the ABI, as there's no
> devicetree
> using that binding yet (with this commit adding the first user), so
> you
> can safely go for the rename without any complication.
>
> Regards,
> Angelo
>
>
>
Hi Angelo,
No problem, I will update in the following version.
Thanks,
Allen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-29 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 10:50 [PATCH v2] arm64: dts: mt8192: Add vcodec lat and core nodes Allen-KH Cheng
2022-09-26 15:29 ` AngeloGioacchino Del Regno
2022-09-27 2:19 ` Allen-KH Cheng (程冠勳)
2022-09-27 10:17 ` AngeloGioacchino Del Regno
2022-09-28 7:04 ` Krzysztof Kozlowski
2022-09-28 7:58 ` AngeloGioacchino Del Regno
2022-09-28 17:26 ` Krzysztof Kozlowski
2022-09-29 8:30 ` AngeloGioacchino Del Regno
2022-09-29 11:25 ` Allen-KH Cheng (程冠勳) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b8a0f42ae7f868bc09039af07f165bf2e640e05.camel@mediatek.com \
--to=allen-kh.cheng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).