From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for firefly reload
Date: Wed, 17 Aug 2016 16:10:09 +0200 [thread overview]
Message-ID: <19126716.OZv44ZHtAK@diego> (raw)
In-Reply-To: <af99cf05-dfc7-1ae6-8d23-f33298b5f683@soulik.info>
Am Sonntag, 14. August 2016, 20:38:59 schrieb ayaka:
> On 08/14/2016 08:30 PM, Heiko Stuebner wrote:
> > Am Sonntag, 14. August 2016, 19:27:23 CEST schrieb Randy Li:
> >> Because of a bug in hardware design, the sdcard at firefly
> >> rk3288 reload board can't switch the io voltage level to 1.8v.
> >>
> >> Signed-off-by: Randy Li <ayaka@soulik.info>
> >> ---
> >>
> >> arch/arm/boot/dts/rk3288-firefly-reload.dts | 7 +------
> >> 1 file changed, 1 insertion(+), 6 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts
> >> b/arch/arm/boot/dts/rk3288-firefly-reload.dts index 43145d1..a2b1f14
> >> 100644
> >> --- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
> >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
> >> @@ -202,18 +202,13 @@
> >>
> >> bus-width = <4>;
> >> cap-mmc-highspeed;
> >> cap-sd-highspeed;
> >>
> >> - sd-uhs-sdr12;
> >> - sd-uhs-sdr25;
> >> - sd-uhs-sdr50;
> >> - sd-uhs-sdr104;
> >> - sd-uhs-ddr50;
> >>
> >> card-detect-delay = <200>;
> >> disable-wp;
> >> num-slots = <1>;
> >> pinctrl-names = "default";
> >> pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
> >> vmmc-supply = <&vcc_sd>;
> >>
> >> - vqmmc-supply = <&vccio_sd>;
> >> + vqmmc-supply = <&vcc_sd>;
> >
> > that looks wrong. vccio_sd is still the vqmmc supply in the schematics
> > even
> > though we don't want to switch to 1.8V . But that regulator should still
> > be
>
> I think the vccio_sd is just the one connected to the io_domains, but
> the voltage source for the
> pull up register is not vccio_sd but vcc_io.
vqmmc-supply is the so called io-voltage according to the code and also the
jedec spec (VCCQ). And the sdmmc0_vdd that vccio_sd is connected to is exactly
that ... according to the rk3288 datasheet the "SDMMC0 Digital IO Power
Supply", so that connection is not only meaningful for the iodomains, but _is_
an actual supply and if you turn off vccio_sd, you probably won't get any
sdmmc transfers at all ;-) .
So yes, due to the resistor misheap vccio_sd should stay limited to 3.3V, but
its connection as vqmmc should stay.
next prev parent reply other threads:[~2016-08-17 14:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 15:25 [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload ayaka
2016-07-06 15:25 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi ayaka
2016-07-06 15:25 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics ayaka
2016-07-06 16:13 ` Heiko Stuebner
2016-07-06 17:34 ` [PATCH 0/3] " Randy Li
2016-07-06 17:34 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li
2016-07-06 17:34 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 17:34 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-06 17:52 ` [PATCH 0/3] Re:[PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 17:52 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li
2016-07-06 17:52 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 17:52 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-06 18:06 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 18:22 ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Randy Li
2016-07-06 18:22 ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li
2016-07-06 18:22 ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 18:23 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-07 21:35 ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Heiko Stuebner
2016-07-09 15:42 ` ayaka
2016-07-09 23:06 ` Heiko Stuebner
2016-07-17 15:38 ` [PATCH] " Randy Li
2016-07-17 15:38 ` [PATCH] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-17 21:01 ` Rob Herring
2016-07-18 11:24 ` Heiko Stübner
2016-07-18 15:32 ` [PATCH v2] " Randy Li
2016-07-18 15:32 ` [PATCH] " Randy Li
2016-07-18 19:46 ` Heiko Stübner
2016-08-07 3:40 ` Shawn Lin
2016-08-07 14:44 ` Heiko Stuebner
2016-08-08 2:29 ` Shawn Lin
2016-08-09 9:28 ` 陈豪
2016-08-09 10:02 ` 陈豪
2016-08-09 10:06 ` Randy Li
2016-08-09 10:58 ` Heiko Stübner
2016-08-10 1:12 ` Randy Li
2016-08-14 11:27 ` [PATCH 0/2] ARM: dts: rockchip: correct the regulators in firefly reload Randy Li
2016-08-14 11:27 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li
2016-08-14 12:30 ` Heiko Stuebner
2016-08-14 12:38 ` ayaka
2016-08-17 14:10 ` Heiko Stübner [this message]
2016-08-17 17:03 ` [PATCH 0/2 v2] ARM: dts: rockchip: correct the regulators in " Randy Li
2016-08-17 17:03 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li
2016-08-18 13:35 ` Heiko Stübner
2016-08-18 14:20 ` ayaka
2016-08-17 17:03 ` [PATCH 2/2] ARM: dts: rockchip: add missing regulators for firefly reload board Randy Li
2016-08-18 16:47 ` Heiko Stübner
2016-08-14 11:27 ` Randy Li
2016-07-06 15:25 ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload ayaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19126716.OZv44ZHtAK@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).