* [PATCH v4 0/2] Add i2c dt-binding and device node for Mediatek MT2701 Soc
@ 2017-05-26 7:35 Jun Gao
2017-05-26 7:35 ` [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding Jun Gao
2017-05-26 7:35 ` [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node Jun Gao
0 siblings, 2 replies; 16+ messages in thread
From: Jun Gao @ 2017-05-26 7:35 UTC (permalink / raw)
To: linux-arm-kernel
This patch series based on v4.12-rc1, include MT2701 i2c dt-binding
and device node.
changes since v3:
- Add fallback compatible to dt-binding
changes since v2:
- Modify commit message
- Revise dt-binding documentation
changes since v1:
- Modify commit message
Dependent on "Add clock and power domain DT nodes for Mediatek MT2701"[1].
[1] http://lists.infradead.org/pipermail/linux-mediatek/2016-December/007637.html
Jun Gao (2):
dt-bindings: i2c: Add Mediatek MT2701 i2c binding
arm: dts: Add Mediatek MT2701 i2c device node
.../devicetree/bindings/i2c/i2c-mt6577.txt | 11 +++---
arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++
arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++
3 files changed, 90 insertions(+), 5 deletions(-)
--
1.8.1.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding
2017-05-26 7:35 [PATCH v4 0/2] Add i2c dt-binding and device node for Mediatek MT2701 Soc Jun Gao
@ 2017-05-26 7:35 ` Jun Gao
2017-05-29 15:30 ` Matthias Brugger
2017-05-26 7:35 ` [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node Jun Gao
1 sibling, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-05-26 7:35 UTC (permalink / raw)
To: linux-arm-kernel
From: Jun Gao <jun.gao@mediatek.com>
Add MT2701 i2c binding to i2c-mt6577.txt and there is no need to
modify i2c driver.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
index 0ce6fa3..52f2023 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
- (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
- (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
- (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
- (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt8127-i2c": for Mediatek MT8127
+ "mediatek,mt8135-i2c": for Mediatek MT8135
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-05-26 7:35 [PATCH v4 0/2] Add i2c dt-binding and device node for Mediatek MT2701 Soc Jun Gao
2017-05-26 7:35 ` [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding Jun Gao
@ 2017-05-26 7:35 ` Jun Gao
2017-06-12 11:54 ` Jun Gao
1 sibling, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-05-26 7:35 UTC (permalink / raw)
To: linux-arm-kernel
From: Jun Gao <jun.gao@mediatek.com>
Add MT2701 i2c device node.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 84 insertions(+)
diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
index a483798..3f5a96c 100644
--- a/arch/arm/boot/dts/mt2701-evb.dts
+++ b/arch/arm/boot/dts/mt2701-evb.dts
@@ -28,7 +28,49 @@
status = "okay";
};
+&i2c0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0_pins_a>;
+ status = "okay";
+};
+
+&i2c1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c1_pins_a>;
+ status = "okay";
+};
+
+&i2c2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c2_pins_a>;
+ status = "okay";
+};
+
&pio {
+ i2c0_pins_a: i2c0 at 0 {
+ pins1 {
+ pinmux = <MT2701_PIN_75_SDA0__FUNC_SDA0>,
+ <MT2701_PIN_76_SCL0__FUNC_SCL0>;
+ bias-disable;
+ };
+ };
+
+ i2c1_pins_a: i2c1 at 0 {
+ pins1 {
+ pinmux = <MT2701_PIN_57_SDA1__FUNC_SDA1>,
+ <MT2701_PIN_58_SCL1__FUNC_SCL1>;
+ bias-disable;
+ };
+ };
+
+ i2c2_pins_a: i2c2 at 0 {
+ pins1 {
+ pinmux = <MT2701_PIN_77_SDA2__FUNC_SDA2>,
+ <MT2701_PIN_78_SCL2__FUNC_SCL2>;
+ bias-disable;
+ };
+ };
+
spi_pins_a: spi0 at 0 {
pins_spi {
pinmux = <MT2701_PIN_53_SPI0_CSN__FUNC_SPI0_CS>,
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index 8037210..1b6157e 100644
--- a/arch/arm/boot/dts/mt2701.dtsi
+++ b/arch/arm/boot/dts/mt2701.dtsi
@@ -286,6 +286,48 @@
status = "disabled";
};
+ i2c0: i2c at 11007000 {
+ compatible = "mediatek,mt2701-i2c",
+ "mediatek,mt6577-i2c";
+ reg = <0 0x11007000 0 0x70>,
+ <0 0x11000200 0 0x80>;
+ interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
+ clock-div = <16>;
+ clocks = <&pericfg CLK_PERI_I2C0>, <&pericfg CLK_PERI_AP_DMA>;
+ clock-names = "main", "dma";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ i2c1: i2c at 11008000 {
+ compatible = "mediatek,mt2701-i2c",
+ "mediatek,mt6577-i2c";
+ reg = <0 0x11008000 0 0x70>,
+ <0 0x11000280 0 0x80>;
+ interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_LOW>;
+ clock-div = <16>;
+ clocks = <&pericfg CLK_PERI_I2C1>, <&pericfg CLK_PERI_AP_DMA>;
+ clock-names = "main", "dma";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ i2c2: i2c at 11009000 {
+ compatible = "mediatek,mt2701-i2c",
+ "mediatek,mt6577-i2c";
+ reg = <0 0x11009000 0 0x70>,
+ <0 0x11000300 0 0x80>;
+ interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_LOW>;
+ clock-div = <16>;
+ clocks = <&pericfg CLK_PERI_I2C2>, <&pericfg CLK_PERI_AP_DMA>;
+ clock-names = "main", "dma";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
spi0: spi at 1100a000 {
compatible = "mediatek,mt2701-spi";
#address-cells = <1>;
--
1.8.1.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding
2017-05-26 7:35 ` [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding Jun Gao
@ 2017-05-29 15:30 ` Matthias Brugger
2017-05-30 21:38 ` Rob Herring
0 siblings, 1 reply; 16+ messages in thread
From: Matthias Brugger @ 2017-05-29 15:30 UTC (permalink / raw)
To: linux-arm-kernel
On 26/05/17 09:35, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add MT2701 i2c binding to i2c-mt6577.txt and there is no need to
> modify i2c driver.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> index 0ce6fa3..52f2023 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>
> Required properties:
> - compatible: value should be either of the following.
> - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
I send a cleanup patch for the file, which fixes all the other SoCs.
I can fold this one into it, a soon as I got a Signed-off from the DT
maintainers.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt8127-i2c": for Mediatek MT8127
> + "mediatek,mt8135-i2c": for Mediatek MT8135
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding
2017-05-29 15:30 ` Matthias Brugger
@ 2017-05-30 21:38 ` Rob Herring
2017-05-31 2:24 ` Jun Gao
0 siblings, 1 reply; 16+ messages in thread
From: Rob Herring @ 2017-05-30 21:38 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 29, 2017 at 05:30:26PM +0200, Matthias Brugger wrote:
g>
>
> On 26/05/17 09:35, Jun Gao wrote:
> > From: Jun Gao <jun.gao@mediatek.com>
> >
> > Add MT2701 i2c binding to i2c-mt6577.txt and there is no need to
> > modify i2c driver.
> >
> > Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> > index 0ce6fa3..52f2023 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
> > Required properties:
> > - compatible: value should be either of the following.
> > - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> > - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> > - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> > - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> > - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
>
> I send a cleanup patch for the file, which fixes all the other SoCs.
> I can fold this one into it, a soon as I got a Signed-off from the DT
> maintainers.
I already acked it on the prior versions.
Rob
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding
2017-05-30 21:38 ` Rob Herring
@ 2017-05-31 2:24 ` Jun Gao
2017-05-31 12:05 ` Matthias Brugger
0 siblings, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-05-31 2:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-05-30 at 16:38 -0500, Rob Herring wrote:
> On Mon, May 29, 2017 at 05:30:26PM +0200, Matthias Brugger wrote:
> g>
> >
> > On 26/05/17 09:35, Jun Gao wrote:
> > > From: Jun Gao <jun.gao@mediatek.com>
> > >
> > > Add MT2701 i2c binding to i2c-mt6577.txt and there is no need to
> > > modify i2c driver.
> > >
> > > Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> > > ---
> > > Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++-----
> > > 1 file changed, 6 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> > > index 0ce6fa3..52f2023 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> > > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
> > > Required properties:
> > > - compatible: value should be either of the following.
> > > - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> > > - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> > > - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> > > - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> > > - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> > > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> >
> > I send a cleanup patch for the file, which fixes all the other SoCs.
> > I can fold this one into it, a soon as I got a Signed-off from the DT
> > maintainers.
>
> I already acked it on the prior versions.
>
> Rob
Hi Matthias,
Which patch should I use now? Or you help to modify dt-binding, I only
send dtsi file patch ? Thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding
2017-05-31 2:24 ` Jun Gao
@ 2017-05-31 12:05 ` Matthias Brugger
0 siblings, 0 replies; 16+ messages in thread
From: Matthias Brugger @ 2017-05-31 12:05 UTC (permalink / raw)
To: linux-arm-kernel
On 31/05/17 04:24, Jun Gao wrote:
> On Tue, 2017-05-30 at 16:38 -0500, Rob Herring wrote:
>> On Mon, May 29, 2017 at 05:30:26PM +0200, Matthias Brugger wrote:
>> g>
>>>
>>> On 26/05/17 09:35, Jun Gao wrote:
>>>> From: Jun Gao <jun.gao@mediatek.com>
>>>>
>>>> Add MT2701 i2c binding to i2c-mt6577.txt and there is no need to
>>>> modify i2c driver.
>>>>
>>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
>>>> ---
>>>> Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++-----
>>>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>>>> index 0ce6fa3..52f2023 100644
>>>> --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>>>> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>>>> Required properties:
>>>> - compatible: value should be either of the following.
>>>> - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
>>>> - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
>>>> - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
>>>> - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
>>>> - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
>>>> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
>>>
>>> I send a cleanup patch for the file, which fixes all the other SoCs.
>>> I can fold this one into it, a soon as I got a Signed-off from the DT
>>> maintainers.
>>
>> I already acked it on the prior versions.
>>
>> Rob
>
> Hi Matthias,
>
> Which patch should I use now? Or you help to modify dt-binding, I only
> send dtsi file patch ? Thanks!
>
Don't worry, I fixed the commit and took both of them.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-05-26 7:35 ` [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node Jun Gao
@ 2017-06-12 11:54 ` Jun Gao
2017-06-13 9:36 ` Matthias Brugger
0 siblings, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-06-12 11:54 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add MT2701 i2c device node.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 84 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> index a483798..3f5a96c 100644
> --- a/arch/arm/boot/dts/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mt2701-evb.dts
> @@ -28,7 +28,49 @@
> status = "okay";
> };
>
> +&i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins_a>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins_a>;
> + status = "okay";
> +};
> +
> +&i2c2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pins_a>;
> + status = "okay";
> +};
> +
> &pio {
> + i2c0_pins_a: i2c0 at 0 {
> + pins1 {
> + pinmux = <MT2701_PIN_75_SDA0__FUNC_SDA0>,
> + <MT2701_PIN_76_SCL0__FUNC_SCL0>;
> + bias-disable;
> + };
> + };
> +
> + i2c1_pins_a: i2c1 at 0 {
> + pins1 {
> + pinmux = <MT2701_PIN_57_SDA1__FUNC_SDA1>,
> + <MT2701_PIN_58_SCL1__FUNC_SCL1>;
> + bias-disable;
> + };
> + };
> +
> + i2c2_pins_a: i2c2 at 0 {
> + pins1 {
> + pinmux = <MT2701_PIN_77_SDA2__FUNC_SDA2>,
> + <MT2701_PIN_78_SCL2__FUNC_SCL2>;
> + bias-disable;
> + };
> + };
> +
> spi_pins_a: spi0 at 0 {
> pins_spi {
> pinmux = <MT2701_PIN_53_SPI0_CSN__FUNC_SPI0_CS>,
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index 8037210..1b6157e 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -286,6 +286,48 @@
> status = "disabled";
> };
>
> + i2c0: i2c at 11007000 {
> + compatible = "mediatek,mt2701-i2c",
> + "mediatek,mt6577-i2c";
> + reg = <0 0x11007000 0 0x70>,
> + <0 0x11000200 0 0x80>;
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> + clock-div = <16>;
> + clocks = <&pericfg CLK_PERI_I2C0>, <&pericfg CLK_PERI_AP_DMA>;
> + clock-names = "main", "dma";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c at 11008000 {
> + compatible = "mediatek,mt2701-i2c",
> + "mediatek,mt6577-i2c";
> + reg = <0 0x11008000 0 0x70>,
> + <0 0x11000280 0 0x80>;
> + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_LOW>;
> + clock-div = <16>;
> + clocks = <&pericfg CLK_PERI_I2C1>, <&pericfg CLK_PERI_AP_DMA>;
> + clock-names = "main", "dma";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c at 11009000 {
> + compatible = "mediatek,mt2701-i2c",
> + "mediatek,mt6577-i2c";
> + reg = <0 0x11009000 0 0x70>,
> + <0 0x11000300 0 0x80>;
> + interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_LOW>;
> + clock-div = <16>;
> + clocks = <&pericfg CLK_PERI_I2C2>, <&pericfg CLK_PERI_AP_DMA>;
> + clock-names = "main", "dma";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> spi0: spi at 1100a000 {
> compatible = "mediatek,mt2701-spi";
> #address-cells = <1>;
Dear Matthias,
Could you take this patch together with
[PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
Thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-12 11:54 ` Jun Gao
@ 2017-06-13 9:36 ` Matthias Brugger
2017-06-13 10:24 ` Jun Gao
0 siblings, 1 reply; 16+ messages in thread
From: Matthias Brugger @ 2017-06-13 9:36 UTC (permalink / raw)
To: linux-arm-kernel
On 12/06/17 13:54, Jun Gao wrote:
> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>> From: Jun Gao <jun.gao@mediatek.com>
>>
>> Add MT2701 i2c device node.
>>
>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
>> ---
>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 84 insertions(+)
[...]
>
> Dear Matthias,
>
> Could you take this patch together with
> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>
> Thanks!
>
They are both included in the pull request I send [1] [2], or do I miss
something?
Regards,
Matthias
[1]
https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
[2]
https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-13 9:36 ` Matthias Brugger
@ 2017-06-13 10:24 ` Jun Gao
2017-06-13 12:52 ` Matthias Brugger
0 siblings, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-06-13 10:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>
> On 12/06/17 13:54, Jun Gao wrote:
> > On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >> From: Jun Gao <jun.gao@mediatek.com>
> >>
> >> Add MT2701 i2c device node.
> >>
> >> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> >> ---
> >> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 84 insertions(+)
> [...]
> >
> > Dear Matthias,
> >
> > Could you take this patch together with
> > [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >
> > Thanks!
> >
>
> They are both included in the pull request I send [1] [2], or do I miss
> something?
>
> Regards,
> Matthias
>
> [1]
> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> [2]
> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
Dear Matthias,
Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
"mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
"mediatek,mt6577-i2c": for Mediatek MT6577
"mediatek,mt6589-i2c": for Mediatek MT6589
"mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
"mediatek,mt8173-i2c": for Mediatek MT8173
Thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-13 10:24 ` Jun Gao
@ 2017-06-13 12:52 ` Matthias Brugger
2017-06-13 13:23 ` Jun Gao
0 siblings, 1 reply; 16+ messages in thread
From: Matthias Brugger @ 2017-06-13 12:52 UTC (permalink / raw)
To: linux-arm-kernel
On 13/06/17 12:24, Jun Gao wrote:
> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>>
>> On 12/06/17 13:54, Jun Gao wrote:
>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>>>> From: Jun Gao <jun.gao@mediatek.com>
>>>>
>>>> Add MT2701 i2c device node.
>>>>
>>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
>>>> ---
>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>>>> 2 files changed, 84 insertions(+)
>> [...]
>>>
>>> Dear Matthias,
>>>
>>> Could you take this patch together with
>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>>>
>>> Thanks!
>>>
>>
>> They are both included in the pull request I send [1] [2], or do I miss
>> something?
>>
>> Regards,
>> Matthias
>>
>> [1]
>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
>> [2]
>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
>
> Dear Matthias,
>
> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
>
> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> "mediatek,mt6577-i2c": for Mediatek MT6577
> "mediatek,mt6589-i2c": for Mediatek MT6589
> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> "mediatek,mt8173-i2c": for Mediatek MT8173
>
>
> Thanks!
>
You mean I should fix-up the patch to fit to the new binding
description? Or do you mean it should be MTxxxx instead of mtxxxx?
Regards,
Matthias
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-13 12:52 ` Matthias Brugger
@ 2017-06-13 13:23 ` Jun Gao
2017-06-13 13:45 ` Matthias Brugger
0 siblings, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-06-13 13:23 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
>
> On 13/06/17 12:24, Jun Gao wrote:
> > On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
> >>
> >> On 12/06/17 13:54, Jun Gao wrote:
> >>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >>>> From: Jun Gao <jun.gao@mediatek.com>
> >>>>
> >>>> Add MT2701 i2c device node.
> >>>>
> >>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> >>>> ---
> >>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>> 2 files changed, 84 insertions(+)
> >> [...]
> >>>
> >>> Dear Matthias,
> >>>
> >>> Could you take this patch together with
> >>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >>>
> >>> Thanks!
> >>>
> >>
> >> They are both included in the pull request I send [1] [2], or do I miss
> >> something?
> >>
> >> Regards,
> >> Matthias
> >>
> >> [1]
> >> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> >> [2]
> >> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
> >
> > Dear Matthias,
> >
> > Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
> >
> > "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> > "mediatek,mt6577-i2c": for Mediatek MT6577
> > "mediatek,mt6589-i2c": for Mediatek MT6589
> > "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> > "mediatek,mt8173-i2c": for Mediatek MT8173
> >
> >
> > Thanks!
> >
>
> You mean I should fix-up the patch to fit to the new binding
> description? Or do you mean it should be MTxxxx instead of mtxxxx?
>
> Regards,
> Matthias
Dear Matthias,
I mean fix-up the patch to fit to the new binding description. Is it OK?
Thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-13 13:23 ` Jun Gao
@ 2017-06-13 13:45 ` Matthias Brugger
2017-06-14 1:11 ` Jun Gao
0 siblings, 1 reply; 16+ messages in thread
From: Matthias Brugger @ 2017-06-13 13:45 UTC (permalink / raw)
To: linux-arm-kernel
On 13/06/17 15:23, Jun Gao wrote:
> On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
>>
>> On 13/06/17 12:24, Jun Gao wrote:
>>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>>>>
>>>> On 12/06/17 13:54, Jun Gao wrote:
>>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>>>>>> From: Jun Gao <jun.gao@mediatek.com>
>>>>>>
>>>>>> Add MT2701 i2c device node.
>>>>>>
>>>>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
>>>>>> ---
>>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>> 2 files changed, 84 insertions(+)
>>>> [...]
>>>>>
>>>>> Dear Matthias,
>>>>>
>>>>> Could you take this patch together with
>>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>>>>>
>>>>> Thanks!
>>>>>
>>>>
>>>> They are both included in the pull request I send [1] [2], or do I miss
>>>> something?
>>>>
>>>> Regards,
>>>> Matthias
>>>>
>>>> [1]
>>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
>>>> [2]
>>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
>>>
>>> Dear Matthias,
>>>
>>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
>>>
>>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
>>> "mediatek,mt6577-i2c": for Mediatek MT6577
>>> "mediatek,mt6589-i2c": for Mediatek MT6589
>>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
>>> "mediatek,mt8173-i2c": for Mediatek MT8173
>>>
>>>
>>> Thanks!
>>>
>>
>> You mean I should fix-up the patch to fit to the new binding
>> description? Or do you mean it should be MTxxxx instead of mtxxxx?
>>
>> Regards,
>> Matthias
>
> Dear Matthias,
>
> I mean fix-up the patch to fit to the new binding description. Is it OK?
>
Then I can't see the difference between what you are asking for and what
is already pushed to the repository. Please send a patch, that will make
things clearer.
Regards,
Matthias
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-13 13:45 ` Matthias Brugger
@ 2017-06-14 1:11 ` Jun Gao
2017-06-14 9:24 ` Matthias Brugger
0 siblings, 1 reply; 16+ messages in thread
From: Jun Gao @ 2017-06-14 1:11 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:
>
> On 13/06/17 15:23, Jun Gao wrote:
> > On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
> >>
> >> On 13/06/17 12:24, Jun Gao wrote:
> >>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
> >>>>
> >>>> On 12/06/17 13:54, Jun Gao wrote:
> >>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >>>>>> From: Jun Gao <jun.gao@mediatek.com>
> >>>>>>
> >>>>>> Add MT2701 i2c device node.
> >>>>>>
> >>>>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> >>>>>> ---
> >>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>> 2 files changed, 84 insertions(+)
> >>>> [...]
> >>>>>
> >>>>> Dear Matthias,
> >>>>>
> >>>>> Could you take this patch together with
> >>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >>>>>
> >>>>> Thanks!
> >>>>>
> >>>>
> >>>> They are both included in the pull request I send [1] [2], or do I miss
> >>>> something?
> >>>>
> >>>> Regards,
> >>>> Matthias
> >>>>
> >>>> [1]
> >>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> >>>> [2]
> >>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
> >>>
> >>> Dear Matthias,
> >>>
> >>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
> >>>
> >>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> >>> "mediatek,mt6577-i2c": for Mediatek MT6577
> >>> "mediatek,mt6589-i2c": for Mediatek MT6589
> >>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> >>> "mediatek,mt8173-i2c": for Mediatek MT8173
> >>>
> >>>
> >>> Thanks!
> >>>
> >>
> >> You mean I should fix-up the patch to fit to the new binding
> >> description? Or do you mean it should be MTxxxx instead of mtxxxx?
> >>
> >> Regards,
> >> Matthias
> >
> > Dear Matthias,
> >
> > I mean fix-up the patch to fit to the new binding description. Is it OK?
> >
>
> Then I can't see the difference between what you are asking for and what
> is already pushed to the repository. Please send a patch, that will make
> things clearer.
>
> Regards,
> Matthias
Dear Matthias,
like this:
diff:
Required properties:
- compatible: value should be either of the following.
- (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
- (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
- (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
- (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
- (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length
of memory
mapped region.
- interrupts: interrupt number to the cpu.
Thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-14 1:11 ` Jun Gao
@ 2017-06-14 9:24 ` Matthias Brugger
2017-06-14 9:43 ` Jun Gao
0 siblings, 1 reply; 16+ messages in thread
From: Matthias Brugger @ 2017-06-14 9:24 UTC (permalink / raw)
To: linux-arm-kernel
On 14/06/17 03:11, Jun Gao wrote:
> On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:
>>
>> On 13/06/17 15:23, Jun Gao wrote:
>>> On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
>>>>
>>>> On 13/06/17 12:24, Jun Gao wrote:
>>>>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
>>>>>>
>>>>>> On 12/06/17 13:54, Jun Gao wrote:
>>>>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
>>>>>>>> From: Jun Gao <jun.gao@mediatek.com>
>>>>>>>>
>>>>>>>> Add MT2701 i2c device node.
>>>>>>>>
>>>>>>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
>>>>>>>> ---
>>>>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
>>>>>>>> 2 files changed, 84 insertions(+)
>>>>>> [...]
>>>>>>>
>>>>>>> Dear Matthias,
>>>>>>>
>>>>>>> Could you take this patch together with
>>>>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
>>>>>>>
>>>>>>> Thanks!
>>>>>>>
>>>>>>
>>>>>> They are both included in the pull request I send [1] [2], or do I miss
>>>>>> something?
>>>>>>
>>>>>> Regards,
>>>>>> Matthias
>>>>>>
>>>>>> [1]
>>>>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
>>>>>> [2]
>>>>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
>>>>>
>>>>> Dear Matthias,
>>>>>
>>>>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
>>>>>
>>>>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
>>>>> "mediatek,mt6577-i2c": for Mediatek MT6577
>>>>> "mediatek,mt6589-i2c": for Mediatek MT6589
>>>>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
>>>>> "mediatek,mt8173-i2c": for Mediatek MT8173
>>>>>
>>>>>
>>>>> Thanks!
>>>>>
>>>>
>>>> You mean I should fix-up the patch to fit to the new binding
>>>> description? Or do you mean it should be MTxxxx instead of mtxxxx?
>>>>
>>>> Regards,
>>>> Matthias
>>>
>>> Dear Matthias,
>>>
>>> I mean fix-up the patch to fit to the new binding description. Is it OK?
>>>
>>
>> Then I can't see the difference between what you are asking for and what
>> is already pushed to the repository. Please send a patch, that will make
>> things clearer.
>>
>> Regards,
>> Matthias
>
> Dear Matthias,
>
> like this:
>
> diff:
> Required properties:
> - compatible: value should be either of the following.
> - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
> MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
> MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length
> of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
>
Please look at [2], this is already staged.
[2]
https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node
2017-06-14 9:24 ` Matthias Brugger
@ 2017-06-14 9:43 ` Jun Gao
0 siblings, 0 replies; 16+ messages in thread
From: Jun Gao @ 2017-06-14 9:43 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 2017-06-14 at 11:24 +0200, Matthias Brugger wrote:
>
> On 14/06/17 03:11, Jun Gao wrote:
> > On Tue, 2017-06-13 at 15:45 +0200, Matthias Brugger wrote:
> >>
> >> On 13/06/17 15:23, Jun Gao wrote:
> >>> On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote:
> >>>>
> >>>> On 13/06/17 12:24, Jun Gao wrote:
> >>>>> On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote:
> >>>>>>
> >>>>>> On 12/06/17 13:54, Jun Gao wrote:
> >>>>>>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote:
> >>>>>>>> From: Jun Gao <jun.gao@mediatek.com>
> >>>>>>>>
> >>>>>>>> Add MT2701 i2c device node.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> >>>>>>>> ---
> >>>>>>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++
> >>>>>>>> 2 files changed, 84 insertions(+)
> >>>>>> [...]
> >>>>>>>
> >>>>>>> Dear Matthias,
> >>>>>>>
> >>>>>>> Could you take this patch together with
> >>>>>>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ?
> >>>>>>>
> >>>>>>> Thanks!
> >>>>>>>
> >>>>>>
> >>>>>> They are both included in the pull request I send [1] [2], or do I miss
> >>>>>> something?
> >>>>>>
> >>>>>> Regards,
> >>>>>> Matthias
> >>>>>>
> >>>>>> [1]
> >>>>>> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2
> >>>>>> [2]
> >>>>>> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
> >>>>>
> >>>>> Dear Matthias,
> >>>>>
> >>>>> Would you mind to use the same style as follows in i2c-mtk.txt of [2]?
> >>>>>
> >>>>> "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> >>>>> "mediatek,mt6577-i2c": for Mediatek MT6577
> >>>>> "mediatek,mt6589-i2c": for Mediatek MT6589
> >>>>> "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> >>>>> "mediatek,mt8173-i2c": for Mediatek MT8173
> >>>>>
> >>>>>
> >>>>> Thanks!
> >>>>>
> >>>>
> >>>> You mean I should fix-up the patch to fit to the new binding
> >>>> description? Or do you mean it should be MTxxxx instead of mtxxxx?
> >>>>
> >>>> Regards,
> >>>> Matthias
> >>>
> >>> Dear Matthias,
> >>>
> >>> I mean fix-up the patch to fit to the new binding description. Is it OK?
> >>>
> >>
> >> Then I can't see the difference between what you are asking for and what
> >> is already pushed to the repository. Please send a patch, that will make
> >> things clearer.
> >>
> >> Regards,
> >> Matthias
> >
> > Dear Matthias,
> >
> > like this:
> >
> > diff:
> > Required properties:
> > - compatible: value should be either of the following.
> > - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> > - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> > - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> > - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> > - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek
> > MT2701
> > + "mediatek,mt6577-i2c": for Mediatek MT6577
> > + "mediatek,mt6589-i2c": for Mediatek MT6589
> > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek
> > MT7623
> > + "mediatek,mt8173-i2c": for Mediatek MT8173
> > - reg: physical base address of the controller and dma base, length
> > of memory
> > mapped region.
> > - interrupts: interrupt number to the cpu.
> >
>
> Please look at [2], this is already staged.
>
> [2]
> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1
Dear Matthias,
base on [2]
diff:
"mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577 i2c.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589 i2c.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with
mt7623 i2c.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173 i2c.
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
Thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-06-14 9:43 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 7:35 [PATCH v4 0/2] Add i2c dt-binding and device node for Mediatek MT2701 Soc Jun Gao
2017-05-26 7:35 ` [PATCH v4 1/2] dt-bindings: i2c: Add Mediatek MT2701 i2c binding Jun Gao
2017-05-29 15:30 ` Matthias Brugger
2017-05-30 21:38 ` Rob Herring
2017-05-31 2:24 ` Jun Gao
2017-05-31 12:05 ` Matthias Brugger
2017-05-26 7:35 ` [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node Jun Gao
2017-06-12 11:54 ` Jun Gao
2017-06-13 9:36 ` Matthias Brugger
2017-06-13 10:24 ` Jun Gao
2017-06-13 12:52 ` Matthias Brugger
2017-06-13 13:23 ` Jun Gao
2017-06-13 13:45 ` Matthias Brugger
2017-06-14 1:11 ` Jun Gao
2017-06-14 9:24 ` Matthias Brugger
2017-06-14 9:43 ` Jun Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).