From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ruben Ayrapetyan <ruben.ayrapetyan@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>,
dri-devel@lists.freedesktop.org,
Sudeep Holla <sudeep.holla@arm.com>,
Brian Starkey <brian.starkey@arm.com>
Subject: Re: [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth
Date: Thu, 25 Jul 2019 17:58:25 +0100 [thread overview]
Message-ID: <1d7929a2-273e-e695-6700-36aacf38f61a@arm.com> (raw)
In-Reply-To: <042d5c3d-96fe-5466-3869-a0a3a08b964d@arm.com>
On 25/07/2019 16:15, Robin Murphy wrote:
> Hi Kevin,
Hi Robin,
> On 25/07/2019 15:50, Kevin Brodsky wrote:
>> It may be desirable on certain platforms, such as Android, to
>> use 32bpp buffers. Since there is no clear bandwidth limit for the
>> CLCD component on the fast model, let's increase
>> max-memory-bandwidth to allow using 32bpp buffers.
> Given that the property is optional anyway, would it hurt to just remove
> it? After trying to dig up any relevant internal email history, it's
> still far from clear how and why it got here in the first place.
Very good point, I hadn't realised it was an optional property. Removing it
completely seems to work fine. I'll send a v2 removing it from both fvp-base-revc.dts
and rtsm_ve-motherboard.dtsi. Thanks!
Kevin
> Robin.
>
>> Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com>
>> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
>> ---
>> arch/arm64/boot/dts/arm/fvp-base-revc.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
>> index 687707020ec1..3aee49ed6d88 100644
>> --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
>> +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
>> @@ -269,7 +269,7 @@
>> motherboard {
>> iofpga@3,00000000 {
>> clcd@1f0000 {
>> - max-memory-bandwidth = <130000000>; /* 16bpp @ 63.5MHz */
>> + max-memory-bandwidth = <260000000>; /* 32bpp @ 63.5MHz */
>> };
>> };
>> };
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-25 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 14:50 [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth Kevin Brodsky
2019-07-25 15:15 ` Robin Murphy
2019-07-25 16:58 ` Kevin Brodsky [this message]
2019-08-05 10:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d7929a2-273e-e695-6700-36aacf38f61a@arm.com \
--to=kevin.brodsky@arm.com \
--cc=brian.starkey@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=liviu.dudau@arm.com \
--cc=pawel.moll@arm.com \
--cc=robin.murphy@arm.com \
--cc=ruben.ayrapetyan@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).