* [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth
@ 2019-07-25 14:50 Kevin Brodsky
2019-07-25 15:15 ` Robin Murphy
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Brodsky @ 2019-07-25 14:50 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Pawel Moll, Ruben Ayrapetyan, Linus Walleij,
Kevin Brodsky, Liviu Dudau, dri-devel, Sudeep Holla,
Brian Starkey
It may be desirable on certain platforms, such as Android, to
use 32bpp buffers. Since there is no clear bandwidth limit for the
CLCD component on the fast model, let's increase
max-memory-bandwidth to allow using 32bpp buffers.
Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com>
Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
---
arch/arm64/boot/dts/arm/fvp-base-revc.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
index 687707020ec1..3aee49ed6d88 100644
--- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
+++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
@@ -269,7 +269,7 @@
motherboard {
iofpga@3,00000000 {
clcd@1f0000 {
- max-memory-bandwidth = <130000000>; /* 16bpp @ 63.5MHz */
+ max-memory-bandwidth = <260000000>; /* 32bpp @ 63.5MHz */
};
};
};
--
2.22.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth
2019-07-25 14:50 [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth Kevin Brodsky
@ 2019-07-25 15:15 ` Robin Murphy
2019-07-25 16:58 ` Kevin Brodsky
2019-08-05 10:18 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Robin Murphy @ 2019-07-25 15:15 UTC (permalink / raw)
To: Kevin Brodsky, linux-arm-kernel
Cc: devicetree, Pawel Moll, Ruben Ayrapetyan, Linus Walleij,
Liviu Dudau, dri-devel, Sudeep Holla, Brian Starkey
Hi Kevin,
On 25/07/2019 15:50, Kevin Brodsky wrote:
> It may be desirable on certain platforms, such as Android, to
> use 32bpp buffers. Since there is no clear bandwidth limit for the
> CLCD component on the fast model, let's increase
> max-memory-bandwidth to allow using 32bpp buffers.
Given that the property is optional anyway, would it hurt to just remove
it? After trying to dig up any relevant internal email history, it's
still far from clear how and why it got here in the first place.
Robin.
> Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
> ---
> arch/arm64/boot/dts/arm/fvp-base-revc.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> index 687707020ec1..3aee49ed6d88 100644
> --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> @@ -269,7 +269,7 @@
> motherboard {
> iofpga@3,00000000 {
> clcd@1f0000 {
> - max-memory-bandwidth = <130000000>; /* 16bpp @ 63.5MHz */
> + max-memory-bandwidth = <260000000>; /* 32bpp @ 63.5MHz */
> };
> };
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth
2019-07-25 15:15 ` Robin Murphy
@ 2019-07-25 16:58 ` Kevin Brodsky
2019-08-05 10:18 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Brodsky @ 2019-07-25 16:58 UTC (permalink / raw)
To: Robin Murphy, linux-arm-kernel
Cc: devicetree, Pawel Moll, Ruben Ayrapetyan, Linus Walleij,
Liviu Dudau, dri-devel, Sudeep Holla, Brian Starkey
On 25/07/2019 16:15, Robin Murphy wrote:
> Hi Kevin,
Hi Robin,
> On 25/07/2019 15:50, Kevin Brodsky wrote:
>> It may be desirable on certain platforms, such as Android, to
>> use 32bpp buffers. Since there is no clear bandwidth limit for the
>> CLCD component on the fast model, let's increase
>> max-memory-bandwidth to allow using 32bpp buffers.
> Given that the property is optional anyway, would it hurt to just remove
> it? After trying to dig up any relevant internal email history, it's
> still far from clear how and why it got here in the first place.
Very good point, I hadn't realised it was an optional property. Removing it
completely seems to work fine. I'll send a v2 removing it from both fvp-base-revc.dts
and rtsm_ve-motherboard.dtsi. Thanks!
Kevin
> Robin.
>
>> Reported-by: Ruben Ayrapetyan <ruben.ayrapetyan@arm.com>
>> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
>> ---
>> arch/arm64/boot/dts/arm/fvp-base-revc.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
>> index 687707020ec1..3aee49ed6d88 100644
>> --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
>> +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
>> @@ -269,7 +269,7 @@
>> motherboard {
>> iofpga@3,00000000 {
>> clcd@1f0000 {
>> - max-memory-bandwidth = <130000000>; /* 16bpp @ 63.5MHz */
>> + max-memory-bandwidth = <260000000>; /* 32bpp @ 63.5MHz */
>> };
>> };
>> };
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth
2019-07-25 15:15 ` Robin Murphy
2019-07-25 16:58 ` Kevin Brodsky
@ 2019-08-05 10:18 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-08-05 10:18 UTC (permalink / raw)
To: Robin Murphy
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Pawel Moll, Ruben Ayrapetyan, Kevin Brodsky, Liviu Dudau,
open list:DRM PANEL DRIVERS, Sudeep Holla, Brian Starkey,
Linux ARM
On Thu, Jul 25, 2019 at 5:15 PM Robin Murphy <robin.murphy@arm.com> wrote:
> Given that the property is optional anyway, would it hurt to just remove
> it? After trying to dig up any relevant internal email history, it's
> still far from clear how and why it got here in the first place.
Isn't it just my sloppy copy-paste when fixing up the device trees
for the DRM transition? I agree it should just be removed.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-05 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 14:50 [PATCH] arm64: dts: fast models: Increase clcd's max-memory-bandwidth Kevin Brodsky
2019-07-25 15:15 ` Robin Murphy
2019-07-25 16:58 ` Kevin Brodsky
2019-08-05 10:18 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).