From: John Garry <john.garry@huawei.com>
To: Qi Liu <liuqi115@huawei.com>, "will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
Zhangshaokun <zhangshaokun@hisilicon.com>
Subject: Re: [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU aliasing
Date: Mon, 14 Feb 2022 12:04:25 +0000 [thread overview]
Message-ID: <1da1252e-59d0-77d1-0419-242528739392@huawei.com> (raw)
In-Reply-To: <20220214114228.40859-3-liuqi115@huawei.com>
On 14/02/2022 11:42, Qi Liu wrote:
> Add support for HiSilicon CPA PMU aliasing.
>
> The kernel driver is in drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
>
> Signed-off-by: Qi Liu<liuqi115@huawei.com>
You realy should cc the perf tool list and maintainers there also.
Reviewed-by: John Garry <john.garry@huawei.com>
> + },
> + {
> + "MetricExpr": "(p0_wr_dat * 64 + p0_rd_dat_64b * 64 + p0_rd_dat_32b * 32) / cpa_cycles",
> + "BriefDescription": "Average bandwidth of CPA Port 0",
> + "MetricGroup": "CPA",
nit: maybe this should have a more distrinct name
> + "MetricName": "p0_avg_bw",
> + "Compat": "0x00000030",
JFYI, I have a rewrite of the perf tool system pmu metric support that
will not require us to add the compat here.
> + "Unit": "hisi_sicl,cpa"
Thanks,
John
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-14 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 11:42 [PATCH 0/2] Add Support for HiSilicon CPA PMU Qi Liu
2022-02-14 11:42 ` [PATCH 1/2] drivers/perf: hisi: Add Support for " Qi Liu
2022-02-15 10:47 ` John Garry
2022-02-16 3:16 ` liuqi (BA)
2022-02-17 18:11 ` John Garry
2022-02-18 8:07 ` liuqi (BA)
2022-02-14 11:42 ` [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU aliasing Qi Liu
2022-02-14 12:04 ` John Garry [this message]
2022-02-15 1:27 ` liuqi (BA)
2022-02-15 1:23 ` liuqi (BA)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da1252e-59d0-77d1-0419-242528739392@huawei.com \
--to=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).