linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] omap: zoom: host should not pull up wl1271's irq line
@ 2011-03-14 14:24 Ohad Ben-Cohen
  2011-03-14 18:12 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Ohad Ben-Cohen @ 2011-03-14 14:24 UTC (permalink / raw)
  To: linux-arm-kernel

The wl1271's irq line is completely controlled by the 1271 device, and
the host does not not need to pull it up.

While there's no functional effect, letting the host pull this line up is
just redundant, and wastes power.

Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
 arch/arm/mach-omap2/board-zoom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-zoom.c b/arch/arm/mach-omap2/board-zoom.c
index e26754c..c59d07b 100644
--- a/arch/arm/mach-omap2/board-zoom.c
+++ b/arch/arm/mach-omap2/board-zoom.c
@@ -49,7 +49,7 @@ static void __init omap_zoom_init_irq(void)
 #ifdef CONFIG_OMAP_MUX
 static struct omap_board_mux board_mux[] __initdata = {
 	/* WLAN IRQ - GPIO 162 */
-	OMAP3_MUX(MCBSP1_CLKX, OMAP_MUX_MODE4 | OMAP_PIN_INPUT_PULLUP),
+	OMAP3_MUX(MCBSP1_CLKX, OMAP_MUX_MODE4 | OMAP_PIN_INPUT),
 	/* WLAN POWER ENABLE - GPIO 101 */
 	OMAP3_MUX(CAM_D2, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
 	/* WLAN SDIO: MMC3 CMD */
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] omap: zoom: host should not pull up wl1271's irq line
  2011-03-14 14:24 [PATCH] omap: zoom: host should not pull up wl1271's irq line Ohad Ben-Cohen
@ 2011-03-14 18:12 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2011-03-14 18:12 UTC (permalink / raw)
  To: linux-arm-kernel

* Ohad Ben-Cohen <ohad@wizery.com> [110314 07:29]:
> The wl1271's irq line is completely controlled by the 1271 device, and
> the host does not not need to pull it up.
> 
> While there's no functional effect, letting the host pull this line up is
> just redundant, and wastes power.

Applying.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-14 18:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-14 14:24 [PATCH] omap: zoom: host should not pull up wl1271's irq line Ohad Ben-Cohen
2011-03-14 18:12 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).