* [PATCH 1/8] omap3evm: Enable regulators for camera interface
@ 2011-09-08 13:33 Deepthy Ravi
2011-09-08 16:51 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Deepthy Ravi @ 2011-09-08 13:33 UTC (permalink / raw)
To: linux-arm-kernel
From: Vaibhav Hiremath <hvaibhav@ti.com>
Enabled 1v8 and 2v8 regulator output, which is being used by
camera module.
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com>
---
arch/arm/mach-omap2/board-omap3evm.c | 40 ++++++++++++++++++++++++++++++++++
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index a1184b3..8333ee4 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -273,6 +273,44 @@ static struct omap_dss_board_info omap3_evm_dss_data = {
.default_device = &omap3_evm_lcd_device,
};
+static struct regulator_consumer_supply omap3evm_vaux3_supply = {
+ .supply = "cam_1v8",
+};
+
+static struct regulator_consumer_supply omap3evm_vaux4_supply = {
+ .supply = "cam_2v8",
+};
+
+/* VAUX3 for CAM_1V8 */
+static struct regulator_init_data omap3evm_vaux3 = {
+ .constraints = {
+ .min_uV = 1800000,
+ .max_uV = 1800000,
+ .apply_uV = true,
+ .valid_modes_mask = REGULATOR_MODE_NORMAL
+ | REGULATOR_MODE_STANDBY,
+ .valid_ops_mask = REGULATOR_CHANGE_MODE
+ | REGULATOR_CHANGE_STATUS,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &omap3evm_vaux3_supply,
+};
+
+/* VAUX4 for CAM_2V8 */
+static struct regulator_init_data omap3evm_vaux4 = {
+ .constraints = {
+ .min_uV = 1800000,
+ .max_uV = 1800000,
+ .apply_uV = true,
+ .valid_modes_mask = REGULATOR_MODE_NORMAL
+ | REGULATOR_MODE_STANDBY,
+ .valid_ops_mask = REGULATOR_CHANGE_MODE
+ | REGULATOR_CHANGE_STATUS,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &omap3evm_vaux4_supply,
+};
+
static struct regulator_consumer_supply omap3evm_vmmc1_supply[] = {
REGULATOR_SUPPLY("vmmc", "omap_hsmmc.0"),
};
@@ -499,6 +537,8 @@ static struct twl4030_platform_data omap3evm_twldata = {
.vio = &omap3evm_vio,
.vmmc1 = &omap3evm_vmmc1,
.vsim = &omap3evm_vsim,
+ .vaux3 = &omap3evm_vaux3,
+ .vaux4 = &omap3evm_vaux4,
};
static int __init omap3_evm_i2c_init(void)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/8] omap3evm: Enable regulators for camera interface
2011-09-08 13:33 [PATCH 1/8] omap3evm: Enable regulators for camera interface Deepthy Ravi
@ 2011-09-08 16:51 ` Laurent Pinchart
2011-09-13 7:06 ` Ravi, Deepthy
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2011-09-08 16:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thursday 08 September 2011 15:33:51 Deepthy Ravi wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> Enabled 1v8 and 2v8 regulator output, which is being used by
> camera module.
Thanks for the patch. Just one minor comment below.
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com>
> ---
> arch/arm/mach-omap2/board-omap3evm.c | 40
> ++++++++++++++++++++++++++++++++++ 1 files changed, 40 insertions(+), 0
> deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c
> b/arch/arm/mach-omap2/board-omap3evm.c index a1184b3..8333ee4 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -273,6 +273,44 @@ static struct omap_dss_board_info omap3_evm_dss_data =
> { .default_device = &omap3_evm_lcd_device,
> };
>
> +static struct regulator_consumer_supply omap3evm_vaux3_supply = {
> + .supply = "cam_1v8",
> +};
> +
> +static struct regulator_consumer_supply omap3evm_vaux4_supply = {
> + .supply = "cam_2v8",
> +};
> +
> +/* VAUX3 for CAM_1V8 */
> +static struct regulator_init_data omap3evm_vaux3 = {
> + .constraints = {
> + .min_uV = 1800000,
> + .max_uV = 1800000,
> + .apply_uV = true,
> + .valid_modes_mask = REGULATOR_MODE_NORMAL
> + | REGULATOR_MODE_STANDBY,
> + .valid_ops_mask = REGULATOR_CHANGE_MODE
> + | REGULATOR_CHANGE_STATUS,
> + },
> + .num_consumer_supplies = 1,
> + .consumer_supplies = &omap3evm_vaux3_supply,
I might be wrong, but I think we're standardizing on using REGULATOR_SUPPLY
arrays as described in commit 786b01a8c1db0c0decca55d660a2a3ebd7cfb26b
("cleanup regulator supply definitions in mach-omap2").
> +};
> +
> +/* VAUX4 for CAM_2V8 */
> +static struct regulator_init_data omap3evm_vaux4 = {
> + .constraints = {
> + .min_uV = 1800000,
> + .max_uV = 1800000,
> + .apply_uV = true,
> + .valid_modes_mask = REGULATOR_MODE_NORMAL
> + | REGULATOR_MODE_STANDBY,
> + .valid_ops_mask = REGULATOR_CHANGE_MODE
> + | REGULATOR_CHANGE_STATUS,
> + },
> + .num_consumer_supplies = 1,
> + .consumer_supplies = &omap3evm_vaux4_supply,
> +};
> +
> static struct regulator_consumer_supply omap3evm_vmmc1_supply[] = {
> REGULATOR_SUPPLY("vmmc", "omap_hsmmc.0"),
> };
> @@ -499,6 +537,8 @@ static struct twl4030_platform_data omap3evm_twldata =
> { .vio = &omap3evm_vio,
> .vmmc1 = &omap3evm_vmmc1,
> .vsim = &omap3evm_vsim,
> + .vaux3 = &omap3evm_vaux3,
> + .vaux4 = &omap3evm_vaux4,
> };
>
> static int __init omap3_evm_i2c_init(void)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/8] omap3evm: Enable regulators for camera interface
2011-09-08 16:51 ` Laurent Pinchart
@ 2011-09-13 7:06 ` Ravi, Deepthy
0 siblings, 0 replies; 3+ messages in thread
From: Ravi, Deepthy @ 2011-09-13 7:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
> ________________________________________
> From: Laurent Pinchart [laurent.pinchart at ideasonboard.com]
> Sent: Thursday, September 08, 2011 10:21 PM
> To: Ravi, Deepthy
> Cc: linux-omap at vger.kernel.org; tony at atomide.com; linux at arm.linux.org.uk; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; mchehab at infradead.org; linux-media at vger.kernel.org; g.liakhovetski at gmx.de; Hiremath, Vaibhav
> Subject: Re: [PATCH 1/8] omap3evm: Enable regulators for camera interface
>
> Hi,
>
> On Thursday 08 September 2011 15:33:51 Deepthy Ravi wrote:
>> From: Vaibhav Hiremath <hvaibhav@ti.com>
>>
>> Enabled 1v8 and 2v8 regulator output, which is being used by
>> camera module.
>
> Thanks for the patch. Just one minor comment below.
>
>> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>> Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com>
>> ---
>> arch/arm/mach-omap2/board-omap3evm.c | 40
>> ++++++++++++++++++++++++++++++++++ 1 files changed, 40 insertions(+), 0
>> deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap3evm.c
>> b/arch/arm/mach-omap2/board-omap3evm.c index a1184b3..8333ee4 100644
>> --- a/arch/arm/mach-omap2/board-omap3evm.c
>> +++ b/arch/arm/mach-omap2/board-omap3evm.c
>> @@ -273,6 +273,44 @@ static struct omap_dss_board_info omap3_evm_dss_data =
>> { .default_device = &omap3_evm_lcd_device,
>> };
>>
>> +static struct regulator_consumer_supply omap3evm_vaux3_supply = {
>> + .supply = "cam_1v8",
>> +};
>> +
>> +static struct regulator_consumer_supply omap3evm_vaux4_supply = {
>> + .supply = "cam_2v8",
>> +};
>> +
>> +/* VAUX3 for CAM_1V8 */
>> +static struct regulator_init_data omap3evm_vaux3 = {
>> + .constraints = {
>> + .min_uV = 1800000,
>> + .max_uV = 1800000,
>> + .apply_uV = true,
>> + .valid_modes_mask = REGULATOR_MODE_NORMAL
>> + | REGULATOR_MODE_STANDBY,
>> + .valid_ops_mask = REGULATOR_CHANGE_MODE
>> + | REGULATOR_CHANGE_STATUS,
>> + },
>> + .num_consumer_supplies = 1,
>> + .consumer_supplies = &omap3evm_vaux3_supply,
>
> I might be wrong, but I think we're standardizing on using REGULATOR_SUPPLY
> arrays as described in commit 786b01a8c1db0c0decca55d660a2a3ebd7cfb26b
> ("cleanup regulator supply definitions in mach-omap2").
>
[Deepthy Ravi] Yes, you are right. I will modify it.
>> +};
>> +
>> +/* VAUX4 for CAM_2V8 */
>> +static struct regulator_init_data omap3evm_vaux4 = {
>> + .constraints = {
>> + .min_uV = 1800000,
>> + .max_uV = 1800000,
>> + .apply_uV = true,
>> + .valid_modes_mask = REGULATOR_MODE_NORMAL
>> + | REGULATOR_MODE_STANDBY,
>> + .valid_ops_mask = REGULATOR_CHANGE_MODE
>> + | REGULATOR_CHANGE_STATUS,
>> + },
>> + .num_consumer_supplies = 1,
>> + .consumer_supplies = &omap3evm_vaux4_supply,
>> +};
>> +
>> static struct regulator_consumer_supply omap3evm_vmmc1_supply[] = {
>> REGULATOR_SUPPLY("vmmc", "omap_hsmmc.0"),
>> };
>> @@ -499,6 +537,8 @@ static struct twl4030_platform_data omap3evm_twldata =
>> { .vio = &omap3evm_vio,
>> .vmmc1 = &omap3evm_vmmc1,
>> .vsim = &omap3evm_vsim,
>> + .vaux3 = &omap3evm_vaux3,
>> + .vaux4 = &omap3evm_vaux4,
>> };
>>
>> static int __init omap3_evm_i2c_init(void)
>
> --
> Regards,
>
> Laurent Pinchart
>
Thanks,
Deepthy Ravi.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-13 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-08 13:33 [PATCH 1/8] omap3evm: Enable regulators for camera interface Deepthy Ravi
2011-09-08 16:51 ` Laurent Pinchart
2011-09-13 7:06 ` Ravi, Deepthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).