From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] net/smsc911x: add device tree probe support
Date: Fri, 9 Sep 2011 09:50:30 +0100 [thread overview]
Message-ID: <20110909085030.GA3069@arm.com> (raw)
In-Reply-To: <20110908182920.GL2967@ponder.secretlab.ca>
On Thu, Sep 08, 2011 at 11:29:20AM -0700, Grant Likely wrote:
> On Thu, Sep 08, 2011 at 03:59:46PM +0100, Dave Martin wrote:
> > Hi Shawn,
> >
> > On Sun, Jul 31, 2011 at 02:26:00AM +0800, Shawn Guo wrote:
> > > It adds device tree probe support for smsc911x driver.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: Grant Likely <grant.likely@secretlab.ca>
> > > Cc: Steve Glendinning <steve.glendinning@smsc.com>
> > > Cc: David S. Miller <davem@davemloft.net>
> > > Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
> > > ---
> > > Changes since v2:
> > > * Fix a typo in smsc911x.txt
> > >
> > > Changes since v1:
> > > * Instead of getting irq line from gpio number, it use irq domain
> > > to keep platform_get_resource(IORESOURCE_IRQ) works for dt too.
> > > * Use 'lan9115' the first model that smsc911x supports in the match
> > > table
> > > * Use reg-shift and reg-io-width which already used in of_serial for
> > > shift and access size binding
> >
> > When using this patch with vexpress, I found that 16-bit register access
> > mode doesn't seem to be getting set correctly.
> >
> > Can you take a look at this additional patch and let me know if it looks
> > correct?
> >
> > Cheers
> > ---Dave
> >
> > From: Dave Martin <dave.martin@linaro.org>
> > Date: Wed, 7 Sep 2011 17:26:31 +0100
> > Subject: [PATCH] net/smsc911x: Correctly configure 16-bit register access from DT
> >
> > The SMSC911X_USE_16BIT needs to be set when using 16-bit register
> > access. However, currently no flag is set if the DT doesn't specify
> > 32-bit access.
> >
> > This patch should set the SMSC911X_USE_16BIT flag in a manner consistent
> > with the documented DT bindings.
> >
> > Signed-off-by: Dave Martin <dave.martin@linaro.org>
> > ---
> > drivers/net/smsc911x.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
> > index 75c08a5..1a35c25 100644
> > --- a/drivers/net/smsc911x.c
> > +++ b/drivers/net/smsc911x.c
> > @@ -2121,6 +2121,8 @@ static int __devinit smsc911x_probe_config_dt(
> > of_property_read_u32(np, "reg-io-width", &width);
> > if (width == 4)
> > config->flags |= SMSC911X_USE_32BIT;
> > + else
> > + config->flags |= SMSC911X_USE_16BIT;
>
> Would it be better to do "else if (width == 2)"? (completely
> uninformed comment. I've not looked at what the non-DT probe path
> does on this driver.)
I wouldn't have a problem with that. But currently the binding
documentation says that any value other than 4, or a missing property,
implies 16-bit register access.
So the binding documentation would need to change too in that case.
Personally I think this would be better, but it's just an opinion.
Cheers
---Dave
next prev parent reply other threads:[~2011-09-09 8:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 9:44 [PATCH] net/smsc911x: add device tree probe support Shawn Guo
2011-07-25 21:37 ` Grant Likely
2011-07-26 1:01 ` Shawn Guo
2011-07-26 1:16 ` Nicolas Pitre
2011-07-26 1:30 ` Shawn Guo
2011-07-26 2:28 ` Nicolas Pitre
2011-07-29 2:36 ` Shawn Guo
2011-07-29 15:47 ` Grant Likely
2011-07-29 16:03 ` Shawn Guo
2011-07-29 16:26 ` Grant Likely
2011-07-29 17:13 ` Shawn Guo
2011-07-31 0:42 ` Grant Likely
2011-07-29 15:45 ` Grant Likely
2011-07-29 8:43 ` [PATCH v2] " Shawn Guo
2011-07-29 15:53 ` Grant Likely
2011-07-29 16:16 ` Shawn Guo
2011-07-30 18:26 ` [PATCH v3] " Shawn Guo
2011-08-02 1:01 ` David Miller
2011-09-08 14:59 ` Dave Martin
2011-09-08 18:29 ` Grant Likely
2011-09-09 8:50 ` Dave Martin [this message]
2011-09-09 12:59 ` Shawn Guo
2011-09-09 11:48 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909085030.GA3069@arm.com \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).