From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: 3.9-rc1 regression in arm dtb build
Date: Thu, 7 Mar 2013 15:45:07 +0100 [thread overview]
Message-ID: <20130307144506.GB7344@amd.pavel.ucw.cz> (raw)
In-Reply-To: <5137C404.9060902@wwwdotorg.org>
Hi!
> > commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
> > Author: Grant Likely <grant.likely@secretlab.ca>
> > Date: Tue Nov 27 16:29:11 2012 -0700
...
> > 1) it is inconsistent with 3.8, making switching between 3.9-rc1 and
> > 3.8 tricky
>
> It's pretty easy to locate the DTB by automatically looking in
> arch/*/boot/dts first, then if the file doesn't exist there, looking in
> arch/*/boot instead as a legacy fallback.
Unfortunately, that does not work. See 2) below. Stale files even
survive "make clean".
3.9-rc1:
[pavel at pollux linux]$ ls -al arch/arm/boot/dts/socfpga_cyclone5.dtb
-rw-rw-r-- 1 pavel pavel 3335 Mar 6 14:55
arch/arm/boot/dts/socfpga_cyclone5.dtb
[pavel at pollux linux]$ cp arch/arm/boot/dts/socfpga_cyclone5.dtb
arch/arm/boot/socfpga_cyclone5.dtb
[pavel at pollux linux]$ ls -al arch/arm/boot/socfpga_cyclone5.dtb
-rw-rw-r-- 1 pavel pavel 3335 Mar 7 15:41
arch/arm/boot/socfpga_cyclone5.dtb
[pavel at pollux linux]$ make clean
CLEAN .
CLEAN drivers/tty/vt
CLEAN kernel
CLEAN lib
CLEAN .tmp_versions
[pavel at pollux linux]$ ls -al arch/arm/boot/socfpga_cyclone5.dtb
-rw-rw-r-- 1 pavel pavel 3335 Mar 7 15:41
arch/arm/boot/socfpga_cyclone5.dtb
[pavel at pollux linux]$ make socfpga_cyclone5.dtb
> > 2) what is worse, it is very easy to do stuff like
> >
> > make socfpga_cyclone5.dtb
> >
> > and you end up with success, but stale file in arch/arm/boot, where
> > your scripts expect it.
> >
> > (There are some attempts to rm stale files in Makefiles; they don't
> > work in above case).
>
> I guess moving the rm into cmd_dtc rather than the "dtbs" rule would
> solve that.
Yep, I guess something like that should be done.
> > 3) it is now incosistent between powerpc and arm.
>
> True. PPC's DTB-handling is a little more complex than most, so wasn't
> converted along with this patch. It'd be nice to finish the conversion
> and make PPC pick up this change too.
Why break people's build scripts? What is the advantage? Having
binaries in same directory... ok but not worth the breakage.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-03-07 14:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 19:33 3.9-rc1 regression in arm dtb build Pavel Machek
2013-03-06 19:45 ` Thomas Petazzoni
2013-03-07 14:39 ` Pavel Machek
2013-03-06 22:32 ` Stephen Warren
2013-03-07 14:45 ` Pavel Machek [this message]
2013-03-07 20:50 ` Stephen Warren
2013-03-11 5:05 ` Olof Johansson
2013-03-11 10:56 ` Pavel Machek
2013-03-11 11:00 ` Grant Likely
2013-03-28 9:29 ` Pavel Machek
2013-03-28 14:49 ` Stephen Warren
2013-03-28 19:33 ` Pavel Machek
2013-03-28 19:54 ` Olof Johansson
2013-03-29 17:05 ` Stephen Warren
2013-03-29 18:47 ` Pavel Machek
2013-03-29 19:41 ` Olof Johansson
2013-03-29 22:18 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307144506.GB7344@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).