From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: 3.9-rc1 regression in arm dtb build
Date: Wed, 06 Mar 2013 15:32:36 -0700 [thread overview]
Message-ID: <5137C404.9060902@wwwdotorg.org> (raw)
In-Reply-To: <20130306193332.GA6022@amd.pavel.ucw.cz>
On 03/06/2013 12:33 PM, Pavel Machek wrote:
> Hi!
>
> Commit
>
> commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
> Author: Grant Likely <grant.likely@secretlab.ca>
> Date: Tue Nov 27 16:29:11 2012 -0700
>
> The current rules have the .dtb files build in a different
> directory
> from the .dts files. The only reason for this is that it was what
> PowerPC has done historically. This patch changes ARM to use the
> generic dtb rule which builds .dtb files in the same directory as the
> source .dts.
>
> --
>
> Moves dtb files from arch/arm/boot/ to arch/arm/boot/dtb. That causes
> several problems:
>
> 1) it is inconsistent with 3.8, making switching between 3.9-rc1 and
> 3.8 tricky
It's pretty easy to locate the DTB by automatically looking in
arch/*/boot/dts first, then if the file doesn't exist there, looking in
arch/*/boot instead as a legacy fallback.
> 2) what is worse, it is very easy to do stuff like
>
> make socfpga_cyclone5.dtb
>
> and you end up with success, but stale file in arch/arm/boot, where
> your scripts expect it.
>
> (There are some attempts to rm stale files in Makefiles; they don't
> work in above case).
I guess moving the rm into cmd_dtc rather than the "dtbs" rule would
solve that.
> 3) it is now incosistent between powerpc and arm.
True. PPC's DTB-handling is a little more complex than most, so wasn't
converted along with this patch. It'd be nice to finish the conversion
and make PPC pick up this change too.
> 4) device tree _binary_ files are now output in device tree _source_
> directory
Isn't that true for almost all object files? One of the motivators for
the move was that binaries were being built in a different directory to
the source, which is quite odd.
> (Sorry for noticing this earlier).
>
> I believe the commit should be simply reverted. Reasons to move dtbs
> around are not good enough.
> Pavel
>
next prev parent reply other threads:[~2013-03-06 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 19:33 3.9-rc1 regression in arm dtb build Pavel Machek
2013-03-06 19:45 ` Thomas Petazzoni
2013-03-07 14:39 ` Pavel Machek
2013-03-06 22:32 ` Stephen Warren [this message]
2013-03-07 14:45 ` Pavel Machek
2013-03-07 20:50 ` Stephen Warren
2013-03-11 5:05 ` Olof Johansson
2013-03-11 10:56 ` Pavel Machek
2013-03-11 11:00 ` Grant Likely
2013-03-28 9:29 ` Pavel Machek
2013-03-28 14:49 ` Stephen Warren
2013-03-28 19:33 ` Pavel Machek
2013-03-28 19:54 ` Olof Johansson
2013-03-29 17:05 ` Stephen Warren
2013-03-29 18:47 ` Pavel Machek
2013-03-29 19:41 ` Olof Johansson
2013-03-29 22:18 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137C404.9060902@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).