linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: Dove: add RTC device node
@ 2013-03-08 11:13 Jean-Francois Moine
  2013-03-08 20:53 ` Sergei Shtylyov
  2013-03-08 21:58 ` Jason Cooper
  0 siblings, 2 replies; 5+ messages in thread
From: Jean-Francois Moine @ 2013-03-08 11:13 UTC (permalink / raw)
  To: linux-arm-kernel

The commit 48be9ac930086f removed the RTC initialization.
This patch re-enables the RTC via the DT.

Signed-off-by: Jean-Fran?ois Moine <moinejf@free.fr>
---
 arch/arm/boot/dts/dove.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 46afade..28ff4dc 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -197,6 +197,11 @@
 			status = "disabled";
 		};
 
+		rtc at d8500 {
+			compatible = "marvell,orion-rtc";
+			reg = <0xd8500 0x20>;
+		};
+
 		crypto: crypto at 30000 {
 			compatible = "marvell,orion-crypto";
 			reg = <0x30000 0x10000>,


-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: Dove: add RTC device node
  2013-03-08 11:13 [PATCH] ARM: Dove: add RTC device node Jean-Francois Moine
@ 2013-03-08 20:53 ` Sergei Shtylyov
  2013-03-08 21:58 ` Jason Cooper
  1 sibling, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2013-03-08 20:53 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 08-03-2013 15:13, Jean-Francois Moine wrote:

> The commit 48be9ac930086f

    Please also specify the summary line for that commit in parens (or however 
you like).

> removed the RTC initialization.
> This patch re-enables the RTC via the DT.

> Signed-off-by: Jean-Fran?ois Moine <moinejf@free.fr>

WBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: Dove: add RTC device node
  2013-03-08 11:13 [PATCH] ARM: Dove: add RTC device node Jean-Francois Moine
  2013-03-08 20:53 ` Sergei Shtylyov
@ 2013-03-08 21:58 ` Jason Cooper
  2013-03-08 23:12   ` Arnd Bergmann
  1 sibling, 1 reply; 5+ messages in thread
From: Jason Cooper @ 2013-03-08 21:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Mar 08, 2013 at 12:13:17PM +0100, Jean-Francois Moine wrote:
> The commit 48be9ac930086f removed the RTC initialization.
> This patch re-enables the RTC via the DT.
> 
> Signed-off-by: Jean-Fran?ois Moine <moinejf@free.fr>
> ---
>  arch/arm/boot/dts/dove.dtsi |    5 +++++
>  1 file changed, 5 insertions(+)

Applied to mvebu/fixes with the following commit entry:

    ARM: Dove: add RTC device node

    The commit:

      48be9ac ARM: Dove: split legacy and DT setup

    removed the RTC initialization.  This patch re-enables the RTC
    via the DT.


thx,

Jason.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: Dove: add RTC device node
  2013-03-08 21:58 ` Jason Cooper
@ 2013-03-08 23:12   ` Arnd Bergmann
  2013-03-09  3:12     ` Jason Cooper
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2013-03-08 23:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 08 March 2013, Jason Cooper wrote:
> Applied to mvebu/fixes with the following commit entry:
> 
>     ARM: Dove: add RTC device node
> 
>     The commit:
> 
>       48be9ac ARM: Dove: split legacy and DT setup
> 
>     removed the RTC initialization.  This patch re-enables the RTC
>     via the DT.

Looks good. FWIW, the style I tend to use is


|ARM: Dove: add RTC device node
|
|The commit 48be9ac "ARM: Dove: split legacy and DT setup" removed the RTC
|initialization.  This patch re-enables the RTC via the DT.

I don't think that there is a wide agreement on how to refer to other
patches yet, but I do a lot of regression fixes like that, so maybe I
can start a trend here.

	ARnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: Dove: add RTC device node
  2013-03-08 23:12   ` Arnd Bergmann
@ 2013-03-09  3:12     ` Jason Cooper
  0 siblings, 0 replies; 5+ messages in thread
From: Jason Cooper @ 2013-03-09  3:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Mar 08, 2013 at 11:12:02PM +0000, Arnd Bergmann wrote:
> On Friday 08 March 2013, Jason Cooper wrote:
> > Applied to mvebu/fixes with the following commit entry:
> > 
> >     ARM: Dove: add RTC device node
> > 
> >     The commit:
> > 
> >       48be9ac ARM: Dove: split legacy and DT setup
> > 
> >     removed the RTC initialization.  This patch re-enables the RTC
> >     via the DT.
> 
> Looks good. FWIW, the style I tend to use is
> 
> 
> |ARM: Dove: add RTC device node
> |
> |The commit 48be9ac "ARM: Dove: split legacy and DT setup" removed the RTC
> |initialization.  This patch re-enables the RTC via the DT.
> 
> I don't think that there is a wide agreement on how to refer to other
> patches yet, but I do a lot of regression fixes like that, so maybe I
> can start a trend here.

Looks good to me.  flows a bit better than what I had.  I'll use that
from now on for anything I come across.

thx,

Jason.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-03-09  3:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-08 11:13 [PATCH] ARM: Dove: add RTC device node Jean-Francois Moine
2013-03-08 20:53 ` Sergei Shtylyov
2013-03-08 21:58 ` Jason Cooper
2013-03-08 23:12   ` Arnd Bergmann
2013-03-09  3:12     ` Jason Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).