From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: Add support for NETGEAR ReadyNAS Duo v2 using DT
Date: Sun, 17 Mar 2013 21:50:47 +0100 [thread overview]
Message-ID: <20130317205047.GU21478@lunn.ch> (raw)
In-Reply-To: <8738vt3h11.fsf@natisbad.org>
Hi Arnaud
> +
> + thermal at 10078 {
> + compatible = "marvell,kirkwood-thermal";
> + reg = <0x10078 0x4>;
> + status = "okay";
> + };
This should not be needed. All 6282 have the thermal sensor, so the
kirkwood-6282.dtsi will contain this. For 3.9 we submitted the DT
change too late, so it did not make it in, but for 3.10 it should be
there.
> +void __init netgear_readynas_init(void)
> +{
> + u32 val;
> +
> + kirkwood_ge00_init(&netgear_readynas_ge00_data);
> + kirkwood_pcie_init(KW_PCIE0);
> +
> + /* USB 3.0 controller power on */
> + mdelay(3000);
> + val = readl(GPIO_HIGH_VIRT_BASE + 0x4);
> + writel(val & ~(0x1 << 14), GPIO_HIGH_VIRT_BASE + 0x4);
> + val = readl(GPIO_HIGH_VIRT_BASE);
> + writel(val | (0x1 << 14), GPIO_HIGH_VIRT_BASE);
As Jason said, you can use a fixed regulator, in DT. Something like:
regulators {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <0>;
usb_power: regulator at 1 {
compatible = "regulator-fixed";
reg = <1>;
regulator-name = "USB Power";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
enable-active-high;
regulator-always-on;
regulator-boot-on;
gpio = <&gpio0 14 0>;
};
};
Is the mdelay() really required?
Andrew
next prev parent reply other threads:[~2013-03-17 20:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 20:31 [PATCH] ARM: kirkwood: Add support for NETGEAR ReadyNAS Duo v2 using DT Arnaud Ebalard
2013-03-17 20:40 ` Jason Cooper
2013-03-17 20:50 ` Andrew Lunn [this message]
2013-03-17 21:23 ` Arnaud Ebalard
2013-03-18 23:10 ` Arnaud Ebalard
2013-03-18 23:44 ` Jason Cooper
2013-03-19 6:07 ` Andrew Lunn
2013-03-19 6:59 ` Arnaud Ebalard
2013-03-19 19:58 ` [PATCHv2] " Arnaud Ebalard
2013-03-19 21:16 ` Andrew Lunn
2013-03-19 21:50 ` Arnaud Ebalard
2013-03-19 22:28 ` [PATCHv3] " Arnaud Ebalard
2013-03-20 19:42 ` Andrew Lunn
2013-03-28 18:36 ` Jason Cooper
2013-03-28 20:08 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130317205047.GU21478@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).