From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: kirkwood: Add support for NETGEAR ReadyNAS Duo v2 using DT
Date: Tue, 19 Mar 2013 22:50:51 +0100 [thread overview]
Message-ID: <87d2uvcb44.fsf@natisbad.org> (raw)
In-Reply-To: <20130319211607.GE21478@lunn.ch> (Andrew Lunn's message of "Tue, 19 Mar 2013 22:16:07 +0100")
Hi,
Andrew Lunn <andrew@lunn.ch> writes:
> On Tue, Mar 19, 2013 at 08:58:22PM +0100, Arnaud Ebalard wrote:
>> Hi,
>>
>> Add support for NETGEAR ReadyNAS Duo v2 (Hardware specs available
>> here: http://natisbad.org/NAS/).
>
> Hi Arnaud
>
> Thats a nice description of the hardware. There is another device
> using the same power supply controller, the USI Topkick. A few of the
> maintainers have these, so there would be the possibility of
> cooperating on a driver. It does not seem that complex a device. The
> topkick also seems to do Wake-on-LAN using this controller. There was
> a patch added recently which may allow this to work, depending on the
> PHY.
Does not come as a surprise. Netgear's 2.6.31.8 kernel contains a lot of
the following:
This kernel which derived from kernel-2.6.31-topkick1281p2 used for
both Netgear DUOv3 and NV+v4. It is based on kernel 2.6.31.8 and
Marvell 5.1.3 patch. Specially the USB3.0 driver come from kernel
2.6.39.
Note: everything in it is marked DUOv3 even though the device is branded
Duo v2. Don't know why.
>> index 13482ea..511cd7d 100644
>> --- a/arch/arm/configs/kirkwood_defconfig
>> +++ b/arch/arm/configs/kirkwood_defconfig
>> @@ -35,6 +35,7 @@ CONFIG_MACH_NETSPACE_LITE_V2_DT=y
>> CONFIG_MACH_NETSPACE_MINI_V2_DT=y
>> CONFIG_MACH_OPENBLOCKS_A6_DT=y
>> CONFIG_MACH_TOPKICK_DT=y
>> +CONFIG_MACH_READYNAS_DT=y
>> CONFIG_MACH_TS219=y
>> CONFIG_MACH_TS41X=y
>> CONFIG_MACH_DOCKSTAR=y
>
> Keeping with alphabetic ordering, it should be one place higher....
Damned, I saw TS followed by DOCKSTAR and thought the rule did not
apply. Will resend a v3 with corrected ordering ...
>> diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/init.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/mv643xx_eth.h>
>> +#include <linux/delay.h>
>> +#include <asm/io.h>
>> +#include <mach/kirkwood.h>
>> +#include "common.h"
>
> Now that the msleep() has gone, delay.h is probably not needed. Maybe
> also io.h is not needed any more with the regulator DT?
... and that one too. Good catch.
Thanks,
a+
next prev parent reply other threads:[~2013-03-19 21:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 20:31 [PATCH] ARM: kirkwood: Add support for NETGEAR ReadyNAS Duo v2 using DT Arnaud Ebalard
2013-03-17 20:40 ` Jason Cooper
2013-03-17 20:50 ` Andrew Lunn
2013-03-17 21:23 ` Arnaud Ebalard
2013-03-18 23:10 ` Arnaud Ebalard
2013-03-18 23:44 ` Jason Cooper
2013-03-19 6:07 ` Andrew Lunn
2013-03-19 6:59 ` Arnaud Ebalard
2013-03-19 19:58 ` [PATCHv2] " Arnaud Ebalard
2013-03-19 21:16 ` Andrew Lunn
2013-03-19 21:50 ` Arnaud Ebalard [this message]
2013-03-19 22:28 ` [PATCHv3] " Arnaud Ebalard
2013-03-20 19:42 ` Andrew Lunn
2013-03-28 18:36 ` Jason Cooper
2013-03-28 20:08 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2uvcb44.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).