From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver
Date: Fri, 4 Apr 2014 13:49:07 +0200 [thread overview]
Message-ID: <201404041349.07721.marex@denx.de> (raw)
In-Reply-To: <533E8033.70904@ti.com>
On Friday, April 04, 2014 at 11:49:39 AM, sourav wrote:
[...]
> > +/* Functions for DMA support */
> > +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
> > + dma_addr_t phy_addr)
> > +{
> > + struct imx_i2c_dma *dma;
> > + struct dma_slave_config dma_sconfig;
> > + struct device *dev =&i2c_imx->adapter.dev;
> > + int ret;
> > +
> > + dma = devm_kzalloc(dev, sizeof(struct imx_i2c_dma), GFP_KERNEL);
> > + if (!dma) {
> > + dev_info(dev, "can't allocate DMA struct\n");
> > + return -ENOMEM;
> > + }
> > +
> > + dma->chan_tx = dma_request_slave_channel(dev, "tx");
> > + return 0;
>
> ?? Looks to be some leftover?
Nice find.
btw. you might want to trim the email only to the relevant parts when replying
so it's easier to find your commments in the entire body of text.
> > + if (!dma->chan_tx) {
> > + dev_info(dev, "DMA tx channel request failed\n");
> > + ret = -ENODEV;
> > + goto fail_al;
> > + }
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-04-04 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 2:41 [PATCH v4 0/2] i2c: add DMA support for freescale i2c driver Yuan Yao
2014-04-04 2:41 ` [PATCH v4 1/2] " Yuan Yao
2014-04-04 9:49 ` sourav
2014-04-04 10:04 ` sourav
2014-04-04 11:49 ` Marek Vasut [this message]
2014-04-04 14:28 ` Marek Vasut
2014-04-04 14:40 ` Wolfram Sang
2014-04-04 15:45 ` Yao Yuan
2014-04-04 17:40 ` Wolfram Sang
2014-05-21 8:00 ` Wolfram Sang
2014-07-24 3:19 ` Yao Yuan
2014-07-24 4:14 ` Marek Vasut
2014-04-04 2:41 ` [PATCH v4 2/2] Documentation:add " Yuan Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404041349.07721.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).