From: yao.yuan@freescale.com (Yao Yuan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver
Date: Fri, 4 Apr 2014 15:45:15 +0000 [thread overview]
Message-ID: <aab78696ac364d9c832993c08915bad3@BL2PR03MB338.namprd03.prod.outlook.com> (raw)
In-Reply-To: <201404041628.55471.marex@denx.de>
On Friday, April 04, 2014 at 22:29:32 PM, Marek Vasut wrote:
> On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote:
> > Add dma support for i2c. This function depend on DMA driver.
> > You can turn on it by write both the dmas and dma-name properties in dts
> > node.
> >
> > Signed-off-by: Yuan Yao <yao.yuan@freescale.com>
[...]
> Since you will be fixing that superfluous return 0; (I actually wonder, did you
> really test the driver at all before submitting it?) ...
I'm sorry for the leftover. It's a serious bug. The support by DMA will be disabled always.
Thanks for your consideration. But subjective assume may not suitable. Testing is a essential link .
But the bug can't be found by normal test . The testing may not be imperfect, it's my
serious fault, but please don't doubt my work attitude.
The ugly is my work or even the ability but not the attitude, I think.
At last, Thank you for giving me a lot of help, it's very important for me.
> > +static int i2c_imx_dma_xfer(struct imx_i2c_struct *i2c_imx,
> > + struct i2c_msg *msgs)
> > +{
> > + struct imx_i2c_dma *dma = i2c_imx->dma;
> > + struct dma_async_tx_descriptor *txdesc;
> > + struct device *dev = &i2c_imx->adapter.dev;
> +
> + dma->dma_buf = dma_map_single(dma->chan_using->device->dev, msgs->buf,
[...]
> Reviewed-by: Marek Vasut <marex@denx.de>
next prev parent reply other threads:[~2014-04-04 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 2:41 [PATCH v4 0/2] i2c: add DMA support for freescale i2c driver Yuan Yao
2014-04-04 2:41 ` [PATCH v4 1/2] " Yuan Yao
2014-04-04 9:49 ` sourav
2014-04-04 10:04 ` sourav
2014-04-04 11:49 ` Marek Vasut
2014-04-04 14:28 ` Marek Vasut
2014-04-04 14:40 ` Wolfram Sang
2014-04-04 15:45 ` Yao Yuan [this message]
2014-04-04 17:40 ` Wolfram Sang
2014-05-21 8:00 ` Wolfram Sang
2014-07-24 3:19 ` Yao Yuan
2014-07-24 4:14 ` Marek Vasut
2014-04-04 2:41 ` [PATCH v4 2/2] Documentation:add " Yuan Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab78696ac364d9c832993c08915bad3@BL2PR03MB338.namprd03.prod.outlook.com \
--to=yao.yuan@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).