* [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range
@ 2014-07-08 19:09 Felipe Balbi
2014-07-08 19:09 ` [PATCH 2/3] regulator: tps65218: drop unneeded field from our regulator macro Felipe Balbi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Felipe Balbi @ 2014-07-08 19:09 UTC (permalink / raw)
To: linux-arm-kernel
The second range of this particular regulator,
starts at 1.60V, not as 1.55V as it was originally
implied by code.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
based on datasheet only. Also boot tested on another,
yet-to-be-released HW.?A 50mV difference is probably
not a big deal for any users of DCDC4 but it's still
good to be correct.
drivers/regulator/tps65218-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index 9effe48..8b7a0a9 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range ldo1_dcdc3_ranges[] = {
static const struct regulator_linear_range dcdc4_ranges[] = {
REGULATOR_LINEAR_RANGE(1175000, 0x0, 0xf, 25000),
- REGULATOR_LINEAR_RANGE(1550000, 0x10, 0x34, 50000),
+ REGULATOR_LINEAR_RANGE(1600000, 0x10, 0x34, 50000),
};
static struct tps_info tps65218_pmic_regs[] = {
--
2.0.0.390.gcb682f8
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] regulator: tps65218: drop unneeded field from our regulator macro
2014-07-08 19:09 [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Felipe Balbi
@ 2014-07-08 19:09 ` Felipe Balbi
2014-07-08 19:09 ` [PATCH 3/3] regulators: tps65218: drop order dependency Felipe Balbi
2014-07-09 8:32 ` [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2014-07-08 19:09 UTC (permalink / raw)
To: linux-arm-kernel
volt table is always NULL for all regulators,
might as well drop the argument.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/regulator/tps65218-regulator.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index 8b7a0a9..7fc8b3a 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -29,7 +29,7 @@
enum tps65218_regulators { DCDC1, DCDC2, DCDC3, DCDC4, DCDC5, DCDC6, LDO1 };
-#define TPS65218_REGULATOR(_name, _id, _ops, _n, _vr, _vm, _er, _em, _t, \
+#define TPS65218_REGULATOR(_name, _id, _ops, _n, _vr, _vm, _er, _em, \
_lr, _nlr, _delay) \
{ \
.name = _name, \
@@ -42,7 +42,7 @@ enum tps65218_regulators { DCDC1, DCDC2, DCDC3, DCDC4, DCDC5, DCDC6, LDO1 };
.vsel_mask = _vm, \
.enable_reg = _er, \
.enable_mask = _em, \
- .volt_table = _t, \
+ .volt_table = NULL, \
.linear_ranges = _lr, \
.n_linear_ranges = _nlr, \
.ramp_delay = _delay, \
@@ -185,33 +185,32 @@ static const struct regulator_desc regulators[] = {
TPS65218_REGULATOR("DCDC1", TPS65218_DCDC_1, tps65218_dcdc12_ops, 64,
TPS65218_REG_CONTROL_DCDC1,
TPS65218_CONTROL_DCDC1_MASK,
- TPS65218_REG_ENABLE1, TPS65218_ENABLE1_DC1_EN, NULL,
+ TPS65218_REG_ENABLE1, TPS65218_ENABLE1_DC1_EN,
dcdc1_dcdc2_ranges, 2, 4000),
TPS65218_REGULATOR("DCDC2", TPS65218_DCDC_2, tps65218_dcdc12_ops, 64,
TPS65218_REG_CONTROL_DCDC2,
TPS65218_CONTROL_DCDC2_MASK,
- TPS65218_REG_ENABLE1, TPS65218_ENABLE1_DC2_EN, NULL,
+ TPS65218_REG_ENABLE1, TPS65218_ENABLE1_DC2_EN,
dcdc1_dcdc2_ranges, 2, 4000),
TPS65218_REGULATOR("DCDC3", TPS65218_DCDC_3, tps65218_ldo1_dcdc34_ops,
64, TPS65218_REG_CONTROL_DCDC3,
TPS65218_CONTROL_DCDC3_MASK, TPS65218_REG_ENABLE1,
- TPS65218_ENABLE1_DC3_EN, NULL,
- ldo1_dcdc3_ranges, 2, 0),
+ TPS65218_ENABLE1_DC3_EN, ldo1_dcdc3_ranges, 2, 0),
TPS65218_REGULATOR("DCDC4", TPS65218_DCDC_4, tps65218_ldo1_dcdc34_ops,
53, TPS65218_REG_CONTROL_DCDC4,
TPS65218_CONTROL_DCDC4_MASK,
- TPS65218_REG_ENABLE1, TPS65218_ENABLE1_DC4_EN, NULL,
+ TPS65218_REG_ENABLE1, TPS65218_ENABLE1_DC4_EN,
dcdc4_ranges, 2, 0),
TPS65218_REGULATOR("DCDC5", TPS65218_DCDC_5, tps65218_dcdc56_pmic_ops,
1, -1, -1, TPS65218_REG_ENABLE1,
- TPS65218_ENABLE1_DC5_EN, NULL, NULL, 0, 0),
+ TPS65218_ENABLE1_DC5_EN, NULL, 0, 0),
TPS65218_REGULATOR("DCDC6", TPS65218_DCDC_6, tps65218_dcdc56_pmic_ops,
1, -1, -1, TPS65218_REG_ENABLE1,
- TPS65218_ENABLE1_DC6_EN, NULL, NULL, 0, 0),
+ TPS65218_ENABLE1_DC6_EN, NULL, 0, 0),
TPS65218_REGULATOR("LDO1", TPS65218_LDO_1, tps65218_ldo1_dcdc34_ops, 64,
TPS65218_REG_CONTROL_LDO1,
TPS65218_CONTROL_LDO1_MASK, TPS65218_REG_ENABLE2,
- TPS65218_ENABLE2_LDO1_EN, NULL, ldo1_dcdc3_ranges,
+ TPS65218_ENABLE2_LDO1_EN, ldo1_dcdc3_ranges,
2, 0),
};
--
2.0.0.390.gcb682f8
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] regulators: tps65218: drop order dependency
2014-07-08 19:09 [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Felipe Balbi
2014-07-08 19:09 ` [PATCH 2/3] regulator: tps65218: drop unneeded field from our regulator macro Felipe Balbi
@ 2014-07-08 19:09 ` Felipe Balbi
2014-07-09 8:32 ` [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2014-07-08 19:09 UTC (permalink / raw)
To: linux-arm-kernel
By just using GCC's array initialization extension, we
can easily drop order dependency between tps65218_regulattors
enumeration and tps65218_pmic_regs array.
Signed-of-by: Felipe Balbi <balbi@ti.com>
---
drivers/regulator/tps65218-regulator.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index 7fc8b3a..b5dc314 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -49,7 +49,7 @@ enum tps65218_regulators { DCDC1, DCDC2, DCDC3, DCDC4, DCDC5, DCDC6, LDO1 };
} \
#define TPS65218_INFO(_id, _nm, _min, _max) \
- { \
+ [_id] = { \
.id = _id, \
.name = _nm, \
.min_uV = _min, \
@@ -72,13 +72,13 @@ static const struct regulator_linear_range dcdc4_ranges[] = {
};
static struct tps_info tps65218_pmic_regs[] = {
- TPS65218_INFO(0, "DCDC1", 850000, 167500),
- TPS65218_INFO(1, "DCDC2", 850000, 1675000),
- TPS65218_INFO(2, "DCDC3", 900000, 3400000),
- TPS65218_INFO(3, "DCDC4", 1175000, 3400000),
- TPS65218_INFO(4, "DCDC5", 1000000, 1000000),
- TPS65218_INFO(5, "DCDC6", 1800000, 1800000),
- TPS65218_INFO(6, "LDO1", 900000, 3400000),
+ TPS65218_INFO(DCDC1, "DCDC1", 850000, 167500),
+ TPS65218_INFO(DCDC2, "DCDC2", 850000, 1675000),
+ TPS65218_INFO(DCDC3, "DCDC3", 900000, 3400000),
+ TPS65218_INFO(DCDC4, "DCDC4", 1175000, 3400000),
+ TPS65218_INFO(DCDC5, "DCDC5", 1000000, 1000000),
+ TPS65218_INFO(DCDC6, "DCDC6", 1800000, 1800000),
+ TPS65218_INFO(LDO1, "LDO1", 900000, 3400000),
};
#define TPS65218_OF_MATCH(comp, label) \
--
2.0.0.390.gcb682f8
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range
2014-07-08 19:09 [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Felipe Balbi
2014-07-08 19:09 ` [PATCH 2/3] regulator: tps65218: drop unneeded field from our regulator macro Felipe Balbi
2014-07-08 19:09 ` [PATCH 3/3] regulators: tps65218: drop order dependency Felipe Balbi
@ 2014-07-09 8:32 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-07-09 8:32 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 08, 2014 at 02:09:12PM -0500, Felipe Balbi wrote:
> The second range of this particular regulator,
> starts at 1.60V, not as 1.55V as it was originally
> implied by code.
Applied all, thanks. Please use subject lines consistent with the style
for the subsystem - these even vary within the series!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140709/2ecb4acb/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-09 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-08 19:09 [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Felipe Balbi
2014-07-08 19:09 ` [PATCH 2/3] regulator: tps65218: drop unneeded field from our regulator macro Felipe Balbi
2014-07-08 19:09 ` [PATCH 3/3] regulators: tps65218: drop order dependency Felipe Balbi
2014-07-09 8:32 ` [PATCH 1/3] regulators: tps65218: fix DCDC4 linear voltage range Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).