* [PATCH] ARM: dts: imx: Add alias for ethernet controller
@ 2014-02-28 11:58 Marek Vasut
2014-03-18 0:37 ` Marek Vasut
0 siblings, 1 reply; 15+ messages in thread
From: Marek Vasut @ 2014-02-28 11:58 UTC (permalink / raw)
To: linux-arm-kernel
Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot)
patch-in the MAC address for FEC using this alias.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/boot/dts/imx25.dtsi | 1 +
arch/arm/boot/dts/imx27.dtsi | 1 +
arch/arm/boot/dts/imx35.dtsi | 1 +
arch/arm/boot/dts/imx50.dtsi | 1 +
arch/arm/boot/dts/imx51.dtsi | 1 +
arch/arm/boot/dts/imx53.dtsi | 1 +
arch/arm/boot/dts/imx6qdl.dtsi | 1 +
arch/arm/boot/dts/imx6sl.dtsi | 1 +
8 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 32f760e..77bb743 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -14,6 +14,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 6279e0b..83a8247 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -16,6 +16,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
index 88b218f..e59ccb4 100644
--- a/arch/arm/boot/dts/imx35.dtsi
+++ b/arch/arm/boot/dts/imx35.dtsi
@@ -13,6 +13,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
index 0c75fe3..c249064 100644
--- a/arch/arm/boot/dts/imx50.dtsi
+++ b/arch/arm/boot/dts/imx50.dtsi
@@ -17,6 +17,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index e4b07d1..e508e6f 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -19,6 +19,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 80615df..5f382ea 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -18,6 +18,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index a2d5c49..d63df59 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -14,6 +14,7 @@
/ {
aliases {
+ ethernet0 = &fec;
can0 = &can1;
can1 = &can2;
gpio0 = &gpio1;
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 3cb4941..6477447 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -14,6 +14,7 @@
/ {
aliases {
+ ethernet0 = &fec;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
--
1.8.5.2
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-02-28 11:58 [PATCH] ARM: dts: imx: Add alias for ethernet controller Marek Vasut
@ 2014-03-18 0:37 ` Marek Vasut
2014-03-24 1:49 ` Shawn Guo
0 siblings, 1 reply; 15+ messages in thread
From: Marek Vasut @ 2014-03-18 0:37 UTC (permalink / raw)
To: linux-arm-kernel
On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot)
> patch-in the MAC address for FEC using this alias.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
Bump ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-03-18 0:37 ` Marek Vasut
@ 2014-03-24 1:49 ` Shawn Guo
2014-03-24 2:39 ` Marek Vasut
2014-07-22 2:10 ` Marek Vasut
0 siblings, 2 replies; 15+ messages in thread
From: Shawn Guo @ 2014-03-24 1:49 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot)
> > patch-in the MAC address for FEC using this alias.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
>
> Bump ?
Sorry. I had actually applied the patch but forgot replying.
Shawn
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-03-24 1:49 ` Shawn Guo
@ 2014-03-24 2:39 ` Marek Vasut
2014-07-22 2:10 ` Marek Vasut
1 sibling, 0 replies; 15+ messages in thread
From: Marek Vasut @ 2014-03-24 2:39 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote:
> On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot)
> > > patch-in the MAC address for FEC using this alias.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Shawn Guo <shawn.guo@linaro.org>
> >
> > Bump ?
>
> Sorry. I had actually applied the patch but forgot replying.
Uh, no, apology is on my end for not checking first. Sorry!
Thank you!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-03-24 1:49 ` Shawn Guo
2014-03-24 2:39 ` Marek Vasut
@ 2014-07-22 2:10 ` Marek Vasut
2014-07-22 3:03 ` Shawn Guo
1 sibling, 1 reply; 15+ messages in thread
From: Marek Vasut @ 2014-07-22 2:10 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote:
> On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot)
> > > patch-in the MAC address for FEC using this alias.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Shawn Guo <shawn.guo@linaro.org>
> >
> > Bump ?
>
> Sorry. I had actually applied the patch but forgot replying.
Hello Shawn,
I'd like to apply this patch for 3.14-stable , are you OK with this please ?
Shall I submit it ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-22 2:10 ` Marek Vasut
@ 2014-07-22 3:03 ` Shawn Guo
2014-07-22 5:00 ` Marek Vasut
0 siblings, 1 reply; 15+ messages in thread
From: Shawn Guo @ 2014-07-22 3:03 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote:
> On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote:
> > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot)
> > > > patch-in the MAC address for FEC using this alias.
> > > >
> > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > >
> > > Bump ?
> >
> > Sorry. I had actually applied the patch but forgot replying.
>
> Hello Shawn,
>
> I'd like to apply this patch for 3.14-stable , are you OK with this please ?
> Shall I submit it ?
I do not see why this is a stable material. But you do not need my
approval to send patch for stable kernel. The person you need to
convince is Greg.
Shawn
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-22 3:03 ` Shawn Guo
@ 2014-07-22 5:00 ` Marek Vasut
2014-07-22 5:20 ` Shawn Guo
0 siblings, 1 reply; 15+ messages in thread
From: Marek Vasut @ 2014-07-22 5:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, July 22, 2014 at 05:03:38 AM, Shawn Guo wrote:
> On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote:
> > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote:
> > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like
> > > > > U-Boot) patch-in the MAC address for FEC using this alias.
> > > > >
> > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > >
> > > > Bump ?
> > >
> > > Sorry. I had actually applied the patch but forgot replying.
> >
> > Hello Shawn,
> >
> > I'd like to apply this patch for 3.14-stable , are you OK with this
> > please ? Shall I submit it ?
>
> I do not see why this is a stable material. But you do not need my
> approval to send patch for stable kernel. The person you need to
> convince is Greg.
Without this patch, you will not get a mac address patched into the DT by the
bootloader. Therefore, your device will use a random mac address on the network
which is different on every boot. This is not a good thing, don't you agree?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-22 5:00 ` Marek Vasut
@ 2014-07-22 5:20 ` Shawn Guo
2014-07-22 5:45 ` Marek Vasut
0 siblings, 1 reply; 15+ messages in thread
From: Shawn Guo @ 2014-07-22 5:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 22, 2014 at 07:00:48AM +0200, Marek Vasut wrote:
> On Tuesday, July 22, 2014 at 05:03:38 AM, Shawn Guo wrote:
> > On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote:
> > > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote:
> > > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> > > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like
> > > > > > U-Boot) patch-in the MAC address for FEC using this alias.
> > > > > >
> > > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > > >
> > > > > Bump ?
> > > >
> > > > Sorry. I had actually applied the patch but forgot replying.
> > >
> > > Hello Shawn,
> > >
> > > I'd like to apply this patch for 3.14-stable , are you OK with this
> > > please ? Shall I submit it ?
> >
> > I do not see why this is a stable material. But you do not need my
> > approval to send patch for stable kernel. The person you need to
> > convince is Greg.
>
> Without this patch, you will not get a mac address patched into the DT by the
> bootloader. Therefore, your device will use a random mac address on the network
> which is different on every boot. This is not a good thing, don't you agree?
I agree this is not a good thing. But it's neither a regression nor a
critical issue as defined by stable_kernel_rules.txt.
Shawn
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-22 5:20 ` Shawn Guo
@ 2014-07-22 5:45 ` Marek Vasut
0 siblings, 0 replies; 15+ messages in thread
From: Marek Vasut @ 2014-07-22 5:45 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, July 22, 2014 at 07:20:48 AM, Shawn Guo wrote:
> On Tue, Jul 22, 2014 at 07:00:48AM +0200, Marek Vasut wrote:
> > On Tuesday, July 22, 2014 at 05:03:38 AM, Shawn Guo wrote:
> > > On Tue, Jul 22, 2014 at 04:10:26AM +0200, Marek Vasut wrote:
> > > > On Monday, March 24, 2014 at 02:49:38 AM, Shawn Guo wrote:
> > > > > On Tue, Mar 18, 2014 at 01:37:09AM +0100, Marek Vasut wrote:
> > > > > > On Friday, February 28, 2014 at 12:58:41 PM, Marek Vasut wrote:
> > > > > > > Add alias for FEC ethernet on i.MX to allow bootloaders (like
> > > > > > > U-Boot) patch-in the MAC address for FEC using this alias.
> > > > > > >
> > > > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > > > >
> > > > > > Bump ?
> > > > >
> > > > > Sorry. I had actually applied the patch but forgot replying.
> > > >
> > > > Hello Shawn,
> > > >
> > > > I'd like to apply this patch for 3.14-stable , are you OK with this
> > > > please ? Shall I submit it ?
> > >
> > > I do not see why this is a stable material. But you do not need my
> > > approval to send patch for stable kernel. The person you need to
> > > convince is Greg.
> >
> > Without this patch, you will not get a mac address patched into the DT by
> > the bootloader. Therefore, your device will use a random mac address on
> > the network which is different on every boot. This is not a good thing,
> > don't you agree?
>
> I agree this is not a good thing. But it's neither a regression nor a
> critical issue as defined by stable_kernel_rules.txt.
If I cannot even properly boot from an NFS root with v3.14.y , it seems to me to
be problem enough. Also, MAC address should be a unique identifier, if the FEC
picks a random MAC, it will wreak havoc on the network (in the better case).
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
@ 2014-07-24 2:07 Marek Vasut
2014-07-24 3:17 ` Shawn Guo
0 siblings, 1 reply; 15+ messages in thread
From: Marek Vasut @ 2014-07-24 2:07 UTC (permalink / raw)
To: linux-arm-kernel
commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.
Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow
bootloaders (like U-Boot) patch-in the MAC address for FEC using this
alias.
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: <stable@vger.kernel.org> # 3.14.x
---
arch/arm/boot/dts/imx25.dtsi | 1 +
arch/arm/boot/dts/imx27.dtsi | 1 +
arch/arm/boot/dts/imx51.dtsi | 1 +
arch/arm/boot/dts/imx53.dtsi | 1 +
4 files changed, 4 insertions(+)
NOTE: Without this backport, the ethernet adapter on most of the boards
with the i.MX CPUs does not know it's MAC address (the controller
does not have an EEPROM). Without MAC address, the ethernet cannot
be brought up and this makes such board unusable when booting from
NFS. This patch lets the bootloader pass the MAC address via DT to
the kernel properly, thus letting me boot from NFS again.
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 737ed5d..de16119 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -30,6 +30,7 @@
spi2 = &spi3;
usb0 = &usbotg;
usb1 = &usbhost1;
+ ethernet0 = &fec;
};
cpus {
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 826231e..da2eb7f 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -30,6 +30,7 @@
spi0 = &cspi1;
spi1 = &cspi2;
spi2 = &cspi3;
+ ethernet0 = &fec;
};
aitc: aitc-interrupt-controller at e0000000 {
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 4bcdd3a..e1b6015 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -27,6 +27,7 @@
spi0 = &ecspi1;
spi1 = &ecspi2;
spi2 = &cspi;
+ ethernet0 = &fec;
};
tzic: tz-interrupt-controller at e0000000 {
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 7abe6c4..86df3f5 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -34,6 +34,7 @@
spi0 = &ecspi1;
spi1 = &ecspi2;
spi2 = &cspi;
+ ethernet0 = &fec;
};
cpus {
--
2.0.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-24 2:07 Marek Vasut
@ 2014-07-24 3:17 ` Shawn Guo
2014-07-24 3:52 ` Greg KH
2014-07-24 4:15 ` Marek Vasut
0 siblings, 2 replies; 15+ messages in thread
From: Shawn Guo @ 2014-07-24 3:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 24, 2014 at 04:07:19AM +0200, Marek Vasut wrote:
> commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.
>
> Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow
> bootloaders (like U-Boot) patch-in the MAC address for FEC using this
> alias.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: <stable@vger.kernel.org> # 3.14.x
Since the patch is already on mainline, and the submitting target is
3.14.x stable kernel, you should really send it to Greg.
Shawn
> ---
> arch/arm/boot/dts/imx25.dtsi | 1 +
> arch/arm/boot/dts/imx27.dtsi | 1 +
> arch/arm/boot/dts/imx51.dtsi | 1 +
> arch/arm/boot/dts/imx53.dtsi | 1 +
> 4 files changed, 4 insertions(+)
>
> NOTE: Without this backport, the ethernet adapter on most of the boards
> with the i.MX CPUs does not know it's MAC address (the controller
> does not have an EEPROM). Without MAC address, the ethernet cannot
> be brought up and this makes such board unusable when booting from
> NFS. This patch lets the bootloader pass the MAC address via DT to
> the kernel properly, thus letting me boot from NFS again.
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 737ed5d..de16119 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -30,6 +30,7 @@
> spi2 = &spi3;
> usb0 = &usbotg;
> usb1 = &usbhost1;
> + ethernet0 = &fec;
> };
>
> cpus {
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 826231e..da2eb7f 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -30,6 +30,7 @@
> spi0 = &cspi1;
> spi1 = &cspi2;
> spi2 = &cspi3;
> + ethernet0 = &fec;
> };
>
> aitc: aitc-interrupt-controller at e0000000 {
> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> index 4bcdd3a..e1b6015 100644
> --- a/arch/arm/boot/dts/imx51.dtsi
> +++ b/arch/arm/boot/dts/imx51.dtsi
> @@ -27,6 +27,7 @@
> spi0 = &ecspi1;
> spi1 = &ecspi2;
> spi2 = &cspi;
> + ethernet0 = &fec;
> };
>
> tzic: tz-interrupt-controller at e0000000 {
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 7abe6c4..86df3f5 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -34,6 +34,7 @@
> spi0 = &ecspi1;
> spi1 = &ecspi2;
> spi2 = &cspi;
> + ethernet0 = &fec;
> };
>
> cpus {
> --
> 2.0.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-24 3:17 ` Shawn Guo
@ 2014-07-24 3:52 ` Greg KH
2014-07-24 4:17 ` Marek Vasut
2014-07-24 6:10 ` Shawn Guo
2014-07-24 4:15 ` Marek Vasut
1 sibling, 2 replies; 15+ messages in thread
From: Greg KH @ 2014-07-24 3:52 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 24, 2014 at 11:17:55AM +0800, Shawn Guo wrote:
> On Thu, Jul 24, 2014 at 04:07:19AM +0200, Marek Vasut wrote:
> > commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.
> >
> > Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow
> > bootloaders (like U-Boot) patch-in the MAC address for FEC using this
> > alias.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: <stable@vger.kernel.org> # 3.14.x
>
> Since the patch is already on mainline, and the submitting target is
> 3.14.x stable kernel, you should really send it to Greg.
No, Marek did the right thing here by sending it to the stable at vger
mailing list, never send stable patches only to me.
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-24 3:52 ` Greg KH
@ 2014-07-24 4:17 ` Marek Vasut
2014-07-24 6:10 ` Shawn Guo
1 sibling, 0 replies; 15+ messages in thread
From: Marek Vasut @ 2014-07-24 4:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, July 24, 2014 at 05:52:53 AM, Greg KH wrote:
> On Thu, Jul 24, 2014 at 11:17:55AM +0800, Shawn Guo wrote:
> > On Thu, Jul 24, 2014 at 04:07:19AM +0200, Marek Vasut wrote:
> > > commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.
> > >
> > > Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to
> > > allow bootloaders (like U-Boot) patch-in the MAC address for FEC using
> > > this alias.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: <stable@vger.kernel.org> # 3.14.x
> >
> > Since the patch is already on mainline, and the submitting target is
> > 3.14.x stable kernel, you should really send it to Greg.
>
> No, Marek did the right thing here by sending it to the stable at vger
> mailing list, never send stable patches only to me.
Whew, I was really worried I messed the submission up. Thank you for confirming
this is the right way to do it.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-24 3:52 ` Greg KH
2014-07-24 4:17 ` Marek Vasut
@ 2014-07-24 6:10 ` Shawn Guo
1 sibling, 0 replies; 15+ messages in thread
From: Shawn Guo @ 2014-07-24 6:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 23, 2014 at 08:52:53PM -0700, Greg KH wrote:
> On Thu, Jul 24, 2014 at 11:17:55AM +0800, Shawn Guo wrote:
> > On Thu, Jul 24, 2014 at 04:07:19AM +0200, Marek Vasut wrote:
> > > commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.
> > >
> > > Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow
> > > bootloaders (like U-Boot) patch-in the MAC address for FEC using this
> > > alias.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: <stable@vger.kernel.org> # 3.14.x
> >
> > Since the patch is already on mainline, and the submitting target is
> > 3.14.x stable kernel, you should really send it to Greg.
>
> No, Marek did the right thing here by sending it to the stable at vger
> mailing list, never send stable patches only to me.
Oh, I did not mean sending the patch only to you, but have you on copy.
Shawn
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: imx: Add alias for ethernet controller
2014-07-24 3:17 ` Shawn Guo
2014-07-24 3:52 ` Greg KH
@ 2014-07-24 4:15 ` Marek Vasut
1 sibling, 0 replies; 15+ messages in thread
From: Marek Vasut @ 2014-07-24 4:15 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, July 24, 2014 at 05:17:55 AM, Shawn Guo wrote:
> On Thu, Jul 24, 2014 at 04:07:19AM +0200, Marek Vasut wrote:
> > commit 22970070e027cbbb9b2878f8f7c31d0d7f29e94d upstream.
> >
> > Add alias for FEC ethernet on i.MX25, i.MX27, i.MX51 and i.MX53 to allow
> > bootloaders (like U-Boot) patch-in the MAC address for FEC using this
> > alias.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: <stable@vger.kernel.org> # 3.14.x
>
> Since the patch is already on mainline, and the submitting target is
> 3.14.x stable kernel, you should really send it to Greg.
So this is not enough to add this "# 3.14.x" ? I followed the stable submissing
guidelines, but I probably missed something then ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2014-07-24 6:10 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-28 11:58 [PATCH] ARM: dts: imx: Add alias for ethernet controller Marek Vasut
2014-03-18 0:37 ` Marek Vasut
2014-03-24 1:49 ` Shawn Guo
2014-03-24 2:39 ` Marek Vasut
2014-07-22 2:10 ` Marek Vasut
2014-07-22 3:03 ` Shawn Guo
2014-07-22 5:00 ` Marek Vasut
2014-07-22 5:20 ` Shawn Guo
2014-07-22 5:45 ` Marek Vasut
2014-07-24 2:07 Marek Vasut
2014-07-24 3:17 ` Shawn Guo
2014-07-24 3:52 ` Greg KH
2014-07-24 4:17 ` Marek Vasut
2014-07-24 6:10 ` Shawn Guo
2014-07-24 4:15 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).