From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
Date: Mon, 8 Sep 2014 12:57:35 +0100 [thread overview]
Message-ID: <20140908115735.GA26284@lee--X1> (raw)
In-Reply-To: <20140905152758.GA10670@roeck-us.net>
On Fri, 05 Sep 2014, Guenter Roeck wrote:
> On Thu, Sep 04, 2014 at 03:39:51PM +0100, Lee Jones wrote:
> > Signed-off-by: David Paris <david.paris@st.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> You might want to copy the devicetree mailing list for bindings approval.
This is strange. There are two emails, exactly the same send 1 second
apart. Once has the DT ML CC'ed, the other does not. I think `git
send-email` picked up the *~ file left over by Emacs. I'll endeavour
to remove those in future.
> > ---
> > .../devicetree/bindings/watchdog/st-lpc-wdt.txt | 27 ++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> > new file mode 100644
> > index 0000000..f0e57ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> > @@ -0,0 +1,27 @@
> > +STMicroelectronics LPC Watchdog
> > +===============================
> > +
> > +Required properties
> > +
> > +- compatible : "st,<soc>-watchdog"
>
> Is this acceptable ? I thought the supported bindings have to be listed
> explicitly.
I can do that.
> > +- reg : LPC registers base address + range
> > +- reg-names : Register map "base" and "syscfg-en" are compulsory "type" is
>
> '.' after compulsory ?
Sure. :)
> > + platform dependent and not required for the STiH407.
> > +- clock-names : Should be "lpc_wdt"
> > +- clocks : Clock used by LPC device
> > +- timeout-sec : Qatchdog timeout in seconds
>
> Watchdog
> > +- st,syscfg : Syscfg node used to configure cpu reset type and mask
> > +- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
>
> s/cold/cold./ ?
There shouldn't be any full stops.
Will change s/STiH407./STiH407/ above.
> > +
> > +Example:
> > + watchdog at fde05000 {
> > + compatible = "st,stih416-lpc-watchdog";
> > + reg = <0xfde05000 0x1000> <0x204 0x4>;
> > + reg-names = "base", "syscfg-en"
> > + clock-names = "lpc_wdt";
> > + clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
> > + timeout-sec = <600>;
> > + st,syscfg = <&syscfg_core>;
> > + st,warm_reset;
> > + };
> > +
>
> Empty line at the end results in a whitespace error when applying.
Will fix.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-08 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:39 [PATCH 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-09-04 14:39 ` [PATCH 1/4] ARM: STi: DT: STiH407: Add Device Tree node for LPC Watchdog Lee Jones
2014-09-04 14:39 ` [PATCH 2/4] ARM: multi_v7_defconfig: Enable support for ST's " Lee Jones
2014-09-04 14:39 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-09-04 14:39 ` Lee Jones
2014-09-05 15:27 ` Guenter Roeck
2014-09-08 11:57 ` Lee Jones [this message]
2014-09-04 14:39 ` [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-09-05 15:58 ` Guenter Roeck
2014-09-05 18:25 ` [STLinux Kernel] " Peter Griffin
2014-09-08 12:32 ` Lee Jones
2014-09-08 13:31 ` Guenter Roeck
2014-09-08 14:35 ` Lee Jones
2014-09-22 7:36 ` David Paris
2014-09-22 10:24 ` David Paris
2014-10-07 14:36 [PATCH v2 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-07 14:36 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-10-08 9:33 [PATCH v3 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-08 9:33 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-10-09 9:56 ` Mark Rutland
2014-10-23 15:02 ` Lee Jones
2014-10-23 15:18 [PATCH v4 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-23 15:18 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908115735.GA26284@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).