From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
Date: Thu, 9 Oct 2014 10:56:49 +0100 [thread overview]
Message-ID: <20141009095649.GC3869@leverpostej> (raw)
In-Reply-To: <1412760810-23199-4-git-send-email-lee.jones@linaro.org>
On Wed, Oct 08, 2014 at 10:33:29AM +0100, Lee Jones wrote:
> Cc: devicetree at vger.kernel.org
> Signed-off-by: David Paris <david.paris@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> .../devicetree/bindings/watchdog/st-lpc-wdt.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> new file mode 100644
> index 0000000..520ce90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> @@ -0,0 +1,30 @@
> +STMicroelectronics LPC Watchdog
> +===============================
> +
> +Required properties
> +
> +- compatible : Must be one of:
> + "st,stih407-watchdog"
> + "st,stih416-watchdog"
> + "st,stih415-watchdog"
> + "st,stid127-watchdog"
> +- reg : LPC registers base address + range
s/range/size/
Please append something like "one entryfor each entry in reg-names".
> +- reg-names : Register map "base" and "syscfg-en" are compulsory. "type" is
> + platform dependent and not required for the STiH407
I don't understand the mention of "type".
Additionally, "syscfg-en" looks to be a portion of another device
(shared system controller?), and probably should be described by
reference.
> +- clock-names : Should be "lpc_wdt"
> +- clocks : Clock used by LPC device
> +- timeout-sec : Watchdog timeout in seconds
> +- st,syscfg : Syscfg node used to configure CPU reset type and mask
Does this relate to the syscfg-en entry in the reg proeprty?
> +- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
s/_/-/ in property names.
Why does this need to be in the binding? It seems like a choice rather
than a property of the system.
Mark.
> +
> +Example:
> + watchdog at fde05000 {
> + compatible = "st,stih416-lpc-watchdog";
> + reg = <0xfde05000 0x1000> <0x204 0x4>;
> + reg-names = "base", "syscfg-en"
> + clock-names = "lpc_wdt";
> + clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
> + timeout-sec = <600>;
> + st,syscfg = <&syscfg_core>;
> + st,warm_reset;
> + };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-10-09 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 9:33 [PATCH v3 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-08 9:33 ` [PATCH 1/4] ARM: STi: DT: STiH407: Add Device Tree node for LPC Watchdog Lee Jones
2014-10-08 9:33 ` [PATCH 2/4] ARM: multi_v7_defconfig: Enable support for ST's " Lee Jones
2014-10-08 9:33 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-10-09 9:56 ` Mark Rutland [this message]
2014-10-23 15:02 ` Lee Jones
2014-10-08 9:33 ` [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-10-08 15:57 ` Guenter Roeck
2014-10-09 7:17 ` Lee Jones
2014-10-09 15:59 ` Guenter Roeck
2014-10-09 10:01 ` Mark Rutland
2014-10-09 10:50 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 15:18 [PATCH v4 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-23 15:18 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-10-07 14:36 [PATCH v2 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-07 14:36 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-09-04 14:39 [PATCH 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-09-04 14:39 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-09-04 14:39 ` Lee Jones
2014-09-05 15:27 ` Guenter Roeck
2014-09-08 11:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009095649.GC3869@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).