[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Lee Jones]

Prevents build warning:

st_thermal.c:278:12:
    warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
st_thermal.c:286:12:
    warning: ?st_thermal_resume? defined but not used [-Wunused-function]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/thermal/st/st_thermal.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
index 90163b3..9841488 100644
--- a/drivers/thermal/st/st_thermal.c
+++ b/drivers/thermal/st/st_thermal.c
@@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
 }
 EXPORT_SYMBOL_GPL(st_thermal_unregister);
 
+#ifdef CONFIG_PM
 static int st_thermal_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
@@ -305,6 +306,8 @@ static int st_thermal_resume(struct device *dev)
 
 	return 0;
 }
+#endif
+
 SIMPLE_DEV_PM_OPS(st_thermal_pm_ops, st_thermal_suspend, st_thermal_resume);
 EXPORT_SYMBOL_GPL(st_thermal_pm_ops);
 
-- 
1.9.1

[STLinux Kernel] [PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Maxime Coquelin]

On 11/19/2014 02:48 PM, Lee Jones wrote:
> Prevents build warning:
>
> st_thermal.c:278:12:
>      warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> st_thermal.c:286:12:
>      warning: ?st_thermal_resume? defined but not used [-Wunused-function]
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Thanks,
Maxime

> ---
>   drivers/thermal/st/st_thermal.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> index 90163b3..9841488 100644
> --- a/drivers/thermal/st/st_thermal.c
> +++ b/drivers/thermal/st/st_thermal.c
> @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
>   }
>   EXPORT_SYMBOL_GPL(st_thermal_unregister);
>   
> +#ifdef CONFIG_PM
>   static int st_thermal_suspend(struct device *dev)
>   {
>   	struct platform_device *pdev = to_platform_device(dev);
> @@ -305,6 +306,8 @@ static int st_thermal_resume(struct device *dev)
>   
>   	return 0;
>   }
> +#endif
> +
>   SIMPLE_DEV_PM_OPS(st_thermal_pm_ops, st_thermal_suspend, st_thermal_resume);
>   EXPORT_SYMBOL_GPL(st_thermal_pm_ops);
>   

[STLinux Kernel] [PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Lee Jones]

On Wed, 19 Nov 2014, Maxime Coquelin wrote:

> 
> On 11/19/2014 02:48 PM, Lee Jones wrote:
> >Prevents build warning:
> >
> >st_thermal.c:278:12:
> >     warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> >st_thermal.c:286:12:
> >     warning: ?st_thermal_resume? defined but not used [-Wunused-function]
> >
> >Signed-off-by: Lee Jones <lee.jones@linaro.org>
> You can add my:
> Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Sorry Maxime, I made a booboo!

Resubmitted.

> >---
> >  drivers/thermal/st/st_thermal.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> >diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> >index 90163b3..9841488 100644
> >--- a/drivers/thermal/st/st_thermal.c
> >+++ b/drivers/thermal/st/st_thermal.c
> >@@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
> >  }
> >  EXPORT_SYMBOL_GPL(st_thermal_unregister);
> >+#ifdef CONFIG_PM
> >  static int st_thermal_suspend(struct device *dev)
> >  {
> >  	struct platform_device *pdev = to_platform_device(dev);
> >@@ -305,6 +306,8 @@ static int st_thermal_resume(struct device *dev)
> >  	return 0;
> >  }
> >+#endif
> >+
> >  SIMPLE_DEV_PM_OPS(st_thermal_pm_ops, st_thermal_suspend, st_thermal_resume);
> >  EXPORT_SYMBOL_GPL(st_thermal_pm_ops);
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Fabio Estevam]

On Wed, Nov 19, 2014 at 11:48 AM, Lee Jones <lee.jones@linaro.org> wrote:
> Prevents build warning:
>
> st_thermal.c:278:12:
>     warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> st_thermal.c:286:12:
>     warning: ?st_thermal_resume? defined but not used [-Wunused-function]
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/thermal/st/st_thermal.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> index 90163b3..9841488 100644
> --- a/drivers/thermal/st/st_thermal.c
> +++ b/drivers/thermal/st/st_thermal.c
> @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
>  }
>  EXPORT_SYMBOL_GPL(st_thermal_unregister);
>
> +#ifdef CONFIG_PM

Actually this should be #ifdef CONFIG_PM_SLEEP instead

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Lee Jones]

On Wed, 19 Nov 2014, Fabio Estevam wrote:

> On Wed, Nov 19, 2014 at 11:48 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > Prevents build warning:
> >
> > st_thermal.c:278:12:
> >     warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> > st_thermal.c:286:12:
> >     warning: ?st_thermal_resume? defined but not used [-Wunused-function]
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/thermal/st/st_thermal.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> > index 90163b3..9841488 100644
> > --- a/drivers/thermal/st/st_thermal.c
> > +++ b/drivers/thermal/st/st_thermal.c
> > @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
> >  }
> >  EXPORT_SYMBOL_GPL(st_thermal_unregister);
> >
> > +#ifdef CONFIG_PM
> 
> Actually this should be #ifdef CONFIG_PM_SLEEP instead

You're right, someone already pointed this out, thanks.

I will re-submit in ~1min.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Lee Jones]

Prevents build warning:

st_thermal.c:278:12:
    warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
st_thermal.c:286:12:
    warning: ?st_thermal_resume? defined but not used [-Wunused-function]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---

v1 => v2:
 - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.

 drivers/thermal/st/st_thermal.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
index 90163b3..d1ec580 100644
--- a/drivers/thermal/st/st_thermal.c
+++ b/drivers/thermal/st/st_thermal.c
@@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev)
 }
 EXPORT_SYMBOL_GPL(st_thermal_unregister);
 
+#ifdef CONFIG_PM_SLEEP
 static int st_thermal_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
@@ -305,6 +306,8 @@ static int st_thermal_resume(struct device *dev)
 
 	return 0;
 }
+#endif
+
 SIMPLE_DEV_PM_OPS(st_thermal_pm_ops, st_thermal_suspend, st_thermal_resume);
 EXPORT_SYMBOL_GPL(st_thermal_pm_ops);
 
-- 
1.9.1

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Fabio Estevam]

On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> Prevents build warning:
>
> st_thermal.c:278:12:
>     warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> st_thermal.c:286:12:
>     warning: ?st_thermal_resume? defined but not used [-Wunused-function]
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> v1 => v2:
>  - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.

You should also update the Subject to 'when !PM_SLEEP'

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Lee Jones]

On Wed, 19 Nov 2014, Fabio Estevam wrote:

> On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > Prevents build warning:
> >
> > st_thermal.c:278:12:
> >     warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> > st_thermal.c:286:12:
> >     warning: ?st_thermal_resume? defined but not used [-Wunused-function]
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >
> > v1 => v2:
> >  - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
> 
> You should also update the Subject to 'when !PM_SLEEP'

I guess we should, yes.

Zhang, Eduardo,

Are you happy to do that, or would you like me to re-spin again?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH] thermal: sti: Ignore suspend/resume functions when !PM

[Eduardo Valentin]

Hello Lee,

On Wed, Nov 19, 2014 at 04:40:40PM +0000, Lee Jones wrote:
> On Wed, 19 Nov 2014, Fabio Estevam wrote:
> 
> > On Wed, Nov 19, 2014 at 1:50 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > > Prevents build warning:
> > >
> > > st_thermal.c:278:12:
> > >     warning: ?st_thermal_suspend? defined but not used [-Wunused-function]
> > > st_thermal.c:286:12:
> > >     warning: ?st_thermal_resume? defined but not used [-Wunused-function]
> > >
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >
> > > v1 => v2:
> > >  - CONFIG_PM => CONFIG_PM_SLEEP suggested by David Paris.
> > 
> > You should also update the Subject to 'when !PM_SLEEP'
> 
> I guess we should, yes.
> 
> Zhang, Eduardo,
> 
> Are you happy to do that, or would you like me to re-spin again?
> 

I can edit the patch for you this time.

Next time, when sending new versions, a couple of advices:
(1) add the Ack's/Reviewed's/Tested's -by  you get along the way.
(2) please, version you patches, it easies maintainter's life while
reviewing / applying your patches.

Thanks for sending the fix.

Eduardo Valentin

> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org ? Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141121/0449ed82/attachment.sig>