linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-08-29 14:18 Icenowy Zheng
  2016-08-31 16:22 ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Icenowy Zheng @ 2016-08-29 14:18 UTC (permalink / raw)
  To: linux-arm-kernel

UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
on iNet D978 Rev2 board.

Enable the UART1 to make it possible to use the modified hciattach by
Realtek to drive the BT part of RTL8723BS.

On the board no r_uart pins are found now (the onboard RX/TX pins are
wired to PF2/PF4, which is muxed with mmc0), so also disabled it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
Changes since v1:
- Deleted r_uart.
- Added the pinmux of uart1 at PG.
Changes since v2:
- Rename uart0_cts_rts at 0 to uart0-cts-rts at 0.

 arch/arm/boot/dts/sun8i-a23-a33.dtsi           | 14 ++++++++++++++
 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 20 ++++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
index 7e05e09..d236104 100644
--- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
@@ -361,6 +361,20 @@
 				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 			};
 
+			uart1_pins_a: uart1 at 0 {
+				allwinner,pins = "PG6", "PG7";
+				allwinner,function = "uart1";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart1_pins_cts_rts_a: uart1-cts-rts at 0 {
+				allwinner,pins = "PG8", "PG9";
+				allwinner,function = "uart1";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			mmc0_pins_a: mmc0 at 0 {
 				allwinner,pins = "PF0", "PF1", "PF2",
 						 "PF3", "PF4", "PF5";
diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
index 0f52cd9..a1f654a8 100644
--- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
+++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
@@ -49,6 +49,15 @@
 	model = "INet-D978 Rev 02";
 	compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
 
+	aliases {
+		/delete-property/serial0;
+		serial1 = &uart1;
+	};
+
+	chosen {
+		/delete-property/stdout-path;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
@@ -86,3 +95,14 @@
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
 };
+
+&r_uart {
+	status = "disabled";
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1_pins_a>,
+		    <&uart1_pins_cts_rts_a>;
+	status = "okay";
+};
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
  2016-08-29 14:18 [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
@ 2016-08-31 16:22 ` Maxime Ripard
  2016-09-01  8:40   ` [linux-sunxi] " Hans de Goede
  0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2016-08-31 16:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Aug 29, 2016 at 10:18:32PM +0800, Icenowy Zheng wrote:
> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> on iNet D978 Rev2 board.
> 
> Enable the UART1 to make it possible to use the modified hciattach by
> Realtek to drive the BT part of RTL8723BS.
> 
> On the board no r_uart pins are found now (the onboard RX/TX pins are
> wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

I'll make the same comments than in the v2.
https://www.spinics.net/lists/arm-kernel/msg527001.html

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160831/5d5b5392/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [linux-sunxi] Re: [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
  2016-08-31 16:22 ` Maxime Ripard
@ 2016-09-01  8:40   ` Hans de Goede
  2016-09-02  7:43     ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2016-09-01  8:40 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 31-08-16 18:22, Maxime Ripard wrote:
> On Mon, Aug 29, 2016 at 10:18:32PM +0800, Icenowy Zheng wrote:
>> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
>> on iNet D978 Rev2 board.
>>
>> Enable the UART1 to make it possible to use the modified hciattach by
>> Realtek to drive the BT part of RTL8723BS.
>>
>> On the board no r_uart pins are found now (the onboard RX/TX pins are
>> wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> I'll make the same comments than in the v2.
> https://www.spinics.net/lists/arm-kernel/msg527001.html

I've a feeling there is a bit of miscommunication here,
let me try to clarify things:

Icenowy, Maxime wants you to split this into 2 patches:

1) Adding just the uart1_pins_a and uart1_pins_cts_rts_a nodes to
sun8i-a23-a33.dtsi; and
2) Another patch with the sun8i-a33-inet-d978-rev2.dts changes

And for 2. Maxime wants you to change:

	aliases {
		/delete-property/serial0;
		serial1 = &uart1;
	};

to:

	aliases {
		serial0 = &uart1;
	};

There is no serial0 and Maxime wants the serial-s
to be numbered starting at 0 (iow there is no reason
to make the bluetooth uart serial1).

Regards,

Hans

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [linux-sunxi] Re: [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
  2016-09-01  8:40   ` [linux-sunxi] " Hans de Goede
@ 2016-09-02  7:43     ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2016-09-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 01, 2016 at 10:40:32AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 31-08-16 18:22, Maxime Ripard wrote:
> >On Mon, Aug 29, 2016 at 10:18:32PM +0800, Icenowy Zheng wrote:
> >>UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> >>on iNet D978 Rev2 board.
> >>
> >>Enable the UART1 to make it possible to use the modified hciattach by
> >>Realtek to drive the BT part of RTL8723BS.
> >>
> >>On the board no r_uart pins are found now (the onboard RX/TX pins are
> >>wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
> >>
> >>Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >
> >I'll make the same comments than in the v2.
> >https://www.spinics.net/lists/arm-kernel/msg527001.html
> 
> I've a feeling there is a bit of miscommunication here,
> let me try to clarify things:
> 
> Icenowy, Maxime wants you to split this into 2 patches:

Hmm, yes, sorry if it was unclear.

Thanks Hans

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160902/97f9d7fe/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-02  7:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-29 14:18 [PATCH v3] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
2016-08-31 16:22 ` Maxime Ripard
2016-09-01  8:40   ` [linux-sunxi] " Hans de Goede
2016-09-02  7:43     ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).