* [PATCH 2/3] ARM: dts: r7s72100: add ethernet to device tree
2016-09-01 15:54 [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Chris Brandt
@ 2016-09-01 15:54 ` Chris Brandt
2016-09-01 20:50 ` Geert Uytterhoeven
2016-09-01 15:54 ` [PATCH 3/3] ARM: dts: rskrza1: add ethernet DT support Chris Brandt
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Chris Brandt @ 2016-09-01 15:54 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
arch/arm/boot/dts/r7s72100.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index e8e2a5d7..fb9ef9c 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -108,6 +108,15 @@
clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7";
};
+ mstp7_clks: mstp7_clks at fcfe0430 {
+ #clock-cells = <1>;
+ compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
+ reg = <0xfcfe0430 4>;
+ clocks = <&p0_clk>;
+ clock-indices = <R7S72100_CLK_ETHER>;
+ clock-output-names = "ether";
+ };
+
mstp9_clks: mstp9_clks at fcfe0438 {
#clock-cells = <1>;
compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
@@ -419,4 +428,17 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ ether: ethernet at e8203000 {
+ compatible = "renesas,ether-r7s72100";
+ reg = <0xe8203000 0x800>,
+ <0xe8204800 0x200>;
+ interrupts = <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R7S72100_CLK_ETHER>;
+ power-domains = <&cpg_clocks>;
+ phy-mode = "mii";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
--
2.9.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/3] ARM: dts: r7s72100: add ethernet to device tree
2016-09-01 15:54 ` [PATCH 2/3] ARM: dts: r7s72100: add ethernet " Chris Brandt
@ 2016-09-01 20:50 ` Geert Uytterhoeven
0 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-09-01 20:50 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
But...
> ---"
> arch/arm/boot/dts/r7s72100.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index e8e2a5d7..fb9ef9c 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -108,6 +108,15 @@
> clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7";
> };
>
> + mstp7_clks: mstp7_clks at fcfe0430 {
> + #clock-cells = <1>;
> + compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
> + reg = <0xfcfe0430 4>;
> + clocks = <&p0_clk>;
> + clock-indices = <R7S72100_CLK_ETHER>;
> + clock-output-names = "ether";
> + };
> +
... please move this chunk to "[PATCH 1/3] ARM: dts: r7s72100: add ethernet
clock to device tree.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/3] ARM: dts: rskrza1: add ethernet DT support
2016-09-01 15:54 [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Chris Brandt
2016-09-01 15:54 ` [PATCH 2/3] ARM: dts: r7s72100: add ethernet " Chris Brandt
@ 2016-09-01 15:54 ` Chris Brandt
2016-09-01 20:50 ` Geert Uytterhoeven
2016-09-01 16:30 ` [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Sergei Shtylyov
` (2 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Chris Brandt @ 2016-09-01 15:54 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
arch/arm/boot/dts/r7s72100-rskrza1.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts
index aabfa04..e5dea5b 100644
--- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
@@ -47,6 +47,15 @@
status = "okay";
};
+ðer {
+ status = "okay";
+ renesas,no-ether-link;
+ phy-handle = <&phy0>;
+ phy0: ethernet-phy at 0 {
+ reg = <0>;
+ };
+};
+
&scif2 {
status = "okay";
};
--
2.9.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/3] ARM: dts: rskrza1: add ethernet DT support
2016-09-01 15:54 ` [PATCH 3/3] ARM: dts: rskrza1: add ethernet DT support Chris Brandt
@ 2016-09-01 20:50 ` Geert Uytterhoeven
0 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-09-01 20:50 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree
2016-09-01 15:54 [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Chris Brandt
2016-09-01 15:54 ` [PATCH 2/3] ARM: dts: r7s72100: add ethernet " Chris Brandt
2016-09-01 15:54 ` [PATCH 3/3] ARM: dts: rskrza1: add ethernet DT support Chris Brandt
@ 2016-09-01 16:30 ` Sergei Shtylyov
2016-09-01 16:38 ` Chris Brandt
2016-09-01 19:35 ` Geert Uytterhoeven
2016-09-02 1:40 ` [PATCH v2 " Chris Brandt
4 siblings, 1 reply; 15+ messages in thread
From: Sergei Shtylyov @ 2016-09-01 16:30 UTC (permalink / raw)
To: linux-arm-kernel
On 09/01/2016 06:54 PM, Chris Brandt wrote:
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
> include/dt-bindings/clock/r7s72100-clock.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h
> index 5128f4d..3cd8138 100644
> --- a/include/dt-bindings/clock/r7s72100-clock.h
> +++ b/include/dt-bindings/clock/r7s72100-clock.h
> @@ -25,6 +25,9 @@
> #define R7S72100_CLK_SCIF6 1
> #define R7S72100_CLK_SCIF7 0
>
> +/* MSTP7 */
> +#define R7S72100_CLK_ETHER 4
> +
> /* MSTP9 */
> #define R7S72100_CLK_I2C0 7
> #define R7S72100_CLK_I2C1 6
I'd add the MSTP7 clock node itself in the same patch...
MBR, Sergei
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree
2016-09-01 15:54 [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Chris Brandt
` (2 preceding siblings ...)
2016-09-01 16:30 ` [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Sergei Shtylyov
@ 2016-09-01 19:35 ` Geert Uytterhoeven
2016-09-02 1:40 ` [PATCH v2 " Chris Brandt
4 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2016-09-01 19:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
But as Sergei mentioned, the addition of mstp7_clks to the .dtsi really belongs
in this patch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree
2016-09-01 15:54 [PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Chris Brandt
` (3 preceding siblings ...)
2016-09-01 19:35 ` Geert Uytterhoeven
@ 2016-09-02 1:40 ` Chris Brandt
2016-09-02 1:40 ` [PATCH v2 2/3] ARM: dts: r7s72100: add ethernet " Chris Brandt
` (2 more replies)
4 siblings, 3 replies; 15+ messages in thread
From: Chris Brandt @ 2016-09-02 1:40 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
* Added MSTP7 clock node
---
arch/arm/boot/dts/r7s72100.dtsi | 9 +++++++++
include/dt-bindings/clock/r7s72100-clock.h | 3 +++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index e8e2a5d7..6d29e8f 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -108,6 +108,15 @@
clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7";
};
+ mstp7_clks: mstp7_clks at fcfe0430 {
+ #clock-cells = <1>;
+ compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
+ reg = <0xfcfe0430 4>;
+ clocks = <&p0_clk>;
+ clock-indices = <R7S72100_CLK_ETHER>;
+ clock-output-names = "ether";
+ };
+
mstp9_clks: mstp9_clks at fcfe0438 {
#clock-cells = <1>;
compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h
index 5128f4d..3cd8138 100644
--- a/include/dt-bindings/clock/r7s72100-clock.h
+++ b/include/dt-bindings/clock/r7s72100-clock.h
@@ -25,6 +25,9 @@
#define R7S72100_CLK_SCIF6 1
#define R7S72100_CLK_SCIF7 0
+/* MSTP7 */
+#define R7S72100_CLK_ETHER 4
+
/* MSTP9 */
#define R7S72100_CLK_I2C0 7
#define R7S72100_CLK_I2C1 6
--
2.9.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 2/3] ARM: dts: r7s72100: add ethernet to device tree
2016-09-02 1:40 ` [PATCH v2 " Chris Brandt
@ 2016-09-02 1:40 ` Chris Brandt
2016-09-02 1:40 ` [PATCH v2 3/3] ARM: dts: rskrza1: add ethernet DT support Chris Brandt
2016-09-02 8:26 ` [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Simon Horman
2 siblings, 0 replies; 15+ messages in thread
From: Chris Brandt @ 2016-09-02 1:40 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
* Removed MSTP7 clock node
---
arch/arm/boot/dts/r7s72100.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 6d29e8f..fb9ef9c 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -428,4 +428,17 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ ether: ethernet at e8203000 {
+ compatible = "renesas,ether-r7s72100";
+ reg = <0xe8203000 0x800>,
+ <0xe8204800 0x200>;
+ interrupts = <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R7S72100_CLK_ETHER>;
+ power-domains = <&cpg_clocks>;
+ phy-mode = "mii";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
--
2.9.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 3/3] ARM: dts: rskrza1: add ethernet DT support
2016-09-02 1:40 ` [PATCH v2 " Chris Brandt
2016-09-02 1:40 ` [PATCH v2 2/3] ARM: dts: r7s72100: add ethernet " Chris Brandt
@ 2016-09-02 1:40 ` Chris Brandt
2016-09-02 8:26 ` [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Simon Horman
2 siblings, 0 replies; 15+ messages in thread
From: Chris Brandt @ 2016-09-02 1:40 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r7s72100-rskrza1.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts
index aabfa04..e5dea5b 100644
--- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
@@ -47,6 +47,15 @@
status = "okay";
};
+ðer {
+ status = "okay";
+ renesas,no-ether-link;
+ phy-handle = <&phy0>;
+ phy0: ethernet-phy at 0 {
+ reg = <0>;
+ };
+};
+
&scif2 {
status = "okay";
};
--
2.9.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree
2016-09-02 1:40 ` [PATCH v2 " Chris Brandt
2016-09-02 1:40 ` [PATCH v2 2/3] ARM: dts: r7s72100: add ethernet " Chris Brandt
2016-09-02 1:40 ` [PATCH v2 3/3] ARM: dts: rskrza1: add ethernet DT support Chris Brandt
@ 2016-09-02 8:26 ` Simon Horman
2016-09-02 12:50 ` Chris Brandt
2 siblings, 1 reply; 15+ messages in thread
From: Simon Horman @ 2016-09-02 8:26 UTC (permalink / raw)
To: linux-arm-kernel
Thanks Chris,
I have queued up this and the following 2 patches for v4.9 (nothing more
for you to do unless something goes wrong in which case I'll let you know).
For future submissions please consider:
1. Supplying a cover letter (git format-patch has a --cover-letter option)
for patch-sets comprising more than one patch. This allows you to describe
an overview of what the series as a whole achieves. And is also
convenient for maintainers to reply to when accepting your patches.
2. Starting a new thread for each new version of a patch/patch-set.
Different maintainers have different preferences. The above are mine.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree
2016-09-02 8:26 ` [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree Simon Horman
@ 2016-09-02 12:50 ` Chris Brandt
2016-09-06 10:49 ` Simon Horman
0 siblings, 1 reply; 15+ messages in thread
From: Chris Brandt @ 2016-09-02 12:50 UTC (permalink / raw)
To: linux-arm-kernel
On 9/2/2016, Simon Horman wrote:
> For future submissions please consider:
> 1. Supplying a cover letter (git format-patch has a --cover-letter option)
> for patch-sets comprising more than one patch. This allows you to describe
> an overview of what the series as a whole achieves. And is also
> convenient for maintainers to reply to when accepting your patches.
OK. I can do that.
> 2. Starting a new thread for each new version of a patch/patch-set.
Does that mean to NOT use --in-reply-to= when submitting a v2,v3,etc... ????
One more question:
Can I submit a patches series now that just adds all the MSTP clock nodes that I'll be working on for the next couple weeks? (USB, SDHI, MMC)
Or, do I have to wait till I have the drivers working?
Or, better yet, can I add all the MSTP clocks that will probably get used at some point (basically, everything that we're using today in our 3.14 BSP).
Chris
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/3] ARM: dts: r7s72100: add ethernet clock to device tree
2016-09-02 12:50 ` Chris Brandt
@ 2016-09-06 10:49 ` Simon Horman
0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2016-09-06 10:49 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 02, 2016 at 12:50:39PM +0000, Chris Brandt wrote:
> On 9/2/2016, Simon Horman wrote:
> > For future submissions please consider:
> > 1. Supplying a cover letter (git format-patch has a --cover-letter option)
> > for patch-sets comprising more than one patch. This allows you to describe
> > an overview of what the series as a whole achieves. And is also
> > convenient for maintainers to reply to when accepting your patches.
>
> OK. I can do that.
>
>
> > 2. Starting a new thread for each new version of a patch/patch-set.
>
> Does that mean to NOT use --in-reply-to= when submitting a v2,v3,etc... ????
I think so.
> One more question:
> Can I submit a patches series now that just adds all the MSTP clock nodes that I'll be working on for the next couple weeks? (USB, SDHI, MMC)
> Or, do I have to wait till I have the drivers working?
> Or, better yet, can I add all the MSTP clocks that will probably get used at some point (basically, everything that we're using today in our 3.14 BSP).
I think that would be ok. I would slightly prefer that MSTP patches are
added in such a way that they can be tested. But in this case I'm not
sure anyone would test them :^)
^ permalink raw reply [flat|nested] 15+ messages in thread