* [PATCH] clk: sunxi-ng: mark ccu_nk_find_best() static
@ 2016-09-01 10:51 Baoyou Xie
2016-09-01 19:54 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-01 10:51 UTC (permalink / raw)
To: linux-arm-kernel
We get 1 warning when building kernel with W=1:
drivers/clk/sunxi-ng/ccu_nk.c:17:6: warning: no previous prototype for 'ccu_nk_find_best' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/clk/sunxi-ng/ccu_nk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi-ng/ccu_nk.c b/drivers/clk/sunxi-ng/ccu_nk.c
index 4470ffc..2adb62e 100644
--- a/drivers/clk/sunxi-ng/ccu_nk.c
+++ b/drivers/clk/sunxi-ng/ccu_nk.c
@@ -14,7 +14,7 @@
#include "ccu_gate.h"
#include "ccu_nk.h"
-void ccu_nk_find_best(unsigned long parent, unsigned long rate,
+static void ccu_nk_find_best(unsigned long parent, unsigned long rate,
unsigned int max_n, unsigned int max_k,
unsigned int *n, unsigned int *k)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] clk: sunxi-ng: mark ccu_nk_find_best() static
2016-09-01 10:51 [PATCH] clk: sunxi-ng: mark ccu_nk_find_best() static Baoyou Xie
@ 2016-09-01 19:54 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2016-09-01 19:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, Sep 01, 2016 at 06:51:48PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/sunxi-ng/ccu_nk.c:17:6: warning: no previous prototype for 'ccu_nk_find_best' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
A similar patch has been merged already.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160901/e2f1f1f1/attachment-0001.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-01 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-01 10:51 [PATCH] clk: sunxi-ng: mark ccu_nk_find_best() static Baoyou Xie
2016-09-01 19:54 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).