linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 0/9] clk: ti: add support for clkctrl clocks
Date: Tue, 11 Apr 2017 09:24:55 -0700	[thread overview]
Message-ID: <20170411162455.GK5339@atomide.com> (raw)
In-Reply-To: <74c65472-cc1c-1ab9-7d27-65a164a6f025@ti.com>

* Tero Kristo <t-kristo@ti.com> [170410 11:36]:
> On 10/04/17 19:18, Tony Lindgren wrote:
> > * Tero Kristo <t-kristo@ti.com> [170410 00:34]:
> > > On 07/04/17 19:47, Tony Lindgren wrote:
> > > > OK hdmi works now on panda for both omapfb and omapdrm. Any ideas why
> > > > that change is now needed though?
> > > 
> > > Yes, it is pretty clear actually. Previously, the hwmod main clock was
> > > controlling the hdmi clock, but this is now rerouted to the clkctrl module
> > > clock, which is shared between all DSS submodules. This leaves the hdmi
> > > clock disabled, causing the failure.
> > > 
> > > The fix just puts the hdmi clock into the optional clocks list, and forces
> > > all the optional clocks on when pm_runtime is enabled for the module.
> > 
> > OK so no need to fix it in the current kernels then.
> 
> Yeah, just need to figure out a clean order of applying these patches. The
> hwmod data change for DSS modules can most likely be applied before the dts
> change for clkctrl is going in, as it is just causing double clk_enable /
> disable for the main clocks in that case.

Yeah no idea about the hwmod change needed for DSS.. Maybe patch it in
only in the no "ti,hwmods" path?

For the rest, how about the following for getting things patched with
a minimal patching needed to revert in case of regressions:

1. Let's add the clkctrl driver and it's dts clocks. Let's tag the
   new clkctrl clocks with status = "disabled" and not add the
   consumers into any existing devices

2. Let's modify the dts files to add the hwmod related items for the
   wrapper IP module but let's keep things probing the old way using
   compatible = "simple-bus" for now

3. Let's add the wrapper IP driver and make sure it does nothing
   except probe the children just like "simple-bus" currently does if
   the child module has the "ti,hwmods" property set

4. Then we can finally start flipping things over one module at a
   time just by removing "ti,hwmods" for the child device and
   status = "disabled" for the related module clock

Regards,

Tony

      reply	other threads:[~2017-04-11 16:24 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17  9:09 [PATCHv2 0/9] clk: ti: add support for clkctrl clocks Tero Kristo
2017-03-17  9:09 ` [PATCHv2 1/9] Documentation: dt-bindings: Add binding documentation for TI " Tero Kristo
2017-03-17 14:18   ` Tony Lindgren
2017-03-17 15:01     ` Tero Kristo
2017-03-17  9:09 ` [PATCHv2 2/9] clk: ti: add support for " Tero Kristo
2017-03-17  9:09 ` [PATCHv2 3/9] dt-bindings: clk: add omap4 clkctrl definitions Tero Kristo
2017-04-24 21:49   ` Tony Lindgren
2017-03-17  9:09 ` [PATCHv2 4/9] clk: ti: omap4: add clkctrl clock data Tero Kristo
2017-03-17  9:09 ` [PATCHv2 5/9] ARM: OMAP2+: hwmod: assign main clock from DT if available Tero Kristo
2017-03-17 15:41   ` Tony Lindgren
2017-03-17 21:40     ` Tero Kristo
2017-03-17 22:17       ` Tony Lindgren
2017-03-20 13:23         ` Tero Kristo
2017-03-20 14:34           ` Tony Lindgren
2017-03-20 14:36             ` Tony Lindgren
2017-03-17  9:09 ` [PATCHv2 6/9] ARM: OMAP2+: timer: add support for fetching fck handle from DT Tero Kristo
2017-03-17 15:41   ` Tony Lindgren
2017-03-17  9:09 ` [PATCHv2 7/9] ARM: dts: omap4: add bus functionality to base PRCM nodes Tero Kristo
2017-03-17  9:09 ` [PATCHv2 8/9] ARM: dts: omap4: add clkctrl nodes Tero Kristo
2017-03-17 15:43   ` Tony Lindgren
2017-03-17 21:41     ` Tero Kristo
2017-03-20 13:25       ` Tero Kristo
2017-03-20 14:35         ` Tony Lindgren
2017-03-20 14:52           ` Tero Kristo
2017-03-20 15:07             ` Tony Lindgren
2017-03-17  9:09 ` [PATCHv2 9/9] ARM: dts: omap4: convert to use the new clkctrl clocks for the drivers Tero Kristo
2017-03-28  0:18   ` Tony Lindgren
2017-03-28  5:44     ` Tero Kristo
2017-03-28 15:03       ` Tony Lindgren
2017-03-30  7:33         ` Tero Kristo
2017-04-03 14:16           ` Tony Lindgren
2017-03-17 15:25 ` [PATCHv2 0/9] clk: ti: add support for clkctrl clocks Tony Lindgren
2017-03-17 21:37   ` Tero Kristo
2017-03-23  1:00     ` Tony Lindgren
2017-03-23 17:02       ` Tony Lindgren
2017-03-28  5:41         ` Tero Kristo
2017-03-30  7:18         ` Tero Kristo
2017-03-30 16:54           ` Tony Lindgren
2017-04-03 14:51             ` Tero Kristo
2017-04-03 15:36               ` Tony Lindgren
2017-04-05 16:59                 ` Tero Kristo
2017-04-06 16:49                 ` Tero Kristo
2017-04-07 16:47                   ` Tony Lindgren
2017-04-10  7:31                     ` Tero Kristo
2017-04-10 16:18                       ` Tony Lindgren
2017-04-10 18:33                         ` Tero Kristo
2017-04-11 16:24                           ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411162455.GK5339@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).