From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 0/9] clk: ti: add support for clkctrl clocks
Date: Thu, 30 Mar 2017 10:18:14 +0300 [thread overview]
Message-ID: <8648f054-cf04-41df-20f3-82e0d63feefa@ti.com> (raw)
In-Reply-To: <20170323170210.GL10760@atomide.com>
On 23/03/17 19:02, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [170322 18:03]:
>> * Tero Kristo <t-kristo@ti.com> [170317 14:39]:
>>> On 17/03/17 17:25, Tony Lindgren wrote:
>>>> * Tero Kristo <t-kristo@ti.com> [170317 02:12]:
>>>>> Any additional testing on omap4 welcome as this series basically
>>>>> tweaks every possible peripheral clock on the SoC.
>>>>
>>>> Without the last patch in this series, booting fails for me:
>>>>
>>>> [ 5.074890] l4_per_cm:clk:0120:0: failed to disable
>>>> [ 5.085113] l4_per_cm:clk:0128:0: failed to disable
>>>>
>>>> Care to check that booting keeps working for each patch in the
>>>> series to avoid breaking git bisect for booting?
>>>
>>> Hmm, I think patch 8+9 need to be squashed then. I can double check this
>>> next week though.
>>
>> Also looks like with this set merged HDMI stops working on
>> omap4 with:
>>
>> HDMIWP: omapdss HDMIWP error: Failed to set PHY power mode to 1
>
> Forgot to mention that's with omapdrm with encoder-tpd12s015 and
> encoder-tfp410 modules loaded to get HDMI working. Here's more verbose
> dmesg output in case that provides more clues:
>
> [ 91.042877] omapdss HDMICORE error: operation stopped when reading edid
> [ 91.078308] [drm] Enabling DMM ywrap scrolling
> [ 91.099243] omapdss HDMIWP error: Failed to set PHY power mode to 1
> [ 91.107879] omapdss HDMI error: failed to power on device
> [ 91.107879] omapdrm omapdrm.0: Failed to enable display 'hdmi': -5
> [ 91.359619] omapdrm omapdrm.0: atomic complete timeout (pipe 0)!
> [ 91.619964] omapdrm omapdrm.0: atomic complete timeout (pipe 0)!
> [ 91.620300] Console: switching to colour frame buffer device 128x48
> [ 91.682434] omapdrm omapdrm.0: fb0: omapdrm frame buffer device
> [ 91.770812] [drm] Initialized omapdrm 1.0.0 20110917 for omapdrm.0 on minor 0
> [ 92.818054] omapdss HDMICORE error: operation stopped when reading edid
> [ 93.090087] omapdrm omapdrm.0: atomic complete timeout (pipe 0)!
> [ 93.349853] omapdrm omapdrm.0: atomic complete timeout (pipe 0)!
>
> Regards,
>
> Tony
>
Can you try with this additional hwmod data tweak in place? Apply this
on top of the existing series.
===========
From 8ba1829078ea9a7417a34564fde8a30c9bdeb273 Mon Sep 17 00:00:00 2001
From: Tero Kristo <t-kristo@ti.com>
Date: Thu, 30 Mar 2017 10:09:59 +0300
Subject: [PATCH] ARM: OMAP4: hwmod_data: add opt clks for dss_hdmi and
dss_venc
These extra optional clocks are required as main clock for these modules
are going to be routed to the main module clock. Otherwise, the hdmi / tv
clocks are not going to be enabled during usage, leading to failure.
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index dad871a..2a9d092 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -775,6 +775,7 @@
static struct omap_hwmod_opt_clk dss_hdmi_opt_clks[] = {
{ .role = "sys_clk", .clk = "dss_sys_clk" },
+ { .role = "hdmi_clk", .clk = "dss_48mhz_clk" },
};
static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
@@ -858,6 +859,10 @@
};
/* dss_venc */
+static struct omap_hwmod_opt_clk dss_venc_opt_clks[] = {
+ { .role = "tv_clk", .clk = "dss_tv_clk" },
+};
+
static struct omap_hwmod omap44xx_dss_venc_hwmod = {
.name = "dss_venc",
.class = &omap44xx_venc_hwmod_class,
@@ -870,6 +875,8 @@
},
},
.parent_hwmod = &omap44xx_dss_hwmod,
+ .opt_clks = dss_venc_opt_clks,
+ .opt_clks_cnt = ARRAY_SIZE(dss_venc_opt_clks),
};
/*
--
1.9.1
next prev parent reply other threads:[~2017-03-30 7:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 9:09 [PATCHv2 0/9] clk: ti: add support for clkctrl clocks Tero Kristo
2017-03-17 9:09 ` [PATCHv2 1/9] Documentation: dt-bindings: Add binding documentation for TI " Tero Kristo
2017-03-17 14:18 ` Tony Lindgren
2017-03-17 15:01 ` Tero Kristo
2017-03-17 9:09 ` [PATCHv2 2/9] clk: ti: add support for " Tero Kristo
2017-03-17 9:09 ` [PATCHv2 3/9] dt-bindings: clk: add omap4 clkctrl definitions Tero Kristo
2017-04-24 21:49 ` Tony Lindgren
2017-03-17 9:09 ` [PATCHv2 4/9] clk: ti: omap4: add clkctrl clock data Tero Kristo
2017-03-17 9:09 ` [PATCHv2 5/9] ARM: OMAP2+: hwmod: assign main clock from DT if available Tero Kristo
2017-03-17 15:41 ` Tony Lindgren
2017-03-17 21:40 ` Tero Kristo
2017-03-17 22:17 ` Tony Lindgren
2017-03-20 13:23 ` Tero Kristo
2017-03-20 14:34 ` Tony Lindgren
2017-03-20 14:36 ` Tony Lindgren
2017-03-17 9:09 ` [PATCHv2 6/9] ARM: OMAP2+: timer: add support for fetching fck handle from DT Tero Kristo
2017-03-17 15:41 ` Tony Lindgren
2017-03-17 9:09 ` [PATCHv2 7/9] ARM: dts: omap4: add bus functionality to base PRCM nodes Tero Kristo
2017-03-17 9:09 ` [PATCHv2 8/9] ARM: dts: omap4: add clkctrl nodes Tero Kristo
2017-03-17 15:43 ` Tony Lindgren
2017-03-17 21:41 ` Tero Kristo
2017-03-20 13:25 ` Tero Kristo
2017-03-20 14:35 ` Tony Lindgren
2017-03-20 14:52 ` Tero Kristo
2017-03-20 15:07 ` Tony Lindgren
2017-03-17 9:09 ` [PATCHv2 9/9] ARM: dts: omap4: convert to use the new clkctrl clocks for the drivers Tero Kristo
2017-03-28 0:18 ` Tony Lindgren
2017-03-28 5:44 ` Tero Kristo
2017-03-28 15:03 ` Tony Lindgren
2017-03-30 7:33 ` Tero Kristo
2017-04-03 14:16 ` Tony Lindgren
2017-03-17 15:25 ` [PATCHv2 0/9] clk: ti: add support for clkctrl clocks Tony Lindgren
2017-03-17 21:37 ` Tero Kristo
2017-03-23 1:00 ` Tony Lindgren
2017-03-23 17:02 ` Tony Lindgren
2017-03-28 5:41 ` Tero Kristo
2017-03-30 7:18 ` Tero Kristo [this message]
2017-03-30 16:54 ` Tony Lindgren
2017-04-03 14:51 ` Tero Kristo
2017-04-03 15:36 ` Tony Lindgren
2017-04-05 16:59 ` Tero Kristo
2017-04-06 16:49 ` Tero Kristo
2017-04-07 16:47 ` Tony Lindgren
2017-04-10 7:31 ` Tero Kristo
2017-04-10 16:18 ` Tony Lindgren
2017-04-10 18:33 ` Tero Kristo
2017-04-11 16:24 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8648f054-cf04-41df-20f3-82e0d63feefa@ti.com \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).