* [PATCH -next] clk: sunxi-ng: de2: fix wrong pointer passed to PTR_ERR()
@ 2017-05-18 15:55 Wei Yongjun
2017-05-19 8:26 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-05-18 15:55 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
PTR_ERR should access the value just tested by IS_ERR, otherwise
the wrong error code will be returned.
Fixes: b0d9a4bd52bd ("clk: sunxi-ng: add support for DE2 CCU")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
index 15aaa9c..5cdaf52 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c
@@ -184,7 +184,7 @@ static int sunxi_de2_clk_probe(struct platform_device *pdev)
rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rstc)) {
- ret = PTR_ERR(bus_clk);
+ ret = PTR_ERR(rstc);
if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev,
"Couldn't get reset control: %d\n", ret);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] clk: sunxi-ng: de2: fix wrong pointer passed to PTR_ERR()
2017-05-18 15:55 [PATCH -next] clk: sunxi-ng: de2: fix wrong pointer passed to PTR_ERR() Wei Yongjun
@ 2017-05-19 8:26 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-05-19 8:26 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 18, 2017 at 03:55:13PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> PTR_ERR should access the value just tested by IS_ERR, otherwise
> the wrong error code will be returned.
>
> Fixes: b0d9a4bd52bd ("clk: sunxi-ng: add support for DE2 CCU")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170519/3c6fb3d9/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-19 8:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 15:55 [PATCH -next] clk: sunxi-ng: de2: fix wrong pointer passed to PTR_ERR() Wei Yongjun
2017-05-19 8:26 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).