* [PATCH 0/2] orange-pi-zero: minor updates for board peripherals
@ 2017-05-19 21:35 Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR Sergey Matyukevich
0 siblings, 2 replies; 8+ messages in thread
From: Sergey Matyukevich @ 2017-05-19 21:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
These two patches simplify the use of orange-pi-zero board
right out of the box:
- add interrupt triggering for the on-board XR819 SDIO WiFi chip
- enable on-board SPI NOR
Regards,
Sergey
sun8i-h2-plus-orangepi-zero.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip
2017-05-19 21:35 [PATCH 0/2] orange-pi-zero: minor updates for board peripherals Sergey Matyukevich
@ 2017-05-19 21:35 ` Sergey Matyukevich
2017-05-22 7:49 ` Maxime Ripard
2017-05-19 21:35 ` [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR Sergey Matyukevich
1 sibling, 1 reply; 8+ messages in thread
From: Sergey Matyukevich @ 2017-05-19 21:35 UTC (permalink / raw)
To: linux-arm-kernel
Specify interrupt triggering for XR819 SDIO WiFi chip
on orange-pi-zero board.
For more details see: http://linux-sunxi.org/Wifi#Allwinner
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---
arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
index 9e8b082c134f..34e4a5a80136 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
@@ -128,6 +128,8 @@
*/
xr819: sdio_wifi at 1 {
reg = <1>;
+ interrupt-parent = <&pio>;
+ interrupts = <6 10 IRQ_TYPE_EDGE_RISING>;
};
};
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR
2017-05-19 21:35 [PATCH 0/2] orange-pi-zero: minor updates for board peripherals Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip Sergey Matyukevich
@ 2017-05-19 21:35 ` Sergey Matyukevich
2017-05-22 9:29 ` Maxime Ripard
1 sibling, 1 reply; 8+ messages in thread
From: Sergey Matyukevich @ 2017-05-19 21:35 UTC (permalink / raw)
To: linux-arm-kernel
Enable SPI NOR on orange-pi-zero board.
For more information see:
- http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---
arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
index 34e4a5a80136..fe39e96cee65 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
@@ -177,3 +177,19 @@
status = "okay";
usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
};
+
+&spi0 {
+ status = "okay";
+
+ flash at 0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "mxicy,mx25l1606e", "winbond,w25q128";
+ reg = <0>;
+ spi-max-frequency = <40000000>;
+
+ partition at 00000000 {
+ reg = <0x00000000 0x200000>; /* 2Mb */
+ };
+ };
+};
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip
2017-05-19 21:35 ` [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip Sergey Matyukevich
@ 2017-05-22 7:49 ` Maxime Ripard
2017-05-22 19:49 ` Sergey Matyukevich
0 siblings, 1 reply; 8+ messages in thread
From: Maxime Ripard @ 2017-05-22 7:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergey,
Thanks for your patches!
On Sat, May 20, 2017 at 12:35:49AM +0300, Sergey Matyukevich wrote:
> Specify interrupt triggering for XR819 SDIO WiFi chip
> on orange-pi-zero board.
>
> For more details see: http://linux-sunxi.org/Wifi#Allwinner
Please don't reference details in a wiki page. URLs can change and
wiki page get rewritten. git history is immutable. Your commit log
should contain everything there is.
The patch itself looks good though.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170522/36f6dc73/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR
2017-05-19 21:35 ` [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR Sergey Matyukevich
@ 2017-05-22 9:29 ` Maxime Ripard
2017-05-22 20:30 ` Sergey Matyukevich
0 siblings, 1 reply; 8+ messages in thread
From: Maxime Ripard @ 2017-05-22 9:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergey,
On Sat, May 20, 2017 at 12:35:50AM +0300, Sergey Matyukevich wrote:
> Enable SPI NOR on orange-pi-zero board.
>
> For more information see:
> - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
Same remark here than on the first patch
>
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> index 34e4a5a80136..fe39e96cee65 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -177,3 +177,19 @@
> status = "okay";
> usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
> };
> +
> +&spi0 {
> + status = "okay";
> +
> + flash at 0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
How do the other OPi Zero that doesn't have that SPI flash behave?
> +
> + partition at 00000000 {
> + reg = <0x00000000 0x200000>; /* 2Mb */
> + };
There's no need to create a first partition, this needs to be
user-defined.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170522/2c848e31/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip
2017-05-22 7:49 ` Maxime Ripard
@ 2017-05-22 19:49 ` Sergey Matyukevich
0 siblings, 0 replies; 8+ messages in thread
From: Sergey Matyukevich @ 2017-05-22 19:49 UTC (permalink / raw)
To: linux-arm-kernel
> >
> > For more details see: http://linux-sunxi.org/Wifi#Allwinner
>
> Please don't reference details in a wiki page. URLs can change and
> wiki page get rewritten. git history is immutable. Your commit log
> should contain everything there is.
>
> The patch itself looks good though.
Ok, I will provide a more detailed commit message and resubmit.
Thanks,
Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR
2017-05-22 9:29 ` Maxime Ripard
@ 2017-05-22 20:30 ` Sergey Matyukevich
2017-05-24 6:35 ` Maxime Ripard
0 siblings, 1 reply; 8+ messages in thread
From: Sergey Matyukevich @ 2017-05-22 20:30 UTC (permalink / raw)
To: linux-arm-kernel
> > For more information see:
> > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
>
> Same remark here than on the first patch
Ok, I will provide a more detailed commit message
w/o external references.
> > +&spi0 {
> > + status = "okay";
> > +
> > + flash at 0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> > + reg = <0>;
> > + spi-max-frequency = <40000000>;
>
> How do the other OPi Zero that doesn't have that SPI flash behave?
Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash
was optional in the first production batch in Dec 2016. In later
batches flash chip was pre-populated. However there are should
be quite a few boards around which do not have flash.
Does it make sense to set status to 'disabled' by default adding
appropriate comment in the commit message ?
> > +
> > + partition at 00000000 {
> > + reg = <0x00000000 0x200000>; /* 2Mb */
> > + };
>
> There's no need to create a first partition, this needs to be
> user-defined.
Ok, than it probably makes sense to drop it from dts. User-defined
list of partitions can be passed via kernel command line.
Thanks,
Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR
2017-05-22 20:30 ` Sergey Matyukevich
@ 2017-05-24 6:35 ` Maxime Ripard
0 siblings, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2017-05-24 6:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergey,
On Mon, May 22, 2017 at 11:30:12PM +0300, Sergey Matyukevich wrote:
> > > For more information see:
> > > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
> >
> > Same remark here than on the first patch
>
> Ok, I will provide a more detailed commit message
> w/o external references.
>
> > > +&spi0 {
> > > + status = "okay";
> > > +
> > > + flash at 0 {
> > > + #address-cells = <1>;
> > > + #size-cells = <1>;
> > > + compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> > > + reg = <0>;
> > > + spi-max-frequency = <40000000>;
> >
> > How do the other OPi Zero that doesn't have that SPI flash behave?
>
> Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash
> was optional in the first production batch in Dec 2016. In later
> batches flash chip was pre-populated. However there are should
> be quite a few boards around which do not have flash.
>
> Does it make sense to set status to 'disabled' by default adding
> appropriate comment in the commit message ?
If it's just that the driver fails to probe, we can live with that I
guess. If not, then yes, that's a solution too.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170524/80610cf3/attachment-0001.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-24 6:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 21:35 [PATCH 0/2] orange-pi-zero: minor updates for board peripherals Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip Sergey Matyukevich
2017-05-22 7:49 ` Maxime Ripard
2017-05-22 19:49 ` Sergey Matyukevich
2017-05-19 21:35 ` [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR Sergey Matyukevich
2017-05-22 9:29 ` Maxime Ripard
2017-05-22 20:30 ` Sergey Matyukevich
2017-05-24 6:35 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).