From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1
Date: Tue, 13 Feb 2018 09:05:12 +0100 [thread overview]
Message-ID: <20180213080512.huhc6pkowhie74nq@verge.net.au> (raw)
In-Reply-To: <1518457475-4480-1-git-send-email-fabrizio.castro@bp.renesas.com>
On Mon, Feb 12, 2018 at 05:44:09PM +0000, Fabrizio Castro wrote:
> Dear All,
>
> this series has been around for some time as RFC, and it has collected
> useful comments from the community along the way.
> The solution proposed by this patch set works for most R-Car Gen2 and
> RZ/G1 devices, but not all of them. We now know that for some R-Car
> Gen2 early revisions there is no proper software fix. Anyway, no
> product has been built around early revisions, but development boards
> mounting early revisions (basically prototypes) are still out there.
> As a result, this series isn't enabling the internal watchdog on R-Car
> Gen2 boards, developers may enable it in board specific device trees
> if needed.
> This series has been tested by me on the iwg20d, iwg22d, Lager, Alt,
> and Koelsch boards.
>
> The problem
> ===========
> To deal with SMP on R-Car Gen2 and RZ/G1, we install a reset vector
> to ICRAM1 and we program the [S]BAR registers so that when we turn ON
> the non-boot CPUs they are redirected to the reset vector installed by
> Linux in ICRAM1, and eventually they continue the execution to RAM,
> where the SMP bring-up code will take care of the rest.
> The content of the [S]BAR registers survives a watchdog triggered reset,
> and as such after the watchdog fires the boot core will try and execute
> the SMP bring-up code instead of jumping to the bootrom code.
>
> The fix
> =======
> The main strategy for the solution is to let the reset vector decide
> if it needs to jump to shmobile_boot_fn or to the bootrom code.
> In a watchdog triggered reset scenario, since the [S]BAR registers keep
> their values, the boot CPU will jump into the newly designed reset
> vector, the assembly routine will eventually test WOVF (a bit in register
> RWTCSRA that indicates if the watchdog counter has overflown, the value
> of this bit gets retained in this scenario), and jump to the bootrom code
> which will in turn load up the bootloader, etc.
> When bringing up SMP or using CPU hotplug, the reset vector will jump
> to shmobile_boot_fn instead.
>
> Thank you All for your help.
>
> Best regards,
>
> Fabrizio Castro (26):
> ARM: shmobile: Add watchdog support
> ARM: dts: r8a7743: Adjust SMP routine size
> ARM: dts: r8a7745: Adjust SMP routine size
> ARM: dts: r8a7790: Adjust SMP routine size
> ARM: dts: r8a7791: Adjust SMP routine size
> ARM: dts: r8a7792: Adjust SMP routine size
> ARM: dts: r8a7793: Adjust SMP routine size
> ARM: dts: r8a7794: Adjust SMP routine size
> soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2
> ARM: shmobile: rcar-gen2: Add watchdog support
> dt-bindings: watchdog: renesas-wdt: Add R-Car Gen2 support
> watchdog: renesas_wdt: Add R-Car Gen2 support
> watchdog: renesas_wdt: Add restart handler
> ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN
> clk: renesas: r8a7743: Add rwdt clock
> clk: renesas: r8a7745: Add rwdt clock
> clk: renesas: r8a7790: Add rwdt clock
> clk: renesas: r8a7791/r8a7793: Add rwdt clock
> clk: renesas: r8a7794: Add rwdt clock
> ARM: dts: r8a7743: Add watchdog support to SoC dtsi
> ARM: dts: r8a7745: Add watchdog support to SoC dtsi
> ARM: dts: r8a7790: Add watchdog support to SoC dtsi
> ARM: dts: r8a7791: Add watchdog support to SoC dtsi
> ARM: dts: r8a7794: Add watchdog support to SoC dtsi
> ARM: dts: iwg20m: Add watchdog support to SoM dtsi
> ARM: dts: iwg22m: Add watchdog support to SoM dtsi
Thanks, I have applied the above "dts" and "defconfig" patches for v4.17.
next prev parent reply other threads:[~2018-02-13 8:05 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 17:44 [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1 Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 01/26] ARM: shmobile: Add watchdog support Fabrizio Castro
2018-02-28 12:57 ` Geert Uytterhoeven
2018-02-28 17:37 ` Fabrizio Castro
2018-02-28 17:40 ` [PATCH v6 " Fabrizio Castro
2018-03-01 9:44 ` Simon Horman
2018-03-13 13:43 ` Geert Uytterhoeven
2018-03-14 11:02 ` Fabrizio Castro
2018-03-14 11:13 ` [PATCH v7] " Fabrizio Castro
2018-03-14 12:43 ` Simon Horman
2018-03-14 13:26 ` Fabrizio Castro
2018-03-16 11:49 ` Simon Horman
2018-02-12 17:44 ` [PATCH v5 02/26] ARM: dts: r8a7743: Adjust SMP routine size Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 03/26] ARM: dts: r8a7745: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 04/26] ARM: dts: r8a7790: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 05/26] ARM: dts: r8a7791: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 06/26] ARM: dts: r8a7792: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 07/26] ARM: dts: r8a7793: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 08/26] ARM: dts: r8a7794: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2 Fabrizio Castro
2018-02-13 8:19 ` Simon Horman
2018-02-13 12:57 ` Fabrizio Castro
2018-02-13 13:02 ` [PATCH v6 " Fabrizio Castro
2018-02-15 16:20 ` Simon Horman
2018-02-12 17:44 ` [PATCH v5 10/26] ARM: shmobile: rcar-gen2: Add watchdog support Fabrizio Castro
2018-02-13 8:21 ` Simon Horman
2018-02-12 17:44 ` [PATCH v5 11/26] dt-bindings: watchdog: renesas-wdt: Add R-Car Gen2 support Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 12/26] watchdog: renesas_wdt: " Fabrizio Castro
2018-02-12 19:24 ` Guenter Roeck
2018-02-12 20:58 ` Wolfram Sang
2018-02-28 19:24 ` Geert Uytterhoeven
2018-03-01 15:34 ` Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 13/26] watchdog: renesas_wdt: Add restart handler Fabrizio Castro
2018-02-12 20:59 ` Wolfram Sang
2018-02-12 17:44 ` [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN Fabrizio Castro
2018-02-13 13:08 ` Fabrizio Castro
2018-02-15 16:20 ` Simon Horman
2018-05-02 9:38 ` Simon Horman
2018-02-12 17:44 ` [PATCH v5 15/26] clk: renesas: r8a7743: Add rwdt clock Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 16/26] clk: renesas: r8a7745: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 17/26] clk: renesas: r8a7790: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 18/26] clk: renesas: r8a7791/r8a7793: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 19/26] clk: renesas: r8a7794: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 20/26] ARM: dts: r8a7743: Add watchdog support to SoC dtsi Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 21/26] ARM: dts: r8a7745: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 22/26] ARM: dts: r8a7790: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 23/26] ARM: dts: r8a7791: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 24/26] ARM: dts: r8a7794: " Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 25/26] ARM: dts: iwg20m: Add watchdog support to SoM dtsi Fabrizio Castro
2018-02-12 17:44 ` [PATCH v5 26/26] ARM: dts: iwg22m: " Fabrizio Castro
2018-02-13 8:05 ` Simon Horman [this message]
2018-02-20 12:51 ` [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1 Geert Uytterhoeven
2018-02-21 16:13 ` Simon Horman
2018-02-21 16:30 ` Geert Uytterhoeven
2018-02-21 18:32 ` Simon Horman
2018-02-22 8:38 ` Geert Uytterhoeven
2018-02-23 8:14 ` Simon Horman
2018-03-01 10:20 ` Geert Uytterhoeven
2018-03-13 20:05 ` Simon Horman
2018-03-14 8:17 ` Geert Uytterhoeven
2018-04-18 13:37 ` Geert Uytterhoeven
2018-04-24 9:09 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213080512.huhc6pkowhie74nq@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).