[PATCH v3 0/2] Staging: vchi: Add license id and change int type

[PATCH v3 0/2] Staging: vchi: Add license id and change int type

[andrealmeid at riseup.net]

From: Andr? Almeida <andrealmeid@riseup.net>

Fix the following checkpatch issues:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
CHECK: Prefer kernel type 's32' over 'int32_t'

Changes in v3:
- Remove license text from header file
- Modify commit message

Changes in v2:
- Splits commits in a patch set
- Fixes licenses in SPDX identifier
- Adds a more descriptive commit message

v2: https://www.spinics.net/lists/arm-kernel/msg686817.html

Andr? Almeida (2):
  staging: vchi: change type 'int32_t' to 's32'
  stagin: vchi: Add SPDX-License-Identifier

 .../vc04_services/interface/vchi/vchi_mh.h    | 32 ++-----------------
 1 file changed, 2 insertions(+), 30 deletions(-)

-- 
2.19.1

[PATCH v3 1/2] staging: vchi: change type 'int32_t' to 's32'

[andrealmeid at riseup.net]

From: Andr? Almeida <andrealmeid@riseup.net>

As one can see in a typedef at linux/types.h:103, s32 and int32_t are
both a 32 bits signed integer. s32 is preferred because it is defined
by the kernel maintainers and it prevents portability issues. Changed
to meet checkpatch criteria.

Signed-off-by: Andr? Almeida <andrealmeid@riseup.net>
---
 drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
index 198bd076b666..40c760d493a1 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
@@ -36,7 +36,7 @@
 
 #include <linux/types.h>
 
-typedef int32_t VCHI_MEM_HANDLE_T;
+typedef s32 VCHI_MEM_HANDLE_T;
 #define VCHI_MEM_HANDLE_INVALID 0
 
 #endif
-- 
2.19.1

[PATCH v3 2/2] stagin: vchi: Add SPDX-License-Identifier

[andrealmeid at riseup.net]

From: Andr? Almeida <andrealmeid@riseup.net>

Using multiple license representation as shown here [1].
[1] https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf

Signed-off-by: Andr? Almeida <andrealmeid@riseup.net>

---

Thanks for the feedback Stefan. I've tried to make the code similar
to your example. Let me know if it's still wrong.
---
 .../vc04_services/interface/vchi/vchi_mh.h    | 30 +------------------
 1 file changed, 1 insertion(+), 29 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
index 40c760d493a1..bbf227e4f21a 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h
@@ -1,34 +1,6 @@
+/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) */
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions, and the following disclaimer,
- *    without modification.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- * 3. The names of the above-listed copyright holders may not be used
- *    to endorse or promote products derived from this software without
- *    specific prior written permission.
- *
- * ALTERNATIVELY, this software may be distributed under the terms of the
- * GNU General Public License ("GPL") version 2, as published by the Free
- * Software Foundation.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
- * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
- * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
- * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef VCHI_MH_H_
-- 
2.19.1

[PATCH v3 2/2] stagin: vchi: Add SPDX-License-Identifier

[Stefan Wahren]

> andrealmeid at riseup.net hat am 13. November 2018 um 19:58 geschrieben:
> 
> 
> From: Andr? Almeida <andrealmeid@riseup.net>
> 
> Using multiple license representation as shown here [1].
> [1] https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf
> 
> Signed-off-by: Andr? Almeida <andrealmeid@riseup.net>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>