* [RFC] ARM: dts: imx7d-nitrogen7: Use mmc-pwrseq to activate the Wifi clock
@ 2018-11-29 9:27 Fabio Estevam
2018-11-29 23:55 ` Troy Kisky
2018-12-05 3:32 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2018-11-29 9:27 UTC (permalink / raw)
To: linux-arm-kernel
In order to turn on the Wifi clock the correct location for describing
the CLKO2 clock is via a mmc-pwrseq handle, so do it accordingly.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi Gary/Troy,
I don't have access to this board, but I was working on something similar
for imx7d-pico-pi and needed to add mmc-pwrseq in order to turn on
the 32kHz clock:
http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/616048.html
Is the 32kHz clock still needed for the Wifi chip used in the latest
version of nitrogen7?
What do you think about this patch?
Thanks
arch/arm/boot/dts/imx7d-nitrogen7.dts | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx7d-nitrogen7.dts b/arch/arm/boot/dts/imx7d-nitrogen7.dts
index 4fb7e84..9ba9084 100644
--- a/arch/arm/boot/dts/imx7d-nitrogen7.dts
+++ b/arch/arm/boot/dts/imx7d-nitrogen7.dts
@@ -87,13 +87,17 @@
compatible = "regulator-fixed";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
- clock-names = "slow";
regulator-name = "reg_wlan";
startup-delay-us = <70000>;
gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
+
+ usdhc2_pwrseq: usdhc2_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
+ clock-names = "slow";
+ };
};
&adc1 {
@@ -376,6 +380,7 @@
bus-width = <4>;
non-removable;
vmmc-supply = <®_wlan>;
+ mmc-pwrseq = <&usdhc2_pwrseq>;
cap-power-off-card;
keep-power-in-suspend;
status = "okay";
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] ARM: dts: imx7d-nitrogen7: Use mmc-pwrseq to activate the Wifi clock
2018-11-29 9:27 [RFC] ARM: dts: imx7d-nitrogen7: Use mmc-pwrseq to activate the Wifi clock Fabio Estevam
@ 2018-11-29 23:55 ` Troy Kisky
2018-12-05 3:32 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Troy Kisky @ 2018-11-29 23:55 UTC (permalink / raw)
To: Fabio Estevam, shawnguo; +Cc: gary.bisson, linux-arm-kernel
On 11/29/2018 1:27 AM, Fabio Estevam wrote:
> In order to turn on the Wifi clock the correct location for describing
> the CLKO2 clock is via a mmc-pwrseq handle, so do it accordingly.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi Gary/Troy,
>
> I don't have access to this board, but I was working on something similar
> for imx7d-pico-pi and needed to add mmc-pwrseq in order to turn on
> the 32kHz clock:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/616048.html
>
> Is the 32kHz clock still needed for the Wifi chip used in the latest
> version of nitrogen7?
>
> What do you think about this patch?
>
> Thanks
>
> arch/arm/boot/dts/imx7d-nitrogen7.dts | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-nitrogen7.dts b/arch/arm/boot/dts/imx7d-nitrogen7.dts
> index 4fb7e84..9ba9084 100644
> --- a/arch/arm/boot/dts/imx7d-nitrogen7.dts
> +++ b/arch/arm/boot/dts/imx7d-nitrogen7.dts
> @@ -87,13 +87,17 @@
> compatible = "regulator-fixed";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> - clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> - clock-names = "slow";
Yes, since mainline does not know about a clock in a fixed regulator, your patch is needed.
Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
Thanks
> regulator-name = "reg_wlan";
> startup-delay-us = <70000>;
> gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
> +
> + usdhc2_pwrseq: usdhc2_pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> + clock-names = "slow";
> + };
> };
>
> &adc1 {
> @@ -376,6 +380,7 @@
> bus-width = <4>;
> non-removable;
> vmmc-supply = <®_wlan>;
> + mmc-pwrseq = <&usdhc2_pwrseq>;
> cap-power-off-card;
> keep-power-in-suspend;
> status = "okay";
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] ARM: dts: imx7d-nitrogen7: Use mmc-pwrseq to activate the Wifi clock
2018-11-29 9:27 [RFC] ARM: dts: imx7d-nitrogen7: Use mmc-pwrseq to activate the Wifi clock Fabio Estevam
2018-11-29 23:55 ` Troy Kisky
@ 2018-12-05 3:32 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-12-05 3:32 UTC (permalink / raw)
To: Fabio Estevam; +Cc: gary.bisson, linux-arm-kernel, troy.kisky
On Thu, Nov 29, 2018 at 07:27:59AM -0200, Fabio Estevam wrote:
> In order to turn on the Wifi clock the correct location for describing
> the CLKO2 clock is via a mmc-pwrseq handle, so do it accordingly.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-05 3:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 9:27 [RFC] ARM: dts: imx7d-nitrogen7: Use mmc-pwrseq to activate the Wifi clock Fabio Estevam
2018-11-29 23:55 ` Troy Kisky
2018-12-05 3:32 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).