From: Mark Brown <broonie@kernel.org>
To: Claudiu.Beznea@microchip.com
Cc: len.brown@intel.com, alexandre.belloni@bootlin.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
rjw@rjwysocki.net, lgirdwood@gmail.com,
Ludovic.Desroches@microchip.com, pavel@ucw.cz,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend
Date: Wed, 9 Jan 2019 16:57:06 +0000 [thread overview]
Message-ID: <20190109165706.GG10405@sirena.org.uk> (raw)
In-Reply-To: <1546944944-13911-3-git-send-email-claudiu.beznea@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 824 bytes --]
On Tue, Jan 08, 2019 at 10:56:32AM +0000, Claudiu.Beznea@microchip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>
> Add helper to check if regulator will be disabled in suspend.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
This feels like it's the wrong way round - if this is configurable I'd
expect something to configure the suspend mode and then for that to
arrange to configure the regulator appropriately (along with anything
else that needs doing) rather than to infer the configuration from the
regulator state which feels fragile. But based on the cover letter
that's kind of like what the initial proposal about target states was so
perhaps this is the way we end up going... this certainly looks a lot
less impactful that the target state stuff though.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-09 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 10:56 [PATCH v2 0/3] add support for power off check in suspend Claudiu.Beznea
2019-01-08 10:56 ` [PATCH v2 1/3] PM / Suspend: Add support to check if platform's power is off " Claudiu.Beznea
2019-01-09 14:14 ` Pavel Machek
2019-01-10 10:24 ` Claudiu.Beznea
2019-01-08 10:56 ` [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled " Claudiu.Beznea
2019-01-09 16:57 ` Mark Brown [this message]
2019-01-10 10:24 ` Claudiu.Beznea
2019-01-11 12:39 ` Mark Brown
2019-01-11 14:08 ` Claudiu.Beznea
2019-01-14 22:53 ` Mark Brown
2019-01-15 9:19 ` Claudiu.Beznea
2019-01-08 10:56 ` [PATCH v2 3/3] ARM: at91: pm: add support for .off_in_suspend Claudiu.Beznea
2019-01-08 11:46 ` [PATCH v2 0/3] add support for power off check in suspend Rafael J. Wysocki
2019-01-08 14:07 ` Claudiu.Beznea
2019-01-28 9:50 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109165706.GG10405@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).