From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: dts: imx6qdl-phytec-pfla02: Replace magic numbers
Date: Sat, 12 Jan 2019 11:13:19 +0800 [thread overview]
Message-ID: <20190112031318.GT32649@dragon> (raw)
In-Reply-To: <20181223163141.6792-3-shc_work@mail.ru>
On Sun, Dec 23, 2018 at 07:31:40PM +0300, Alexander Shiyan wrote:
> Use GPIO_ACTIVE_LOW/HIGH for GPIO description.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 211640e..81007d6 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -23,7 +23,7 @@
> regulator-name = "usb_otg_vbus";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> - gpio = <&gpio4 15 0>;
> + gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
>
> @@ -33,7 +33,7 @@
> regulator-name = "usb_h1_vbus";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> - gpio = <&gpio1 0 0>;
> + gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
> };
> @@ -43,12 +43,12 @@
>
> green {
> label = "phyflex:green";
> - gpios = <&gpio1 30 0>;
> + gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>;
> };
>
> red {
> label = "phyflex:red";
> - gpios = <&gpio2 31 0>;
> + gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> };
> };
> };
> @@ -69,7 +69,7 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi3>;
> status = "okay";
> - cs-gpios = <&gpio4 24 0>;
> + cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
GPIO_ACTIVE_LOW is defined as 1 rather than 0.
Shawn
>
> flash@0 {
> compatible = "m25p80", "jedec,spi-nor";
> --
> 2.10.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-12 3:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 16:31 [PATCH 1/4] ARM: dts: imx6q-phytec-pbab01: Remove duplicate "chosen" node Alexander Shiyan
2018-12-23 16:31 ` [PATCH 2/4] ARM: dts: imx6q/dl-phytec-pfla02: Remove duplicate nodes Alexander Shiyan
2018-12-23 16:31 ` [PATCH 3/4] ARM: dts: imx6qdl-phytec-pfla02: Replace magic numbers Alexander Shiyan
2019-01-12 3:13 ` Shawn Guo [this message]
2018-12-23 16:31 ` [PATCH 4/4] ARM: dts: imx6qdl-phytec-pfla02: Add some labels Alexander Shiyan
2019-01-12 3:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112031318.GT32649@dragon \
--to=shawnguo@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).